-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Scenes] MaxCapacity fix #31981
Merged
mergify
merged 2 commits into
project-chip:master
from
lpbeliveau-silabs:bugfix/scenes_max_capacity_multifabric
Feb 14, 2024
Merged
[Scenes] MaxCapacity fix #31981
mergify
merged 2 commits into
project-chip:master
from
lpbeliveau-silabs:bugfix/scenes_max_capacity_multifabric
Feb 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #31981: Size comparison from 86977c2 to 763b815 Increases (20 builds for cc13x4_26x4, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, stm32, telink)
Decreases (1 build for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
lpbeliveau-silabs
force-pushed
the
bugfix/scenes_max_capacity_multifabric
branch
2 times, most recently
from
February 7, 2024 15:20
011b957
to
e53f63d
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov and
LuDuda
February 7, 2024 15:21
pullapprove
bot
requested review from
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
February 7, 2024 15:21
PR #31981: Size comparison from 18bf8c0 to e53f63d Increases (20 builds for cc13x4_26x4, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, stm32, telink)
Decreases (1 build for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
jmartinez-silabs
approved these changes
Feb 9, 2024
lpbeliveau-silabs
force-pushed
the
bugfix/scenes_max_capacity_multifabric
branch
from
February 13, 2024 16:25
e53f63d
to
576a6c7
Compare
PR #31981: Size comparison from db09a64 to 576a6c7 Full report (20 builds for bl602, bl702, bl702l, cc32xx, k32w, mbed, qpg)
|
…ource Exhausted for Copy Scene and Store Scene along with tests
lpbeliveau-silabs
force-pushed
the
bugfix/scenes_max_capacity_multifabric
branch
from
February 13, 2024 17:27
576a6c7
to
672794c
Compare
PR #31981: Size comparison from f5b4caf to 672794c Increases (20 builds for cc13x4_26x4, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, stm32, telink)
Decreases (1 build for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
andy31415
reviewed
Feb 14, 2024
andy31415
reviewed
Feb 14, 2024
andy31415
approved these changes
Feb 14, 2024
raul-marquez-csa
pushed a commit
to raul-marquez-csa/connectedhomeip
that referenced
this pull request
Feb 16, 2024
* Added refresh on read to the FabricSceneInfo capacity and patched Resource Exhausted for Copy Scene and Store Scene along with tests * Applied suggested fix on ReturnOnFailure and /* = name*/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added refresh on read to the FabricSceneInfo capacity
Patched Resource Exhausted for Copy Scene and Store Scene (proper mapping of CHIP->IMStatus errors is still needed)
Added a MaxCapacity yaml test to confirm everything works as expected.
Fixes: #31955