-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Darwin] Initial framework to track and collect metrics for operations #31784
[Darwin] Initial framework to track and collect metrics for operations #31784
Conversation
PR #31784: Size comparison from af29ce6 to c0339c7 Increases above 0.2%:
Increases (15 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (3 builds for efr32, psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #31784: Size comparison from af29ce6 to 478411c Increases above 0.2%:
Increases (16 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (3 builds for efr32, psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
478411c
to
5b50a4b
Compare
PR #31784: Size comparison from bdbd6de to 5b50a4b Decreases (1 build for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
5b50a4b
to
a33f73a
Compare
PR #31784: Size comparison from 839c565 to a33f73a Decreases (1 build for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
a33f73a
to
b1774c8
Compare
PR #31784: Size comparison from 0bd5786 to b1774c8 Decreases (1 build for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
@@ -82,6 +83,20 @@ MTR_AVAILABLE(ios(16.4), macos(13.3), watchos(9.4), tvos(16.4)) | |||
commissioningComplete:(NSError * _Nullable)error | |||
nodeID:(NSNumber * _Nullable)nodeID MTR_AVAILABLE(ios(17.0), macos(14.0), watchos(10.0), tvos(17.0)); | |||
|
|||
/** | |||
* Notify the delegate when commissioning is completed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably document that if it's implemented it will be called and the other methods will not be?
Those other methods should have been documenting that too.
if (nsError) { | ||
[metrics setValue:nsError forKey:MTRMetricCommissioningStatusKey]; | ||
} else { | ||
auto * error = [NSError errorWithDomain:MTRErrorDomain code:0 userInfo:nil]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this instead of nil? At the very least, this behavior should be documented somehere in the API. Because comparing NSError *
to nil is what people will normally reach for...
This is an initial framework APIs to track metrics collection for various operations in the APIs