Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASN.1 null writer check should not bypass reading from TLVReader #31088

Merged

Conversation

ksperling-apple
Copy link
Contributor

... since it is just intended to be an optimization.

... since it is just intended to be an optimization.
Copy link

github-actions bot commented Dec 19, 2023

PR #31088: Size comparison from 5786a35 to 03d60c8

Decreases (1 build for efr32)
platform target config section 5786a35 03d60c8 change % change
efr32 lock-app BRD4161A+wf200 (read/write) 1114832 1114824 -8 -0.0
.text 923284 923276 -8 -0.0
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 5786a35 03d60c8 change % change
bl602 lighting-app bl602 (read/write) 1417794 1417794 0 0.0
.bss 85160 85160 0 0.0
.data 9416 9416 0 0.0
.rodata 156912 156912 0 0.0
.text 1085664 1085664 0 0.0
bl602+mfd (read/write) 1432522 1432522 0 0.0
.bss 85328 85328 0 0.0
.data 9384 9384 0 0.0
.rodata 155872 155872 0 0.0
.text 1101288 1101288 0 0.0
bl602+rpc (read/write) 1465578 1465578 0 0.0
.bss 93192 93192 0 0.0
.data 9784 9784 0 0.0
.rodata 164536 164536 0 0.0
.text 1117408 1117408 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1182811 1182811 0 0.0
.bss 11197 11197 0 0.0
.data 3584 3584 0 0.0
.rodata 106288 106288 0 0.0
.text 955366 955366 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1193943 1193943 0 0.0
.bss 11373 11373 0 0.0
.data 3568 3568 0 0.0
.rodata 105228 105228 0 0.0
.text 967430 967430 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1274823 1274823 0 0.0
.bss 19677 19677 0 0.0
.data 4144 4144 0 0.0
.rodata 121708 121708 0 0.0
.text 1030428 1030428 0 0.0
bl706-eth (read/write) 1002437 1002437 0 0.0
.bss 23772 23772 0 0.0
.data 3160 3160 0 0.0
.rodata 99620 99620 0 0.0
.text 748262 748262 0 0.0
bl706-wifi (read/write) 1240574 1240574 0 0.0
.bss 10641 10641 0 0.0
.data 3600 3600 0 0.0
.rodata 120600 120600 0 0.0
.text 975558 975558 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1152516 1152516 0 0.0
.bss 16392 16392 0 0.0
.data 4952 4952 0 0.0
.rodata 100292 100292 0 0.0
.text 948492 948492 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1163968 1163968 0 0.0
.bss 16568 16568 0 0.0
.data 4928 4928 0 0.0
.rodata 99232 99232 0 0.0
.text 960868 960868 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 771688 771688 0 0.0
(read/write) 168100 168100 0 0.0
.bss 90436 90436 0 0.0
.data 3460 3460 0 0.0
.rodata 89536 89536 0 0.0
.text 681884 681884 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 787792 787792 0 0.0
(read/write) 178328 178328 0 0.0
.bss 100612 100612 0 0.0
.data 3488 3488 0 0.0
.rodata 83792 83792 0 0.0
.text 703736 703736 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 776016 776016 0 0.0
(read/write) 172784 172784 0 0.0
.bss 95068 95068 0 0.0
.data 3488 3488 0 0.0
.rodata 110392 110392 0 0.0
.text 665360 665360 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 728632 728632 0 0.0
(read/write) 167096 167096 0 0.0
.bss 89208 89208 0 0.0
.data 3448 3448 0 0.0
.rodata 85112 85112 0 0.0
.text 643252 643252 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 714168 714168 0 0.0
(read/write) 167276 167276 0 0.0
.bss 89392 89392 0 0.0
.data 3444 3444 0 0.0
.rodata 80944 80944 0 0.0
.text 632956 632956 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 566994 566994 0 0.0
(read/write) 207652 207652 0 0.0
.bss 201116 201116 0 0.0
.data 1412 1412 0 0.0
.rodata 83938 83938 0 0.0
.text 480932 480932 0 0.0
lock CC3235SF_LAUNCHXL (read only) 620322 620322 0 0.0
(read/write) 208048 208048 0 0.0
.bss 201480 201480 0 0.0
.data 1448 1448 0 0.0
.rodata 105810 105810 0 0.0
.text 512388 512388 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 561007 561007 0 0.0
.app_xip_area 451257 451257 0 0.0
.bss 64664 64664 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 543231 543231 0 0.0
.app_xip_area 428745 428745 0 0.0
.bss 69360 69360 0 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 561967 561967 0 0.0
.app_xip_area 453673 453673 0 0.0
.bss 63280 63280 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 557399 557399 0 0.0
.app_xip_area 445881 445881 0 0.0
.bss 66400 66400 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1017020 1017020 0 0.0
.bss 172600 172600 0 0.0
.data 2688 2688 0 0.0
.text 841712 841712 0 0.0
BRD4187C (read/write) 1100956 1100956 0 0.0
.bss 196204 196204 0 0.0
.data 3296 3296 0 0.0
.text 901436 901436 0 0.0
lock-app BRD4161A+wf200 (read/write) 1114832 1114824 -8 -0.0
.bss 188816 188816 0 0.0
.data 2712 2712 0 0.0
.text 923284 923276 -8 -0.0
window-app BRD4187C (read/write) 1135744 1135744 0 0.0
.bss 168236 168236 0 0.0
.data 3168 3168 0 0.0
.text 964320 964320 0 0.0
esp32 all-clusters-app c3devkit (read only) 1137734 1137734 0 0.0
(read/write) 1671524 1671524 0 0.0
.dram0.bss 72872 72872 0 0.0
.dram0.data 12988 12988 0 0.0
.flash.rodata 241792 241792 0 0.0
.flash.text 1137734 1137734 0 0.0
.iram0.text 75694 75694 0 0.0
m5stack (read only) 1182731 1182731 0 0.0
(read/write) 520716 520716 0 0.0
.dram0.bss 79520 79520 0 0.0
.dram0.data 34004 34004 0 0.0
.flash.rodata 272828 272828 0 0.0
.flash.text 1177347 1177347 0 0.0
.iram0.text 123907 123907 0 0.0
k32w contact k32w0+release (read only) 605192 605192 0 0.0
(read/write) 81896 81896 0 0.0
.bss 69744 69744 0 0.0
.data 2168 2168 0 0.0
.text 604656 604656 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 690656 690656 0 0.0
.bss 67600 67600 0 0.0
.data 2716 2716 0 0.0
.text 576864 576864 0 0.0
light k32w0+release (read only) 594880 594880 0 0.0
(read/write) 79112 79112 0 0.0
.bss 67008 67008 0 0.0
.data 2120 2120 0 0.0
.text 594344 594344 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 782468 782468 0 0.0
.bss 77276 77276 0 0.0
.data 1928 1928 0 0.0
.text 659808 659808 0 0.0
lock k32w0+release (read only) 576296 576296 0 0.0
(read/write) 79376 79376 0 0.0
.bss 67296 67296 0 0.0
.data 2096 2096 0 0.0
.text 575760 575760 0 0.0
linux air-purifier-app debug (read only) 2525829 2525829 0 0.0
(read/write) 127208 127208 0 0.0
.bss 46944 46944 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 72824 72824 0 0.0
.dynamic 608 608 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 179240 179240 0 0.0
.text 2171285 2171285 0 0.0
all-clusters-app debug (read only) 5413377 5413377 0 0.0
(read/write) 455080 455080 0 0.0
.bss 131632 131632 0 0.0
.data 3840 3840 0 0.0
.data.rel.ro 312360 312360 0 0.0
.dynamic 624 624 0 0.0
.got 5336 5336 0 0.0
.init 27 27 0 0.0
.init_array 1264 1264 0 0.0
.rodata 312028 312028 0 0.0
.text 4691731 4691731 0 0.0
all-clusters-minimal-app debug (read only) 4952889 4952889 0 0.0
(read/write) 234688 234688 0 0.0
.bss 127856 127856 0 0.0
.data 3776 3776 0 0.0
.data.rel.ro 95960 95960 0 0.0
.dynamic 624 624 0 0.0
.got 5296 5296 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 272749 272749 0 0.0
.text 4447779 4447779 0 0.0
bridge-app debug (read only) 4416625 4416625 0 0.0
(read/write) 215928 215928 0 0.0
.bss 119224 119224 0 0.0
.data 4704 4704 0 0.0
.data.rel.ro 85280 85280 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 219061 219061 0 0.0
.text 3979091 3979091 0 0.0
chip-tool debug (read only) 11686985 11686985 0 0.0
(read/write) 504048 504048 0 0.0
.bss 94200 94200 0 0.0
.data 4994 4994 0 0.0
.data.rel.ro 397616 397616 0 0.0
.dynamic 624 624 0 0.0
.got 5784 5784 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 424585 424585 0 0.0
.text 10572515 10572515 0 0.0
chip-tool-ipv6only arm64 (read only) 11414256 11414256 0 0.0
(read/write) 572440 572440 0 0.0
.bss 103448 103448 0 0.0
.data 4288 4288 0 0.0
.data.rel.ro 436456 436456 0 0.0
.dynamic 512 512 0 0.0
.got 19816 19816 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 345048 345048 0 0.0
.text 10201256 10201256 0 0.0
lighting-app debug+rpc+ui (read only) 5302441 5302441 0 0.0
(read/write) 225000 225000 0 0.0
.bss 119360 119360 0 0.0
.data 4416 4416 0 0.0
.data.rel.ro 93696 93696 0 0.0
.dynamic 672 672 0 0.0
.got 5880 5880 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 340276 340276 0 0.0
.text 4717475 4717475 0 0.0
lock-app debug (read only) 4501649 4501649 0 0.0
(read/write) 203648 203648 0 0.0
.bss 113760 113760 0 0.0
.data 3648 3648 0 0.0
.data.rel.ro 79512 79512 0 0.0
.dynamic 624 624 0 0.0
.got 5216 5216 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 246901 246901 0 0.0
.text 4044819 4044819 0 0.0
ota-provider-app debug (read only) 4165817 4165817 0 0.0
(read/write) 192728 192728 0 0.0
.bss 113632 113632 0 0.0
.data 3904 3904 0 0.0
.data.rel.ro 69296 69296 0 0.0
.dynamic 624 624 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 201205 201205 0 0.0
.text 3772835 3772835 0 0.0
ota-requestor-app debug (read only) 4255305 4255305 0 0.0
(read/write) 197008 197008 0 0.0
.bss 114656 114656 0 0.0
.data 4176 4176 0 0.0
.data.rel.ro 72288 72288 0 0.0
.dynamic 624 624 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 205045 205045 0 0.0
.text 3854083 3854083 0 0.0
shell debug (read only) 2788217 2788217 0 0.0
(read/write) 152272 152272 0 0.0
.bss 62312 62312 0 0.0
.data 768 768 0 0.0
.data.rel.ro 83400 83400 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 1088 1088 0 0.0
.rodata 181824 181824 0 0.0
.text 2435474 2435474 0 0.0
thermostat-no-ble arm64 (read only) 4405248 4405248 0 0.0
(read/write) 245216 245216 0 0.0
.bss 122232 122232 0 0.0
.data 2784 2784 0 0.0
.data.rel.ro 102352 102352 0 0.0
.dynamic 512 512 0 0.0
.got 12008 12008 0 0.0
.init 24 24 0 0.0
.init_array 424 424 0 0.0
.rodata 162236 162236 0 0.0
.text 3902712 3902712 0 0.0
tv-app debug (read only) 5385993 5385993 0 0.0
(read/write) 349120 349120 0 0.0
.bss 244544 244544 0 0.0
.data 4992 4992 0 0.0
.data.rel.ro 92280 92280 0 0.0
.dynamic 624 624 0 0.0
.got 5512 5512 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 272885 272885 0 0.0
.text 4875267 4875267 0 0.0
tv-casting-app debug (read only) 9566393 9566393 0 0.0
(read/write) 338368 338368 0 0.0
.bss 156352 156352 0 0.0
.data 2464 2464 0 0.0
.data.rel.ro 172696 172696 0 0.0
.dynamic 624 624 0 0.0
.got 5064 5064 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 362760 362760 0 0.0
.text 8739779 8739779 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2525992 2525992 0 0.0
.bss 220216 220216 0 0.0
.data 5144 5144 0 0.0
.text 1488676 1488676 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1067684 1067684 0 0.0
bss 129393 129393 0 0.0
rodata 105396 105396 0 0.0
text 785324 785324 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1193776 1193776 0 0.0
bss 121603 121603 0 0.0
rodata 139156 139156 0 0.0
text 782692 782692 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1046696 1046696 0 0.0
bss 129348 129348 0 0.0
rodata 99448 99448 0 0.0
text 770272 770272 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 835864 835864 0 0.0
(read/write) 1750980 1750980 0 0.0
.bss 195004 195004 0 0.0
.data 2472 2472 0 0.0
.text 1545116 1545116 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837912 837912 0 0.0
(read/write) 1705940 1705940 0 0.0
.bss 192956 192956 0 0.0
.data 2472 2472 0 0.0
.text 1502124 1502124 0 0.0
light cy8ckit_062s2_43012 (read only) 844600 844600 0 0.0
(read/write) 1630924 1630924 0 0.0
.bss 186380 186380 0 0.0
.data 2360 2360 0 0.0
.text 1433796 1433796 0 0.0
lock cy8ckit_062s2_43012 (read only) 817480 817480 0 0.0
(read/write) 1657812 1657812 0 0.0
.bss 213476 213476 0 0.0
.data 2384 2384 0 0.0
.text 1433564 1433564 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1116572 1116572 0 0.0
.bss 101216 101216 0 0.0
.data 740 740 0 0.0
.text 628948 628948 0 0.0
lock-app qpg6105+debug (read/write) 1080564 1080564 0 0.0
.bss 97512 97512 0 0.0
.data 784 784 0 0.0
.text 592944 592944 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 821354 821354 0 0.0
bss 55064 55064 0 0.0
text 613712 613712 0 0.0
all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1086576 1086576 0 0.0
bss 100404 100404 0 0.0
text 767102 767102 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1084012 1084012 0 0.0
bss 109764 109764 0 0.0
text 753344 753344 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 934644 934644 0 0.0
bss 94272 94272 0 0.0
text 646762 646762 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 821590 821590 0 0.0
bss 55108 55108 0 0.0
text 614082 614082 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 4 4 0 0.0
(read/write) 978676 978676 0 0.0
bss 79092 79092 0 0.0
text 694172 694172 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1092992 1092992 0 0.0
bss 99836 99836 0 0.0
text 769654 769654 0 0.0
lock-app-dfu tlsr9528a (read only) 4 4 0 0.0
(read/write) 965308 965308 0 0.0
bss 97356 97356 0 0.0
text 647848 647848 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 948320 948320 0 0.0
bss 92380 92380 0 0.0
text 662870 662870 0 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 880388 880388 0 0.0
bss 69084 69084 0 0.0
text 622092 622092 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 821000 821000 0 0.0
bss 57320 57320 0 0.0
text 588968 588968 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 705600 705600 0 0.0
bss 73588 73588 0 0.0
text 462094 462094 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 823326 823326 0 0.0
bss 55244 55244 0 0.0
text 616826 616826 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 878093 878093 0 0.0
bss 60796 60796 0 0.0
text 630708 630708 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 845372 845372 0 0.0
bss 57616 57616 0 0.0
text 607434 607434 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 839648 839648 0 0.0
bss 57968 57968 0 0.0
text 601468 601468 0 0.0

@ksperling-apple ksperling-apple merged commit 75113fc into project-chip:master Dec 19, 2023
57 checks passed
@ksperling-apple ksperling-apple deleted the asn1-fix-nullwriter-check branch December 19, 2023 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants