-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark attributes nullable as needed for Thread Network Diagnostics cluster #18531
Merged
andy31415
merged 2 commits into
project-chip:master
from
yufengwangca:pr/cluster/threadnetwork
May 19, 2022
Merged
Mark attributes nullable as needed for Thread Network Diagnostics cluster #18531
andy31415
merged 2 commits into
project-chip:master
from
yufengwangca:pr/cluster/threadnetwork
May 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple and
jelderton
May 18, 2022 01:23
pullapprove
bot
requested review from
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
May 18, 2022 01:23
PR #18531: Size comparison from 5c70127 to 1602bf8 Increases (1 build for esp32)
Full report (6 builds for esp32, mbed, p6)
|
PR #18531: Size comparison from 76b1cb5 to ba3b86b Increases (5 builds for esp32, linux)
Full report (18 builds for esp32, linux, mbed, p6)
|
PR #18531: Size comparison from 3a7cbf8 to 7717d52 Increases (14 builds for cyw30739, efr32, k32w, linux, nrfconnect, telink)
Full report (29 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #18531: Size comparison from f68588d to 57833a9 Increases (14 builds for cyw30739, efr32, k32w, linux, nrfconnect, telink)
Full report (29 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #18531: Size comparison from 4ba6d4f to 4e6a2fe Increases (14 builds for cyw30739, efr32, k32w, linux, nrfconnect, telink)
Full report (31 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
approved these changes
May 19, 2022
jmartinez-silabs
approved these changes
May 19, 2022
PR #18531: Size comparison from a08c59b to bb1321d Increases (20 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, nrfconnect, telink)
Decreases (5 builds for cc13x2_26x2)
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
Change overview
Mark attributes nullable as needed for Thread Network Diagnostics cluster
Testing
How was this tested? (at least one bullet point required)