Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow external ownership of CHIPDeviceController operational key #18482

Merged
merged 6 commits into from
May 17, 2022
Merged

Allow external ownership of CHIPDeviceController operational key #18482

merged 6 commits into from
May 17, 2022

Conversation

tcarmelveilleux
Copy link
Contributor

Problem

  • For controllers that make use of their own key management,
    such as OS-aided key management, it is currently impossible
    to pass-in the Operational Key pair to use for a given controller.

Issue #18444
Issue #7695

Change overview

This PR adds APIs to avoid FabricTable from trying to manage
the lifecycle of the operational key, and allow the caller/initializer
of CHIPDeviceControllerFactory to properly inject its own operational
key that it manages, without attempts of storage or dynamic memory
management.

Testing

  • Unit tests still pass, cert tests as well
  • This was tested internally by us using the APIs to
    manage a key for Android. That change will be a follow-up

@tcarmelveilleux
Allow external ownership of CHIPDeviceController operational key
ef8a02e 
- For controllers that make use of their own key management,
  such as OS-aided key management, it is currently impossible
  to pass-in the Operational Key pair to use for a given controller.

This PR adds APIs to avoid FabricTable from trying to manage
the lifecycle of the operational key, and allow the caller/initializer
of CHIPDeviceControllerFactory to properly inject its own operational
key that it manages, without attempts of storage or dynamic memory
management.

Issue project-chip#18444
Issue project-chip#7695

Testing done:
- Unit tests still pass, cert tests as well
- This was tested internally by us using the APIs to
  manage a key for Android. That change will be a follow-up
@restyled-io restyled-io bot mentioned this pull request May 16, 2022
Closed
bzbarsky-apple
bzbarsky-apple reviewed May 16, 2022
View reviewed changes
src/controller/CHIPDeviceController.h Show resolved Hide resolved
src/credentials/FabricTable.cpp Outdated Show resolved Hide resolved
src/credentials/FabricTable.cpp Outdated Show resolved Hide resolved
src/credentials/FabricTable.cpp Show resolved Hide resolved
src/credentials/FabricTable.h Outdated Show resolved Hide resolved
src/credentials/FabricTable.h Outdated Show resolved Hide resolved
src/credentials/FabricTable.cpp Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented May 16, 2022 •
edited
Loading

PR #18482: Size comparison from ed43d59 to b0b50df

Increases above 0.2%:

platform target config section ed43d59 b0b50df change % change
linux bridge-app debug+rpc .bss 71616 71776 160 0.2
lighting-app debug+rpc .bss 73440 73600 160 0.2
lock-app debug .bss 72096 72256 160 0.2
ota-requestor-app debug .bss 72224 72384 160 0.2
shell debug .bss 114408 114664 256 0.2
Increases (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section ed43d59 b0b50df change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689259 689355 96 0.0
.text 585688 585784 96 0.0
lock-ftd LP_CC2652R7 (read only) 676603 676699 96 0.0
.text 581308 581404 96 0.0
lock-mtd LP_CC2652R7 (read only) 625419 625515 96 0.0
.text 530236 530332 96 0.0
pump-app LP_CC2652R7 (read only) 660175 660271 96 0.0
.text 579344 579440 96 0.0
pump-controller-app LP_CC2652R7 (read only) 653347 653443 96 0.0
.text 569416 569512 96 0.0
shell LP_CC2652R7 (read only) 683614 683710 96 0.0
.text 582492 582588 96 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 624498 624594 96 0.0
.app_xip_area 528112 528208 96 0.0
lock cyw930739m2evb_01 (read/write) 627558 627646 88 0.0
.app_xip_area 532628 532716 88 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 572202 572298 96 0.0
.app_xip_area 467556 467652 96 0.0
efr32 lighting-app BRD4161A (read only) 914812 915036 224 0.0
.text 914804 915028 224 0.0
BRD4161A+rpc (read only) 948984 949224 240 0.0
.text 948976 949216 240 0.0
BRD4161A+rs911x (read only) 784128 784352 224 0.0
.text 784120 784344 224 0.0
lock-app BRD4161A+wf200 (read only) 944940 945036 96 0.0
.text 944932 945028 96 0.0
window-app BRD4161A (read only) 894932 895156 224 0.0
.text 894924 895148 224 0.0
esp32 all-clusters-app c3devkit (read only) 996618 996758 140 0.0
.flash.text 996618 996758 140 0.0
m5stack (read only) 1052095 1052239 144 0.0
.flash.text 1046711 1046855 144 0.0
k32w light k32w061+release (read/write) 682388 682484 96 0.0
.text 598452 598548 96 0.0
lock k32w061+release (read/write) 728760 728840 80 0.0
.text 644432 644512 80 0.0
linux all-clusters-app debug (read only) 2732609 2733057 448 0.0
(read/write) 174456 174584 128 0.1
.bss 83808 83936 128 0.2
.text 2318786 2319234 448 0.0
bridge-app debug+rpc (read only) 2020825 2021273 448 0.0
(read/write) 146424 146584 160 0.1
.bss 71616 71776 160 0.2
.text 1695506 1695954 448 0.0
chip-tool debug (read only) 9235973 9236581 608 0.0
.text 7434085 7434693 608 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9015044 9015556 512 0.0
.text 7111972 7112484 512 0.0
lighting-app debug+rpc (read only) 2314441 2314889 448 0.0
(read/write) 151904 152064 160 0.1
.bss 73440 73600 160 0.2
.text 1960978 1961426 448 0.0
lock-app debug (read only) 2228377 2228825 448 0.0
(read/write) 146552 146712 160 0.1
.bss 72096 72256 160 0.2
.text 1870498 1870946 448 0.0
ota-provider-app debug (read only) 2049329 2049777 448 0.0
(read/write) 139632 139760 128 0.1
.bss 71584 71712 128 0.2
.text 1713698 1714146 448 0.0
ota-requestor-app debug (read only) 2078625 2079073 448 0.0
(read/write) 142440 142600 160 0.1
.bss 72224 72384 160 0.2
.text 1745362 1745810 448 0.0
shell debug (read only) 2548985 2549433 448 0.0
(read/write) 198256 198512 256 0.1
.bss 114408 114664 256 0.2
.text 2167378 2167826 448 0.0
thermostat-no-ble arm64 (read only) 2343092 2343492 400 0.0
(read/write) 175009 175153 144 0.1
.bss 86353 86497 144 0.2
.text 1966288 1966688 400 0.0
tv-app debug (read only) 2840129 2840737 608 0.0
(read/write) 277408 277536 128 0.0
.bss 189528 189656 128 0.1
.text 2437570 2438178 608 0.0
tv-casting-app debug (read only) 5402873 5403321 448 0.0
(read/write) 223680 223808 128 0.1
.bss 77144 77272 128 0.2
.text 4704706 4705154 448 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2418600 2418664 64 0.0
.text 1381244 1381308 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176903 1176999 96 0.0
text 807524 807620 96 0.0
p6 all-clusters-app default (read/write) 2529552 2529776 224 0.0
.text 1487816 1488040 224 0.0
light-app default (read/write) 2418488 2418712 224 0.0
.text 1376752 1376976 224 0.0
lock-app default (read/write) 2429136 2429360 224 0.0
.text 1387400 1387624 224 0.0
telink light-switch-app tlsr9518adk80d (read/write) 781904 782016 112 0.0
text 552922 553038 116 0.0
lighting-app tlsr9518adk80d (read/write) 801988 802108 120 0.0
text 569688 569804 116 0.0
Decreases (5 builds for cc13x2_26x2)
platform target config section ed43d59 b0b50df change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 162300 162204 -96 -0.1
lock-ftd LP_CC2652R7 (read/write) 166044 165948 -96 -0.1
pump-app LP_CC2652R7 (read/write) 183760 183664 -96 -0.1
pump-controller-app LP_CC2652R7 (read/write) 190388 190292 -96 -0.1
shell LP_CC2652R7 (read/write) 163768 163672 -96 -0.1
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section ed43d59 b0b50df change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689259 689355 96 0.0
(read/write) 162300 162204 -96 -0.1
.bss 74540 74540 0 0.0
.data 3412 3412 0 0.0
.rodata 103091 103091 0 0.0
.text 585688 585784 96 0.0
lock-ftd LP_CC2652R7 (read only) 676603 676699 96 0.0
(read/write) 166044 165948 -96 -0.1
.bss 72684 72684 0 0.0
.data 3236 3236 0 0.0
.rodata 94811 94811 0 0.0
.text 581308 581404 96 0.0
lock-mtd LP_CC2652R7 (read only) 625419 625515 96 0.0
(read/write) 145516 145516 0 0.0
.bss 68420 68420 0 0.0
.data 3236 3236 0 0.0
.rodata 94691 94691 0 0.0
.text 530236 530332 96 0.0
pump-app LP_CC2652R7 (read only) 660175 660271 96 0.0
(read/write) 183760 183664 -96 -0.1
.bss 72948 72948 0 0.0
.data 3268 3268 0 0.0
.rodata 80351 80351 0 0.0
.text 579344 579440 96 0.0
pump-controller-app LP_CC2652R7 (read only) 653347 653443 96 0.0
(read/write) 190388 190292 -96 -0.1
.bss 73004 73004 0 0.0
.data 3232 3232 0 0.0
.rodata 83451 83451 0 0.0
.text 569416 569512 96 0.0
shell LP_CC2652R7 (read only) 683614 683710 96 0.0
(read/write) 163768 163672 -96 -0.1
.bss 77164 77164 0 0.0
.data 3416 3416 0 0.0
.rodata 100638 100638 0 0.0
.text 582492 582588 96 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 624498 624594 96 0.0
.app_xip_area 528112 528208 96 0.0
.bss 79028 79028 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 627558 627646 88 0.0
.app_xip_area 532628 532716 88 0.0
.bss 77604 77604 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 572202 572298 96 0.0
.app_xip_area 467556 467652 96 0.0
.bss 87024 87024 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 914812 915036 224 0.0
(read/write) 133236 133236 0 0.0
.bss 131176 131176 0 0.0
.data 2060 2060 0 0.0
.text 914804 915028 224 0.0
BRD4161A+rpc (read only) 948984 949224 240 0.0
(read/write) 149920 149920 0 0.0
.bss 147656 147656 0 0.0
.data 2264 2264 0 0.0
.text 948976 949216 240 0.0
BRD4161A+rs911x (read only) 784128 784352 224 0.0
(read/write) 128460 128460 0 0.0
.bss 126388 126388 0 0.0
.data 2068 2068 0 0.0
.text 784120 784344 224 0.0
lock-app BRD4161A+wf200 (read only) 944940 945036 96 0.0
(read/write) 122940 122940 0 0.0
.bss 120916 120916 0 0.0
.data 2024 2024 0 0.0
.text 944932 945028 96 0.0
window-app BRD4161A (read only) 894932 895156 224 0.0
(read/write) 133296 133296 0 0.0
.bss 131248 131248 0 0.0
.data 2048 2048 0 0.0
.text 894924 895148 224 0.0
esp32 all-clusters-app c3devkit (read only) 996618 996758 140 0.0
(read/write) 1476314 1476314 0 0.0
.dram0.bss 67152 67152 0 0.0
.dram0.data 14568 14568 0 0.0
.flash.rodata 209160 209160 0 0.0
.flash.text 996618 996758 140 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1052095 1052239 144 0.0
(read/write) 478344 478344 0 0.0
.dram0.bss 72672 72672 0 0.0
.dram0.data 34184 34184 0 0.0
.flash.rodata 239492 239492 0 0.0
.flash.text 1046711 1046855 144 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 682388 682484 96 0.0
.bss 80216 80216 0 0.0
.data 2016 2016 0 0.0
.text 598452 598548 96 0.0
lock k32w061+release (read/write) 728760 728840 80 0.0
.bss 80648 80648 0 0.0
.data 1976 1976 0 0.0
.text 644432 644512 80 0.0
linux all-clusters-app debug (read only) 2732609 2733057 448 0.0
(read/write) 174456 174584 128 0.1
.bss 83808 83936 128 0.2
.data 2064 2064 0 0.0
.data.rel.ro 82456 82456 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1008 1008 0 0.0
.rodata 237949 237949 0 0.0
.text 2318786 2319234 448 0.0
bridge-app debug+rpc (read only) 2020825 2021273 448 0.0
(read/write) 146424 146584 160 0.1
.bss 71616 71776 160 0.2
.data 3936 3936 0 0.0
.data.rel.ro 65288 65288 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 167337 167337 0 0.0
.text 1695506 1695954 448 0.0
chip-tool debug (read only) 9235973 9236581 608 0.0
(read/write) 577008 577008 0 0.0
.bss 22816 22816 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 546752 546752 0 0.0
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 477429 477429 0 0.0
.text 7434085 7434693 608 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9015044 9015556 512 0.0
(read/write) 643121 643121 0 0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 582008 582008 0 0.0
.dynamic 560 560 0 0.0
.got 14976 14976 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 443540 443540 0 0.0
.text 7111972 7112484 512 0.0
lighting-app debug+rpc (read only) 2314441 2314889 448 0.0
(read/write) 151904 152064 160 0.1
.bss 73440 73600 160 0.2
.data 2048 2048 0 0.0
.data.rel.ro 70664 70664 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 186249 186249 0 0.0
.text 1960978 1961426 448 0.0
lock-app debug (read only) 2228377 2228825 448 0.0
(read/write) 146552 146712 160 0.1
.bss 72096 72256 160 0.2
.data 1568 1568 0 0.0
.data.rel.ro 67192 67192 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 196985 196985 0 0.0
.text 1870498 1870946 448 0.0
ota-provider-app debug (read only) 2049329 2049777 448 0.0
(read/write) 139632 139760 128 0.1
.bss 71584 71712 128 0.2
.data 1768 1768 0 0.0
.data.rel.ro 60488 60488 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 177235 177235 0 0.0
.text 1713698 1714146 448 0.0
ota-requestor-app debug (read only) 2078625 2079073 448 0.0
(read/write) 142440 142600 160 0.1
.bss 72224 72384 160 0.2
.data 1992 1992 0 0.0
.data.rel.ro 62584 62584 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 173404 173404 0 0.0
.text 1745362 1745810 448 0.0
shell debug (read only) 2548985 2549433 448 0.0
(read/write) 198256 198512 256 0.1
.bss 114408 114664 256 0.2
.data 1376 1376 0 0.0
.data.rel.ro 76744 76744 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 219122 219122 0 0.0
.text 2167378 2167826 448 0.0
thermostat-no-ble arm64 (read only) 2343092 2343492 400 0.0
(read/write) 175009 175153 144 0.1
.bss 86353 86497 144 0.2
.data 1520 1520 0 0.0
.data.rel.ro 79336 79336 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146980 146980 0 0.0
.text 1966288 1966688 400 0.0
tv-app debug (read only) 2840129 2840737 608 0.0
(read/write) 277408 277536 128 0.0
.bss 189528 189656 128 0.1
.data 4672 4672 0 0.0
.data.rel.ro 76960 76960 0 0.0
.dynamic 592 592 0 0.0
.got 4720 4720 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 219281 219281 0 0.0
.text 2437570 2438178 608 0.0
tv-casting-app debug (read only) 5402873 5403321 448 0.0
(read/write) 223680 223808 128 0.1
.bss 77144 77272 128 0.2
.data 2368 2368 0 0.0
.data.rel.ro 137952 137952 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 337857 337857 0 0.0
.text 4704706 4705154 448 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2418600 2418664 64 0.0
.bss 201596 201596 0 0.0
.data 5872 5872 0 0.0
.text 1381244 1381308 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176903 1176999 96 0.0
bss 138368 138368 0 0.0
rodata 152256 152256 0 0.0
text 807524 807620 96 0.0
p6 all-clusters-app default (read/write) 2529552 2529776 224 0.0
.bss 135104 135104 0 0.0
.data 2808 2808 0 0.0
.text 1487816 1488040 224 0.0
light-app default (read/write) 2418488 2418712 224 0.0
.bss 128432 128432 0 0.0
.data 2608 2608 0 0.0
.text 1376752 1376976 224 0.0
lock-app default (read/write) 2429136 2429360 224 0.0
.bss 128248 128248 0 0.0
.data 2568 2568 0 0.0
.text 1387400 1387624 224 0.0
telink light-switch-app tlsr9518adk80d (read/write) 781904 782016 112 0.0
bss 70608 70608 0 0.0
noinit 40416 40416 0 0.0
text 552922 553038 116 0.0
lighting-app tlsr9518adk80d (read/write) 801988 802108 120 0.0
bss 70864 70864 0 0.0
noinit 40416 40416 0 0.0
text 569688 569804 116 0.0

@restyled-io restyled-io bot mentioned this pull request May 16, 2022
Closed
@bzbarsky-apple bzbarsky-apple mentioned this pull request May 16, 2022
Closed
@github-actions
Copy link

github-actions bot commented May 16, 2022 •
edited
Loading

PR #18482: Size comparison from ed43d59 to 585f422

Increases above 0.2%:

platform target config section ed43d59 585f422 change % change
linux bridge-app debug+rpc .bss 71616 71776 160 0.2
chip-tool debug (read only) 9235973 9267845 31872 0.3
.rodata 477429 478485 1056 0.2
.text 7434085 7462741 28656 0.4
chip-tool-no-interactive-ipv6only arm64 (read only) 9015044 9044660 29616 0.3
.text 7111972 7138388 26416 0.4
lock-app debug .bss 72096 72256 160 0.2
ota-requestor-app debug .bss 72224 72384 160 0.2
shell debug .bss 114408 114664 256 0.2
Increases (36 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section ed43d59 585f422 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689259 689291 32 0.0
.text 585688 585720 32 0.0
lock-ftd LP_CC2652R7 (read only) 676603 676635 32 0.0
.text 581308 581340 32 0.0
lock-mtd LP_CC2652R7 (read only) 625419 625459 40 0.0
.text 530236 530276 40 0.0
pump-app LP_CC2652R7 (read only) 660175 660207 32 0.0
.text 579344 579376 32 0.0
pump-controller-app LP_CC2652R7 (read only) 653347 653379 32 0.0
.text 569416 569448 32 0.0
shell LP_CC2652R7 (read only) 683614 683646 32 0.0
.text 582492 582524 32 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 624498 624530 32 0.0
.app_xip_area 528112 528144 32 0.0
lock cyw930739m2evb_01 (read/write) 627558 627590 32 0.0
.app_xip_area 532628 532660 32 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 572202 572234 32 0.0
.app_xip_area 467556 467588 32 0.0
efr32 lighting-app BRD4161A (read only) 914812 914940 128 0.0
.text 914804 914932 128 0.0
BRD4161A+rpc (read only) 948984 949128 144 0.0
.text 948976 949120 144 0.0
BRD4161A+rs911x (read only) 784128 784256 128 0.0
.text 784120 784248 128 0.0
lock-app BRD4161A+wf200 (read only) 944940 944988 48 0.0
.text 944932 944980 48 0.0
window-app BRD4161A (read only) 894932 895044 112 0.0
.text 894924 895036 112 0.0
esp32 all-clusters-app c3devkit (read only) 996618 996694 76 0.0
.flash.text 996618 996694 76 0.0
m5stack (read only) 1052095 1052147 52 0.0
.flash.text 1046711 1046763 52 0.0
k32w light k32w061+release (read/write) 682388 682420 32 0.0
.text 598452 598484 32 0.0
lock k32w061+release (read/write) 728760 728792 32 0.0
.text 644432 644464 32 0.0
linux all-clusters-app debug (read only) 2732609 2732785 176 0.0
(read/write) 174456 174584 128 0.1
.bss 83808 83936 128 0.2
.text 2318786 2318962 176 0.0
bridge-app debug+rpc (read only) 2020825 2020985 160 0.0
(read/write) 146424 146584 160 0.1
.bss 71616 71776 160 0.2
.text 1695506 1695666 160 0.0
chip-tool debug (read only) 9235973 9267845 31872 0.3
(read/write) 577008 577936 928 0.2
.data.rel.ro 546752 547680 928 0.2
.rodata 477429 478485 1056 0.2
.text 7434085 7462741 28656 0.4
chip-tool-no-interactive-ipv6only arm64 (read only) 9015044 9044660 29616 0.3
(read/write) 643121 644065 944 0.1
.data.rel.ro 582008 582936 928 0.2
.got 14976 14984 8 0.1
.rodata 443540 444564 1024 0.2
.text 7111972 7138388 26416 0.4
lighting-app debug+rpc (read only) 2314441 2314809 368 0.0
(read/write) 151904 152032 128 0.1
.bss 73440 73568 128 0.2
.rodata 186249 186409 160 0.1
.text 1960978 1961186 208 0.0
lock-app debug (read only) 2228377 2228553 176 0.0
(read/write) 146552 146712 160 0.1
.bss 72096 72256 160 0.2
.text 1870498 1870674 176 0.0
ota-provider-app debug (read only) 2049329 2049505 176 0.0
(read/write) 139632 139760 128 0.1
.bss 71584 71712 128 0.2
.text 1713698 1713874 176 0.0
ota-requestor-app debug (read only) 2078625 2078801 176 0.0
(read/write) 142440 142600 160 0.1
.bss 72224 72384 160 0.2
.text 1745362 1745538 176 0.0
shell debug (read only) 2548985 2549145 160 0.0
(read/write) 198256 198512 256 0.1
.bss 114408 114664 256 0.2
.text 2167378 2167538 160 0.0
thermostat-no-ble arm64 (read only) 2343092 2343316 224 0.0
(read/write) 175009 175153 144 0.1
.bss 86353 86497 144 0.2
.text 1966288 1966512 224 0.0
tv-app debug (read only) 2840129 2840465 336 0.0
(read/write) 277408 277536 128 0.0
.bss 189528 189656 128 0.1
.text 2437570 2437906 336 0.0
tv-casting-app debug (read only) 5402873 5403049 176 0.0
(read/write) 223680 223808 128 0.1
.bss 77144 77272 128 0.2
.text 4704706 4704882 176 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176903 1176935 32 0.0
text 807524 807556 32 0.0
p6 all-clusters-app default (read/write) 2529552 2529696 144 0.0
.text 1487816 1487960 144 0.0
light-app default (read/write) 2418488 2418616 128 0.0
.text 1376752 1376880 128 0.0
lock-app default (read/write) 2429136 2429280 144 0.0
.text 1387400 1387544 144 0.0
telink light-switch-app tlsr9518adk80d (read/write) 781904 781944 40 0.0
text 552922 552968 46 0.0
lighting-app tlsr9518adk80d (read/write) 801988 802036 48 0.0
text 569688 569734 46 0.0
Decreases (5 builds for cc13x2_26x2)
platform target config section ed43d59 585f422 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 162300 162268 -32 -0.0
lock-ftd LP_CC2652R7 (read/write) 166044 166012 -32 -0.0
pump-app LP_CC2652R7 (read/write) 183760 183728 -32 -0.0
pump-controller-app LP_CC2652R7 (read/write) 190388 190356 -32 -0.0
shell LP_CC2652R7 (read/write) 163768 163736 -32 -0.0
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section ed43d59 585f422 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689259 689291 32 0.0
(read/write) 162300 162268 -32 -0.0
.bss 74540 74540 0 0.0
.data 3412 3412 0 0.0
.rodata 103091 103091 0 0.0
.text 585688 585720 32 0.0
lock-ftd LP_CC2652R7 (read only) 676603 676635 32 0.0
(read/write) 166044 166012 -32 -0.0
.bss 72684 72684 0 0.0
.data 3236 3236 0 0.0
.rodata 94811 94811 0 0.0
.text 581308 581340 32 0.0
lock-mtd LP_CC2652R7 (read only) 625419 625459 40 0.0
(read/write) 145516 145516 0 0.0
.bss 68420 68420 0 0.0
.data 3236 3236 0 0.0
.rodata 94691 94691 0 0.0
.text 530236 530276 40 0.0
pump-app LP_CC2652R7 (read only) 660175 660207 32 0.0
(read/write) 183760 183728 -32 -0.0
.bss 72948 72948 0 0.0
.data 3268 3268 0 0.0
.rodata 80351 80351 0 0.0
.text 579344 579376 32 0.0
pump-controller-app LP_CC2652R7 (read only) 653347 653379 32 0.0
(read/write) 190388 190356 -32 -0.0
.bss 73004 73004 0 0.0
.data 3232 3232 0 0.0
.rodata 83451 83451 0 0.0
.text 569416 569448 32 0.0
shell LP_CC2652R7 (read only) 683614 683646 32 0.0
(read/write) 163768 163736 -32 -0.0
.bss 77164 77164 0 0.0
.data 3416 3416 0 0.0
.rodata 100638 100638 0 0.0
.text 582492 582524 32 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 624498 624530 32 0.0
.app_xip_area 528112 528144 32 0.0
.bss 79028 79028 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 627558 627590 32 0.0
.app_xip_area 532628 532660 32 0.0
.bss 77604 77604 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 572202 572234 32 0.0
.app_xip_area 467556 467588 32 0.0
.bss 87024 87024 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 914812 914940 128 0.0
(read/write) 133236 133236 0 0.0
.bss 131176 131176 0 0.0
.data 2060 2060 0 0.0
.text 914804 914932 128 0.0
BRD4161A+rpc (read only) 948984 949128 144 0.0
(read/write) 149920 149920 0 0.0
.bss 147656 147656 0 0.0
.data 2264 2264 0 0.0
.text 948976 949120 144 0.0
BRD4161A+rs911x (read only) 784128 784256 128 0.0
(read/write) 128460 128460 0 0.0
.bss 126388 126388 0 0.0
.data 2068 2068 0 0.0
.text 784120 784248 128 0.0
lock-app BRD4161A+wf200 (read only) 944940 944988 48 0.0
(read/write) 122940 122940 0 0.0
.bss 120916 120916 0 0.0
.data 2024 2024 0 0.0
.text 944932 944980 48 0.0
window-app BRD4161A (read only) 894932 895044 112 0.0
(read/write) 133296 133296 0 0.0
.bss 131248 131248 0 0.0
.data 2048 2048 0 0.0
.text 894924 895036 112 0.0
esp32 all-clusters-app c3devkit (read only) 996618 996694 76 0.0
(read/write) 1476314 1476314 0 0.0
.dram0.bss 67152 67152 0 0.0
.dram0.data 14568 14568 0 0.0
.flash.rodata 209160 209160 0 0.0
.flash.text 996618 996694 76 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1052095 1052147 52 0.0
(read/write) 478344 478344 0 0.0
.dram0.bss 72672 72672 0 0.0
.dram0.data 34184 34184 0 0.0
.flash.rodata 239492 239492 0 0.0
.flash.text 1046711 1046763 52 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 682388 682420 32 0.0
.bss 80216 80216 0 0.0
.data 2016 2016 0 0.0
.text 598452 598484 32 0.0
lock k32w061+release (read/write) 728760 728792 32 0.0
.bss 80648 80648 0 0.0
.data 1976 1976 0 0.0
.text 644432 644464 32 0.0
linux all-clusters-app debug (read only) 2732609 2732785 176 0.0
(read/write) 174456 174584 128 0.1
.bss 83808 83936 128 0.2
.data 2064 2064 0 0.0
.data.rel.ro 82456 82456 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1008 1008 0 0.0
.rodata 237949 237949 0 0.0
.text 2318786 2318962 176 0.0
bridge-app debug+rpc (read only) 2020825 2020985 160 0.0
(read/write) 146424 146584 160 0.1
.bss 71616 71776 160 0.2
.data 3936 3936 0 0.0
.data.rel.ro 65288 65288 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 167337 167337 0 0.0
.text 1695506 1695666 160 0.0
chip-tool debug (read only) 9235973 9267845 31872 0.3
(read/write) 577008 577936 928 0.2
.bss 22816 22816 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 546752 547680 928 0.2
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 477429 478485 1056 0.2
.text 7434085 7462741 28656 0.4
chip-tool-no-interactive-ipv6only arm64 (read only) 9015044 9044660 29616 0.3
(read/write) 643121 644065 944 0.1
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 582008 582936 928 0.2
.dynamic 560 560 0 0.0
.got 14976 14984 8 0.1
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 443540 444564 1024 0.2
.text 7111972 7138388 26416 0.4
lighting-app debug+rpc (read only) 2314441 2314809 368 0.0
(read/write) 151904 152032 128 0.1
.bss 73440 73568 128 0.2
.data 2048 2048 0 0.0
.data.rel.ro 70664 70664 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 186249 186409 160 0.1
.text 1960978 1961186 208 0.0
lock-app debug (read only) 2228377 2228553 176 0.0
(read/write) 146552 146712 160 0.1
.bss 72096 72256 160 0.2
.data 1568 1568 0 0.0
.data.rel.ro 67192 67192 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 196985 196985 0 0.0
.text 1870498 1870674 176 0.0
ota-provider-app debug (read only) 2049329 2049505 176 0.0
(read/write) 139632 139760 128 0.1
.bss 71584 71712 128 0.2
.data 1768 1768 0 0.0
.data.rel.ro 60488 60488 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 177235 177235 0 0.0
.text 1713698 1713874 176 0.0
ota-requestor-app debug (read only) 2078625 2078801 176 0.0
(read/write) 142440 142600 160 0.1
.bss 72224 72384 160 0.2
.data 1992 1992 0 0.0
.data.rel.ro 62584 62584 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 173404 173404 0 0.0
.text 1745362 1745538 176 0.0
shell debug (read only) 2548985 2549145 160 0.0
(read/write) 198256 198512 256 0.1
.bss 114408 114664 256 0.2
.data 1376 1376 0 0.0
.data.rel.ro 76744 76744 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 219122 219122 0 0.0
.text 2167378 2167538 160 0.0
thermostat-no-ble arm64 (read only) 2343092 2343316 224 0.0
(read/write) 175009 175153 144 0.1
.bss 86353 86497 144 0.2
.data 1520 1520 0 0.0
.data.rel.ro 79336 79336 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146980 146980 0 0.0
.text 1966288 1966512 224 0.0
tv-app debug (read only) 2840129 2840465 336 0.0
(read/write) 277408 277536 128 0.0
.bss 189528 189656 128 0.1
.data 4672 4672 0 0.0
.data.rel.ro 76960 76960 0 0.0
.dynamic 592 592 0 0.0
.got 4720 4720 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 219281 219281 0 0.0
.text 2437570 2437906 336 0.0
tv-casting-app debug (read only) 5402873 5403049 176 0.0
(read/write) 223680 223808 128 0.1
.bss 77144 77272 128 0.2
.data 2368 2368 0 0.0
.data.rel.ro 137952 137952 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 337857 337857 0 0.0
.text 4704706 4704882 176 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2418600 2418600 0 0.0
.bss 201596 201596 0 0.0
.data 5872 5872 0 0.0
.text 1381244 1381244 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176903 1176935 32 0.0
bss 138368 138368 0 0.0
rodata 152256 152256 0 0.0
text 807524 807556 32 0.0
p6 all-clusters-app default (read/write) 2529552 2529696 144 0.0
.bss 135104 135104 0 0.0
.data 2808 2808 0 0.0
.text 1487816 1487960 144 0.0
light-app default (read/write) 2418488 2418616 128 0.0
.bss 128432 128432 0 0.0
.data 2608 2608 0 0.0
.text 1376752 1376880 128 0.0
lock-app default (read/write) 2429136 2429280 144 0.0
.bss 128248 128248 0 0.0
.data 2568 2568 0 0.0
.text 1387400 1387544 144 0.0
telink light-switch-app tlsr9518adk80d (read/write) 781904 781944 40 0.0
bss 70608 70608 0 0.0
noinit 40416 40416 0 0.0
text 552922 552968 46 0.0
lighting-app tlsr9518adk80d (read/write) 801988 802036 48 0.0
bss 70864 70864 0 0.0
noinit 40416 40416 0 0.0
text 569688 569734 46 0.0

bzbarsky-apple
bzbarsky-apple reviewed May 16, 2022
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to fix GetOperationalKey to not allocate mOperationalKey if it's null and mHasExternallyOwnedOperationalKey, right? Or are we OK with that just allocating a bogus key that will fail further down the line (which I think I am)?

src/credentials/FabricTable.cpp Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented May 16, 2022 •
edited
Loading

PR #18482: Size comparison from ed43d59 to 3920bea

Increases above 0.2%:

platform target config section ed43d59 3920bea change % change
linux bridge-app debug+rpc .bss 71616 71776 160 0.2
chip-tool debug (read only) 9235973 9267861 31888 0.3
.rodata 477429 478485 1056 0.2
.text 7434085 7462757 28672 0.4
chip-tool-no-interactive-ipv6only arm64 (read only) 9015044 9044676 29632 0.3
.text 7111972 7138404 26432 0.4
lock-app debug .bss 72096 72256 160 0.2
ota-requestor-app debug .bss 72224 72384 160 0.2
shell debug .bss 114408 114664 256 0.2
Increases (34 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, nrfconnect, p6, telink)
platform target config section ed43d59 3920bea change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689259 689291 32 0.0
.text 585688 585720 32 0.0
lock-ftd LP_CC2652R7 (read only) 676603 676651 48 0.0
.text 581308 581356 48 0.0
lock-mtd LP_CC2652R7 (read only) 625419 625475 56 0.0
.text 530236 530292 56 0.0
pump-app LP_CC2652R7 (read only) 660175 660223 48 0.0
.text 579344 579392 48 0.0
pump-controller-app LP_CC2652R7 (read only) 653347 653379 32 0.0
.text 569416 569448 32 0.0
shell LP_CC2652R7 (read only) 683614 683646 32 0.0
.text 582492 582524 32 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 624498 624538 40 0.0
.app_xip_area 528112 528152 40 0.0
lock cyw930739m2evb_01 (read/write) 627558 627598 40 0.0
.app_xip_area 532628 532668 40 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 572202 572242 40 0.0
.app_xip_area 467556 467596 40 0.0
efr32 lighting-app BRD4161A (read only) 914812 914956 144 0.0
.text 914804 914948 144 0.0
BRD4161A+rpc (read only) 948984 949192 208 0.0
.text 948976 949184 208 0.0
BRD4161A+rs911x (read only) 784128 784288 160 0.0
.text 784120 784280 160 0.0
lock-app BRD4161A+wf200 (read only) 944940 944988 48 0.0
.text 944932 944980 48 0.0
window-app BRD4161A (read only) 894932 895076 144 0.0
.text 894924 895068 144 0.0
k32w light k32w061+release (read/write) 682388 682436 48 0.0
.text 598452 598500 48 0.0
lock k32w061+release (read/write) 728760 728792 32 0.0
.text 644432 644464 32 0.0
linux all-clusters-app debug (read only) 2732609 2732801 192 0.0
(read/write) 174456 174584 128 0.1
.bss 83808 83936 128 0.2
.text 2318786 2318978 192 0.0
bridge-app debug+rpc (read only) 2020825 2021001 176 0.0
(read/write) 146424 146584 160 0.1
.bss 71616 71776 160 0.2
.text 1695506 1695682 176 0.0
chip-tool debug (read only) 9235973 9267861 31888 0.3
(read/write) 577008 577936 928 0.2
.data.rel.ro 546752 547680 928 0.2
.rodata 477429 478485 1056 0.2
.text 7434085 7462757 28672 0.4
chip-tool-no-interactive-ipv6only arm64 (read only) 9015044 9044676 29632 0.3
(read/write) 643121 644065 944 0.1
.data.rel.ro 582008 582936 928 0.2
.got 14976 14984 8 0.1
.rodata 443540 444564 1024 0.2
.text 7111972 7138404 26432 0.4
lighting-app debug+rpc (read only) 2314441 2314825 384 0.0
(read/write) 151904 152032 128 0.1
.bss 73440 73568 128 0.2
.rodata 186249 186409 160 0.1
.text 1960978 1961202 224 0.0
lock-app debug (read only) 2228377 2228569 192 0.0
(read/write) 146552 146712 160 0.1
.bss 72096 72256 160 0.2
.text 1870498 1870690 192 0.0
ota-provider-app debug (read only) 2049329 2049521 192 0.0
(read/write) 139632 139760 128 0.1
.bss 71584 71712 128 0.2
.text 1713698 1713890 192 0.0
ota-requestor-app debug (read only) 2078625 2078817 192 0.0
(read/write) 142440 142600 160 0.1
.bss 72224 72384 160 0.2
.text 1745362 1745554 192 0.0
shell debug (read only) 2548985 2549161 176 0.0
(read/write) 198256 198512 256 0.1
.bss 114408 114664 256 0.2
.text 2167378 2167554 176 0.0
thermostat-no-ble arm64 (read only) 2343092 2343332 240 0.0
(read/write) 175009 175153 144 0.1
.bss 86353 86497 144 0.2
.text 1966288 1966528 240 0.0
tv-app debug (read only) 2840129 2840481 352 0.0
(read/write) 277408 277536 128 0.0
.bss 189528 189656 128 0.1
.text 2437570 2437922 352 0.0
tv-casting-app debug (read only) 5402873 5403065 192 0.0
(read/write) 223680 223808 128 0.1
.bss 77144 77272 128 0.2
.text 4704706 4704898 192 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176903 1176935 32 0.0
text 807524 807564 40 0.0
p6 all-clusters-app default (read/write) 2529552 2529728 176 0.0
.text 1487816 1487992 176 0.0
light-app default (read/write) 2418488 2418648 160 0.0
.text 1376752 1376912 160 0.0
lock-app default (read/write) 2429136 2429312 176 0.0
.text 1387400 1387576 176 0.0
telink light-switch-app tlsr9518adk80d (read/write) 781904 781952 48 0.0
text 552922 552974 52 0.0
lighting-app tlsr9518adk80d (read/write) 801988 802044 56 0.0
text 569688 569740 52 0.0
Decreases (7 builds for cc13x2_26x2, esp32)
platform target config section ed43d59 3920bea change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 162300 162268 -32 -0.0
lock-ftd LP_CC2652R7 (read/write) 166044 165996 -48 -0.0
pump-app LP_CC2652R7 (read/write) 183760 183712 -48 -0.0
pump-controller-app LP_CC2652R7 (read/write) 190388 190356 -32 -0.0
shell LP_CC2652R7 (read/write) 163768 163736 -32 -0.0
esp32 all-clusters-app c3devkit (read only) 996618 996570 -48 -0.0
.flash.text 996618 996570 -48 -0.0
m5stack (read only) 1052095 1052055 -40 -0.0
.flash.text 1046711 1046671 -40 -0.0
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section ed43d59 3920bea change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689259 689291 32 0.0
(read/write) 162300 162268 -32 -0.0
.bss 74540 74540 0 0.0
.data 3412 3412 0 0.0
.rodata 103091 103091 0 0.0
.text 585688 585720 32 0.0
lock-ftd LP_CC2652R7 (read only) 676603 676651 48 0.0
(read/write) 166044 165996 -48 -0.0
.bss 72684 72684 0 0.0
.data 3236 3236 0 0.0
.rodata 94811 94811 0 0.0
.text 581308 581356 48 0.0
lock-mtd LP_CC2652R7 (read only) 625419 625475 56 0.0
(read/write) 145516 145516 0 0.0
.bss 68420 68420 0 0.0
.data 3236 3236 0 0.0
.rodata 94691 94691 0 0.0
.text 530236 530292 56 0.0
pump-app LP_CC2652R7 (read only) 660175 660223 48 0.0
(read/write) 183760 183712 -48 -0.0
.bss 72948 72948 0 0.0
.data 3268 3268 0 0.0
.rodata 80351 80351 0 0.0
.text 579344 579392 48 0.0
pump-controller-app LP_CC2652R7 (read only) 653347 653379 32 0.0
(read/write) 190388 190356 -32 -0.0
.bss 73004 73004 0 0.0
.data 3232 3232 0 0.0
.rodata 83451 83451 0 0.0
.text 569416 569448 32 0.0
shell LP_CC2652R7 (read only) 683614 683646 32 0.0
(read/write) 163768 163736 -32 -0.0
.bss 77164 77164 0 0.0
.data 3416 3416 0 0.0
.rodata 100638 100638 0 0.0
.text 582492 582524 32 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 624498 624538 40 0.0
.app_xip_area 528112 528152 40 0.0
.bss 79028 79028 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 627558 627598 40 0.0
.app_xip_area 532628 532668 40 0.0
.bss 77604 77604 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 572202 572242 40 0.0
.app_xip_area 467556 467596 40 0.0
.bss 87024 87024 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 914812 914956 144 0.0
(read/write) 133236 133236 0 0.0
.bss 131176 131176 0 0.0
.data 2060 2060 0 0.0
.text 914804 914948 144 0.0
BRD4161A+rpc (read only) 948984 949192 208 0.0
(read/write) 149920 149920 0 0.0
.bss 147656 147656 0 0.0
.data 2264 2264 0 0.0
.text 948976 949184 208 0.0
BRD4161A+rs911x (read only) 784128 784288 160 0.0
(read/write) 128460 128460 0 0.0
.bss 126388 126388 0 0.0
.data 2068 2068 0 0.0
.text 784120 784280 160 0.0
lock-app BRD4161A+wf200 (read only) 944940 944988 48 0.0
(read/write) 122940 122940 0 0.0
.bss 120916 120916 0 0.0
.data 2024 2024 0 0.0
.text 944932 944980 48 0.0
window-app BRD4161A (read only) 894932 895076 144 0.0
(read/write) 133296 133296 0 0.0
.bss 131248 131248 0 0.0
.data 2048 2048 0 0.0
.text 894924 895068 144 0.0
esp32 all-clusters-app c3devkit (read only) 996618 996570 -48 -0.0
(read/write) 1476314 1476314 0 0.0
.dram0.bss 67152 67152 0 0.0
.dram0.data 14568 14568 0 0.0
.flash.rodata 209160 209160 0 0.0
.flash.text 996618 996570 -48 -0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1052095 1052055 -40 -0.0
(read/write) 478344 478344 0 0.0
.dram0.bss 72672 72672 0 0.0
.dram0.data 34184 34184 0 0.0
.flash.rodata 239492 239492 0 0.0
.flash.text 1046711 1046671 -40 -0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 682388 682436 48 0.0
.bss 80216 80216 0 0.0
.data 2016 2016 0 0.0
.text 598452 598500 48 0.0
lock k32w061+release (read/write) 728760 728792 32 0.0
.bss 80648 80648 0 0.0
.data 1976 1976 0 0.0
.text 644432 644464 32 0.0
linux all-clusters-app debug (read only) 2732609 2732801 192 0.0
(read/write) 174456 174584 128 0.1
.bss 83808 83936 128 0.2
.data 2064 2064 0 0.0
.data.rel.ro 82456 82456 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1008 1008 0 0.0
.rodata 237949 237949 0 0.0
.text 2318786 2318978 192 0.0
bridge-app debug+rpc (read only) 2020825 2021001 176 0.0
(read/write) 146424 146584 160 0.1
.bss 71616 71776 160 0.2
.data 3936 3936 0 0.0
.data.rel.ro 65288 65288 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 167337 167337 0 0.0
.text 1695506 1695682 176 0.0
chip-tool debug (read only) 9235973 9267861 31888 0.3
(read/write) 577008 577936 928 0.2
.bss 22816 22816 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 546752 547680 928 0.2
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 477429 478485 1056 0.2
.text 7434085 7462757 28672 0.4
chip-tool-no-interactive-ipv6only arm64 (read only) 9015044 9044676 29632 0.3
(read/write) 643121 644065 944 0.1
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 582008 582936 928 0.2
.dynamic 560 560 0 0.0
.got 14976 14984 8 0.1
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 443540 444564 1024 0.2
.text 7111972 7138404 26432 0.4
lighting-app debug+rpc (read only) 2314441 2314825 384 0.0
(read/write) 151904 152032 128 0.1
.bss 73440 73568 128 0.2
.data 2048 2048 0 0.0
.data.rel.ro 70664 70664 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 186249 186409 160 0.1
.text 1960978 1961202 224 0.0
lock-app debug (read only) 2228377 2228569 192 0.0
(read/write) 146552 146712 160 0.1
.bss 72096 72256 160 0.2
.data 1568 1568 0 0.0
.data.rel.ro 67192 67192 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 196985 196985 0 0.0
.text 1870498 1870690 192 0.0
ota-provider-app debug (read only) 2049329 2049521 192 0.0
(read/write) 139632 139760 128 0.1
.bss 71584 71712 128 0.2
.data 1768 1768 0 0.0
.data.rel.ro 60488 60488 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 177235 177235 0 0.0
.text 1713698 1713890 192 0.0
ota-requestor-app debug (read only) 2078625 2078817 192 0.0
(read/write) 142440 142600 160 0.1
.bss 72224 72384 160 0.2
.data 1992 1992 0 0.0
.data.rel.ro 62584 62584 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 173404 173404 0 0.0
.text 1745362 1745554 192 0.0
shell debug (read only) 2548985 2549161 176 0.0
(read/write) 198256 198512 256 0.1
.bss 114408 114664 256 0.2
.data 1376 1376 0 0.0
.data.rel.ro 76744 76744 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 219122 219122 0 0.0
.text 2167378 2167554 176 0.0
thermostat-no-ble arm64 (read only) 2343092 2343332 240 0.0
(read/write) 175009 175153 144 0.1
.bss 86353 86497 144 0.2
.data 1520 1520 0 0.0
.data.rel.ro 79336 79336 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146980 146980 0 0.0
.text 1966288 1966528 240 0.0
tv-app debug (read only) 2840129 2840481 352 0.0
(read/write) 277408 277536 128 0.0
.bss 189528 189656 128 0.1
.data 4672 4672 0 0.0
.data.rel.ro 76960 76960 0 0.0
.dynamic 592 592 0 0.0
.got 4720 4720 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 219281 219281 0 0.0
.text 2437570 2437922 352 0.0
tv-casting-app debug (read only) 5402873 5403065 192 0.0
(read/write) 223680 223808 128 0.1
.bss 77144 77272 128 0.2
.data 2368 2368 0 0.0
.data.rel.ro 137952 137952 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 337857 337857 0 0.0
.text 4704706 4704898 192 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2418600 2418600 0 0.0
.bss 201596 201596 0 0.0
.data 5872 5872 0 0.0
.text 1381244 1381244 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176903 1176935 32 0.0
bss 138368 138368 0 0.0
rodata 152256 152256 0 0.0
text 807524 807564 40 0.0
p6 all-clusters-app default (read/write) 2529552 2529728 176 0.0
.bss 135104 135104 0 0.0
.data 2808 2808 0 0.0
.text 1487816 1487992 176 0.0
light-app default (read/write) 2418488 2418648 160 0.0
.bss 128432 128432 0 0.0
.data 2608 2608 0 0.0
.text 1376752 1376912 160 0.0
lock-app default (read/write) 2429136 2429312 176 0.0
.bss 128248 128248 0 0.0
.data 2568 2568 0 0.0
.text 1387400 1387576 176 0.0
telink light-switch-app tlsr9518adk80d (read/write) 781904 781952 48 0.0
bss 70608 70608 0 0.0
noinit 40416 40416 0 0.0
text 552922 552974 52 0.0
lighting-app tlsr9518adk80d (read/write) 801988 802044 56 0.0
bss 70864 70864 0 0.0
noinit 40416 40416 0 0.0
text 569688 569740 52 0.0

@tcarmelveilleux tcarmelveilleux merged commit 51cbb53 into project-chip:master May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@msandstedt msandstedt Awaiting requested review from msandstedt

Assignees
No one assigned
Labels
controller review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tcarmelveilleux @msandstedt @mrjerryjohns @bzbarsky-apple @restyled-commits