Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Device to Get PASE Verifier from Memory. Resolves #7738 #14676

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Updated Device to Get PASE Verifier from Memory. Resolves #7738 #14676

merged 1 commit into from
Feb 10, 2022

Conversation

emargolis
Copy link
Contributor

Problem

Device shouldn't calculate Spake2p Verifier parameter.

Ticket: #7738

Change overview

Also removed one version of the PASESession::WaitForPairing() API, which
gets PIN Code as an input. Left only one version, which gets Verifier as
an input.

Testing

All currently implemented tests.

@github-actions
Copy link

github-actions bot commented Feb 8, 2022 •
edited
Loading

PR #14676: Size comparison from b5dae1e to fbeccc1

Increases (35 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b5dae1e fbeccc1 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 595370 595378 8 0.0
.app_xip_area 500904 500912 8 0.0
lock cyw930739m2evb_01 .app_xip_area 460356 460364 8 0.0
ota-requestor cyw930739m2evb_01 .app_xip_area 475060 475068 8 0.0
efr32 lighting-app BRD4161A (read only) 866548 866564 16 0.0
.text 866540 866556 16 0.0
BRD4161A+rpc (read only) 853996 854012 16 0.0
.text 853988 854004 16 0.0
window-app BRD4161A (read only) 838752 838760 8 0.0
.text 838744 838752 8 0.0
esp32 all-clusters-app c3devkit (read only) 938468 938530 62 0.0
.flash.text 938468 938530 62 0.0
m5stack (read only) 986815 986891 76 0.0
.flash.text 981431 981507 76 0.0
k32w lock k32w061+release (read/write) 681080 681092 12 0.0
.text 596396 596412 16 0.0
linux all-clusters-app debug (read only) 2329049 2329697 648 0.0
.text 1961506 1962178 672 0.0
bridge-app debug+rpc (read only) 1705733 1706381 648 0.0
.text 1448853 1449525 672 0.0
chip-tool debug (read only) 7483109 7483741 632 0.0
.text 6664085 6664773 688 0.0
chip-tool-ipv6only arm64 (read only) 7403628 7403660 32 0.0
.text 6364532 6364612 80 0.0
door-lock-app debug (read only) 1910201 1910817 616 0.0
.text 1588674 1589346 672 0.0
lighting-app debug+rpc (read only) 2005001 2005617 616 0.0
.text 1687298 1687970 672 0.0
ota-provider-app debug (read only) 1714425 1715041 616 0.0
.text 1443810 1444482 672 0.0
ota-requestor-app debug (read only) 1703065 1703713 648 0.0
.text 1441122 1441794 672 0.0
shell debug (read only) 2302537 2303153 616 0.0
.text 1940050 1940722 672 0.0
thermostat-no-ble arm64 .text 1780736 1780800 64 0.0
tv-app debug (read only) 2527129 2527745 616 0.0
.text 2157666 2158338 672 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2390216 2390264 48 0.0
.text 1352816 1352864 48 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1005407 1005415 8 0.0
text 686916 686944 28 0.0
nrf52840dk_nrf52840+rpc text 666528 666556 28 0.0
nrf52840dongle_nrf52840 (read/write) 1022211 1022227 16 0.0
text 692484 692512 28 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 912130 912138 8 0.0
text 601940 601968 28 0.0
lock-app nrf52840dk_nrf52840 text 632836 632864 28 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 845218 845234 16 0.0
text 548636 548664 28 0.0
pump-app nrf52840dk_nrf52840 (read/write) 940019 940027 8 0.0
text 635080 635108 28 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 935359 935375 16 0.0
text 631112 631140 28 0.0
p6 all-clusters-app default (read/write) 2464512 2464528 16 0.0
.text 1422776 1422792 16 0.0
light-app default (read/write) 2367968 2367976 8 0.0
.text 1326232 1326240 8 0.0
lock-app default (read/write) 2333152 2333160 8 0.0
.text 1291416 1291424 8 0.0
qpg lighting-app qpg6105+debug (read only) 586352 586360 8 0.0
(read/write) 146936 146940 4 0.0
.text 581032 581040 8 0.0
lock-app qpg6105+debug (read only) 532420 532428 8 0.0
.text 527100 527108 8 0.0
telink lighting-app tlsr9518adk80d (read/write) 866518 866530 12 0.0
text 608172 608206 34 0.0
Decreases (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg)
platform target config section b5dae1e fbeccc1 change % change
cyw30739 light cyw930739m2evb_01 .data 624 620 -4 -0.6
lock cyw930739m2evb_01 .data 588 584 -4 -0.7
ota-requestor cyw930739m2evb_01 .data 532 528 -4 -0.8
efr32 lighting-app BRD4161A (read/write) 126684 126680 -4 -0.0
.data 1924 1920 -4 -0.2
BRD4161A+rpc (read/write) 143344 143340 -4 -0.0
.data 2024 2020 -4 -0.2
window-app BRD4161A .data 1880 1876 -4 -0.2
esp32 all-clusters-app c3devkit (read/write) 1401370 1401346 -24 -0.0
.flash.rodata 198672 198648 -24 -0.0
m5stack (read/write) 466400 466384 -16 -0.0
.flash.rodata 225576 225560 -16 -0.0
k32w light k32w061+release (read/write) 679180 679176 -4 -0.0
.data 1884 1880 -4 -0.2
lock k32w061+release .data 1924 1920 -4 -0.2
linux all-clusters-app debug (read/write) 140096 140064 -32 -0.0
.data 1200 1184 -16 -1.3
chip-tool debug .data 1152 1136 -16 -1.4
.rodata 416597 416565 -32 -0.0
chip-tool-ipv6only arm64 (read/write) 302401 302385 -16 -0.0
.data 1176 1168 -8 -0.7
.got 46584 46576 -8 -0.0
door-lock-app debug .rodata 173010 172978 -32 -0.0
lighting-app debug+rpc .rodata 163057 163025 -32 -0.0
ota-provider-app debug (read/write) 81368 81336 -32 -0.0
.data 1160 1128 -32 -2.8
.rodata 151910 151878 -32 -0.0
ota-requestor-app debug (read/write) 83320 83288 -32 -0.0
.data 1128 1096 -32 -2.8
shell debug .data 800 784 -16 -2.0
.rodata 205970 205938 -32 -0.0
thermostat-no-ble arm64 (read/write) 140673 140657 -16 -0.0
.data 984 976 -8 -0.8
.got 4152 4144 -8 -0.2
.rodata 132108 132092 -16 -0.0
tv-app debug (read/write) 139832 139800 -32 -0.0
.data 3168 3136 -32 -1.0
.rodata 195756 195724 -32 -0.0
mbed lighting-app CY8CPROTO_062_4343W+release (read/write) 2349448 2349432 -16 -0.0
.data 5600 5592 -8 -0.1
.text 1312048 1312032 -16 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2313368 2313352 -16 -0.0
.data 5584 5576 -8 -0.1
.text 1275968 1275952 -16 -0.0
shell CY8CPROTO_062_4343W+release (read/write) 2303340 2303324 -16 -0.0
.text 1265912 1265896 -16 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 rodata 118268 118252 -16 -0.0
nrf52840dk_nrf52840+rpc (read/write) 974379 974375 -4 -0.0
rodata 109656 109636 -20 -0.0
nrf52840dongle_nrf52840 rodata 117156 117140 -16 -0.0
nrf5340dk_nrf5340_cpuapp rodata 111524 111508 -16 -0.0
lock-app nrf52840dk_nrf52840 rodata 106668 106652 -16 -0.0
nrf5340dk_nrf5340_cpuapp rodata 99836 99820 -16 -0.0
pump-app nrf52840dk_nrf52840 rodata 106848 106832 -16 -0.0
pump-controller-app nrf52840dk_nrf52840 rodata 106140 106124 -16 -0.0
p6 all-clusters-app default .data 2584 2576 -8 -0.3
qpg lighting-app qpg6105+debug .data 1084 1080 -4 -0.4
lock-app qpg6105+debug (read/write) 146940 146936 -4 -0.0
.data 1024 1020 -4 -0.4
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b5dae1e fbeccc1 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 595370 595378 8 0.0
.app_xip_area 500904 500912 8 0.0
.bss 77188 77188 0 0.0
.data 624 620 -4 -0.6
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 553262 553262 0 0.0
.app_xip_area 460356 460364 8 0.0
.bss 75660 75660 0 0.0
.data 588 584 -4 -0.7
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577286 577286 0 0.0
.app_xip_area 475060 475068 8 0.0
.bss 84652 84652 0 0.0
.data 532 528 -4 -0.8
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 866548 866564 16 0.0
(read/write) 126684 126680 -4 -0.0
.bss 124760 124760 0 0.0
.data 1924 1920 -4 -0.2
.text 866540 866556 16 0.0
BRD4161A+rpc (read only) 853996 854012 16 0.0
(read/write) 143344 143340 -4 -0.0
.bss 141320 141320 0 0.0
.data 2024 2020 -4 -0.2
.text 853988 854004 16 0.0
window-app BRD4161A (read only) 838752 838760 8 0.0
(read/write) 125328 125328 0 0.0
.bss 123448 123448 0 0.0
.data 1880 1876 -4 -0.2
.text 838744 838752 8 0.0
esp32 all-clusters-app c3devkit (read only) 938468 938530 62 0.0
(read/write) 1401370 1401346 -24 -0.0
.dram0.bss 69512 69512 0 0.0
.dram0.data 14276 14276 0 0.0
.flash.rodata 198672 198648 -24 -0.0
.flash.text 938468 938530 62 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 986815 986891 76 0.0
(read/write) 466400 466384 -16 -0.0
.dram0.bss 74656 74656 0 0.0
.dram0.data 34040 34040 0 0.0
.flash.rodata 225576 225560 -16 -0.0
.flash.text 981431 981507 76 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 679180 679176 -4 -0.0
.bss 76632 76632 0 0.0
.data 1884 1880 -4 -0.2
.text 594864 594864 0 0.0
lock k32w061+release (read/write) 681080 681092 12 0.0
.bss 76960 76960 0 0.0
.data 1924 1920 -4 -0.2
.text 596396 596412 16 0.0
linux all-clusters-app debug (read only) 2329049 2329697 648 0.0
(read/write) 140096 140064 -32 -0.0
.bss 54688 54688 0 0.0
.data 1200 1184 -16 -1.3
.data.rel.ro 78536 78536 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205221 205221 0 0.0
.text 1961506 1962178 672 0.0
bridge-app debug+rpc (read only) 1705733 1706381 648 0.0
(read/write) 84328 84328 0 0.0
.bss 39088 39088 0 0.0
.data 1970 1970 0 0.0
.data.rel.ro 38120 38120 0 0.0
.dynamic 592 592 0 0.0
.got 3976 3976 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 140332 140332 0 0.0
.text 1448853 1449525 672 0.0
chip-tool debug (read only) 7483109 7483741 632 0.0
(read/write) 198072 198072 0 0.0
.bss 32360 32360 0 0.0
.data 1152 1136 -16 -1.4
.data.rel.ro 158536 158536 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 416597 416565 -32 -0.0
.text 6664085 6664773 688 0.0
chip-tool-ipv6only arm64 (read only) 7403628 7403660 32 0.0
(read/write) 302401 302385 -16 -0.0
.bss 50641 50641 0 0.0
.data 1176 1168 -8 -0.7
.data.rel.ro 200208 200208 0 0.0
.dynamic 560 560 0 0.0
.got 46584 46576 -8 -0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 399268 399268 0 0.0
.text 6364532 6364612 80 0.0
door-lock-app debug (read only) 1910201 1910817 616 0.0
(read/write) 110584 110584 0 0.0
.bss 42096 42096 0 0.0
.data 946 946 0 0.0
.data.rel.ro 62128 62128 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 173010 172978 -32 -0.0
.text 1588674 1589346 672 0.0
lighting-app debug+rpc (read only) 2005001 2005617 616 0.0
(read/write) 115632 115632 0 0.0
.bss 43104 43104 0 0.0
.data 1368 1368 0 0.0
.data.rel.ro 65672 65672 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 163057 163025 -32 -0.0
.text 1687298 1687970 672 0.0
ota-provider-app debug (read only) 1714425 1715041 616 0.0
(read/write) 81368 81336 -32 -0.0
.bss 41120 41120 0 0.0
.data 1160 1128 -32 -2.8
.data.rel.ro 33560 33560 0 0.0
.dynamic 608 608 0 0.0
.got 4240 4240 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 151910 151878 -32 -0.0
.text 1443810 1444482 672 0.0
ota-requestor-app debug (read only) 1703065 1703713 648 0.0
(read/write) 83320 83288 -32 -0.0
.bss 42272 42272 0 0.0
.data 1128 1096 -32 -2.8
.data.rel.ro 34616 34616 0 0.0
.dynamic 592 592 0 0.0
.got 4040 4040 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 145047 145047 0 0.0
.text 1441122 1441794 672 0.0
shell debug (read only) 2302537 2303153 616 0.0
(read/write) 141648 141648 0 0.0
.bss 62080 62080 0 0.0
.data 800 784 -16 -2.0
.data.rel.ro 73072 73072 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 205970 205938 -32 -0.0
.text 1940050 1940722 672 0.0
thermostat-no-ble arm64 (read only) 2130908 2130908 0 0.0
(read/write) 140673 140657 -16 -0.0
.bss 57665 57665 0 0.0
.data 984 976 -8 -0.8
.data.rel.ro 74904 74904 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4144 -8 -0.2
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 132108 132092 -16 -0.0
.text 1780736 1780800 64 0.0
tv-app debug (read only) 2527129 2527745 616 0.0
(read/write) 139832 139800 -32 -0.0
.bss 57280 57280 0 0.0
.data 3168 3136 -32 -1.0
.data.rel.ro 73368 73368 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 195756 195724 -32 -0.0
.text 2157666 2158338 672 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2390216 2390264 48 0.0
.bss 188420 188420 0 0.0
.data 5296 5296 0 0.0
.text 1352816 1352864 48 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2349448 2349432 -16 -0.0
.bss 181000 181000 0 0.0
.data 5600 5592 -8 -0.1
.text 1312048 1312032 -16 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2313368 2313352 -16 -0.0
.bss 180888 180888 0 0.0
.data 5584 5576 -8 -0.1
.text 1275968 1275952 -16 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303340 2303324 -16 -0.0
.bss 178164 178164 0 0.0
.data 5400 5400 0 0.0
.text 1265912 1265896 -16 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1005407 1005415 8 0.0
bss 121344 121344 0 0.0
rodata 118268 118252 -16 -0.0
text 686916 686944 28 0.0
nrf52840dk_nrf52840+rpc (read/write) 974379 974375 -4 -0.0
bss 118532 118532 0 0.0
rodata 109656 109636 -20 -0.0
text 666528 666556 28 0.0
nrf52840dongle_nrf52840 (read/write) 1022211 1022227 16 0.0
bss 122708 122708 0 0.0
rodata 117156 117140 -16 -0.0
text 692484 692512 28 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 912130 912138 8 0.0
bss 117904 117904 0 0.0
rodata 111524 111508 -16 -0.0
text 601940 601968 28 0.0
lock-app nrf52840dk_nrf52840 (read/write) 937663 937663 0 0.0
bss 119680 119680 0 0.0
rodata 106668 106652 -16 -0.0
text 632836 632864 28 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 845218 845234 16 0.0
bss 116276 116276 0 0.0
rodata 99836 99820 -16 -0.0
text 548636 548664 28 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 940019 940027 8 0.0
bss 119432 119432 0 0.0
rodata 106848 106832 -16 -0.0
text 635080 635108 28 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 935359 935375 16 0.0
bss 119436 119436 0 0.0
rodata 106140 106124 -16 -0.0
text 631112 631140 28 0.0
shell nrf52840dk_nrf52840 (read/write) 803719 803719 0 0.0
bss 111296 111296 0 0.0
rodata 78668 78668 0 0.0
text 536128 536128 0 0.0
p6 all-clusters-app default (read/write) 2464512 2464528 16 0.0
.bss 118040 118040 0 0.0
.data 2584 2576 -8 -0.3
.text 1422776 1422792 16 0.0
light-app default (read/write) 2367968 2367976 8 0.0
.bss 107664 107664 0 0.0
.data 2432 2432 0 0.0
.text 1326232 1326240 8 0.0
lock-app default (read/write) 2333152 2333160 8 0.0
.bss 107368 107368 0 0.0
.data 2392 2392 0 0.0
.text 1291416 1291424 8 0.0
qpg lighting-app qpg6105+debug (read only) 586352 586360 8 0.0
(read/write) 146936 146940 4 0.0
.bss 88920 88920 0 0.0
.data 1084 1080 -4 -0.4
.text 581032 581040 8 0.0
lock-app qpg6105+debug (read only) 532420 532428 8 0.0
(read/write) 146940 146936 -4 -0.0
.bss 88368 88368 0 0.0
.data 1024 1020 -4 -0.4
.text 527100 527108 8 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 866518 866530 12 0.0
bss 88656 88656 0 0.0
noinit 37160 37160 0 0.0
text 608172 608206 34 0.0

@emargolis emargolis force-pushed the emargolis/feature/spake-param-get-from-memory branch from fbeccc1 to 0f9108e Compare February 10, 2022 07:24
@pullapprove pullapprove bot requested a review from lazarkov February 10, 2022 07:32
@github-actions
Copy link

github-actions bot commented Feb 10, 2022 •
edited
Loading

PR #14676: Size comparison from 87d1d3e to 0f9108e

Increases (19 builds for cyw30739, efr32, esp32, k32w, linux, mbed, qpg, telink)
platform target config section 87d1d3e 0f9108e change % change
cyw30739 light cyw930739m2evb_01 (read/write) 606702 607086 384 0.1
.app_xip_area 508132 508516 384 0.1
lock cyw930739m2evb_01 (read/write) 563174 563790 616 0.1
.app_xip_area 466164 466788 624 0.1
ota-requestor cyw930739m2evb_01 (read/write) 584190 584566 376 0.1
.app_xip_area 477932 478316 384 0.1
efr32 lighting-app BRD4161A (read only) 906824 907504 680 0.1
.text 906816 907496 680 0.1
BRD4161A+rpc (read only) 894268 894948 680 0.1
.text 894260 894940 680 0.1
window-app BRD4161A (read only) 841936 842632 696 0.1
.text 841928 842624 696 0.1
esp32 all-clusters-app c3devkit (read only) 943304 943822 518 0.1
.flash.text 943304 943822 518 0.1
m5stack (read only) 990967 991127 160 0.0
.flash.text 985583 985743 160 0.0
k32w light k32w061+release (read/write) 683560 684200 640 0.1
.text 597588 598232 644 0.1
lock k32w061+release (read/write) 688440 689080 640 0.1
.text 602024 602668 644 0.1
linux chip-tool-ipv6only arm64 (read only) 7478108 7479148 1040 0.0
(read/write) 303409 303441 32 0.0
.data.rel.ro 199520 199568 48 0.0
.rodata 403012 403140 128 0.0
.text 6435220 6436132 912 0.0
thermostat-no-ble arm64 (read only) 2139804 2139996 192 0.0
(read/write) 142273 142305 32 0.0
.data.rel.ro 74912 74960 48 0.1
.text 1788736 1789424 688 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2396136 2396768 632 0.0
.text 1358736 1359368 632 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2357760 2358392 632 0.0
.text 1320360 1320992 632 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2321288 2321984 696 0.0
.text 1283888 1284584 696 0.1
shell CY8CPROTO_062_4343W+release (read/write) 2307292 2307988 696 0.0
.text 1269864 1270560 696 0.1
qpg lighting-app qpg6105+debug (read only) 592980 593616 636 0.1
.text 587660 588296 636 0.1
lock-app qpg6105+debug (read only) 558732 559368 636 0.1
.text 553412 554048 636 0.1
telink lighting-app tlsr9518adk80d (read/write) 874334 874814 480 0.1
text 613082 613448 366 0.1
Decreases (19 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg)
platform target config section 87d1d3e 0f9108e change % change
cyw30739 light cyw930739m2evb_01 .data 648 644 -4 -0.6
lock cyw930739m2evb_01 .data 612 608 -4 -0.7
ota-requestor cyw930739m2evb_01 .data 556 552 -4 -0.7
efr32 lighting-app BRD4161A (read/write) 129000 128992 -8 -0.0
.data 2036 2032 -4 -0.2
BRD4161A+rpc (read/write) 145656 145652 -4 -0.0
.data 2136 2132 -4 -0.2
window-app BRD4161A .data 1904 1900 -4 -0.2
esp32 all-clusters-app c3devkit (read/write) 1400250 1399770 -480 -0.0
.dram0.data 14276 14268 -8 -0.1
.flash.rodata 199040 198576 -464 -0.2
m5stack (read/write) 465080 464608 -472 -0.1
.dram0.data 34072 34064 -8 -0.0
.flash.rodata 225712 225248 -464 -0.2
k32w light k32w061+release .data 1908 1904 -4 -0.2
lock k32w061+release .data 1952 1948 -4 -0.2
linux chip-tool-ipv6only arm64 .data 1224 1216 -8 -0.7
.got 47088 47080 -8 -0.0
thermostat-no-ble arm64 .data 1040 1032 -8 -0.8
.got 4152 4144 -8 -0.2
.rodata 132956 132460 -496 -0.4
mbed lighting-app CY8CPROTO_062_4343W+release .data 5632 5624 -8 -0.1
lock-app CY8CPROTO_062_4343W+release .data 5608 5600 -8 -0.1
p6 all-clusters-app default (read/write) 2482336 2482288 -48 -0.0
.text 1440600 1440552 -48 -0.0
light-app default (read/write) 2388664 2388616 -48 -0.0
.data 2528 2520 -8 -0.3
.text 1346928 1346880 -48 -0.0
lock-app default (read/write) 2352120 2352072 -48 -0.0
.data 2488 2480 -8 -0.3
.text 1310384 1310336 -48 -0.0
qpg lighting-app qpg6105+debug (read/write) 146940 146936 -4 -0.0
.data 1112 1108 -4 -0.4
lock-app qpg6105+debug (read/write) 146940 146936 -4 -0.0
.data 1064 1060 -4 -0.4
Full report (24 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 87d1d3e 0f9108e change % change
cyw30739 light cyw930739m2evb_01 (read/write) 606702 607086 384 0.1
.app_xip_area 508132 508516 384 0.1
.bss 81268 81268 0 0.0
.data 648 644 -4 -0.6
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 563174 563790 616 0.1
.app_xip_area 466164 466788 624 0.1
.bss 79740 79740 0 0.0
.data 612 608 -4 -0.7
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 584190 584566 376 0.1
.app_xip_area 477932 478316 384 0.1
.bss 88660 88660 0 0.0
.data 556 552 -4 -0.7
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 906824 907504 680 0.1
(read/write) 129000 128992 -8 -0.0
.bss 126960 126960 0 0.0
.data 2036 2032 -4 -0.2
.text 906816 907496 680 0.1
BRD4161A+rpc (read only) 894268 894948 680 0.1
(read/write) 145656 145652 -4 -0.0
.bss 143520 143520 0 0.0
.data 2136 2132 -4 -0.2
.text 894260 894940 680 0.1
window-app BRD4161A (read only) 841936 842632 696 0.1
(read/write) 127064 127064 0 0.0
.bss 125160 125160 0 0.0
.data 1904 1900 -4 -0.2
.text 841928 842624 696 0.1
esp32 all-clusters-app c3devkit (read only) 943304 943822 518 0.1
(read/write) 1400250 1399770 -480 -0.0
.dram0.bss 68024 68024 0 0.0
.dram0.data 14276 14268 -8 -0.1
.flash.rodata 199040 198576 -464 -0.2
.flash.text 943304 943822 518 0.1
.iram0.text 62056 62056 0 0.0
m5stack (read only) 990967 991127 160 0.0
(read/write) 465080 464608 -472 -0.1
.dram0.bss 73168 73168 0 0.0
.dram0.data 34072 34064 -8 -0.0
.flash.rodata 225712 225248 -464 -0.2
.flash.text 985583 985743 160 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 683560 684200 640 0.1
.bss 78264 78264 0 0.0
.data 1908 1904 -4 -0.2
.text 597588 598232 644 0.1
lock k32w061+release (read/write) 688440 689080 640 0.1
.bss 78664 78664 0 0.0
.data 1952 1948 -4 -0.2
.text 602024 602668 644 0.1
linux chip-tool-ipv6only arm64 (read only) 7478108 7479148 1040 0.0
(read/write) 303409 303441 32 0.0
.bss 51777 51777 0 0.0
.data 1224 1216 -8 -0.7
.data.rel.ro 199520 199568 48 0.0
.dynamic 560 560 0 0.0
.got 47088 47080 -8 -0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 403012 403140 128 0.0
.text 6435220 6436132 912 0.0
thermostat-no-ble arm64 (read only) 2139804 2139996 192 0.0
(read/write) 142273 142305 32 0.0
.bss 59201 59201 0 0.0
.data 1040 1032 -8 -0.8
.data.rel.ro 74912 74960 48 0.1
.dynamic 560 560 0 0.0
.got 4152 4144 -8 -0.2
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 132956 132460 -496 -0.4
.text 1788736 1789424 688 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2396136 2396768 632 0.0
.bss 190092 190092 0 0.0
.data 5320 5320 0 0.0
.text 1358736 1359368 632 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2357760 2358392 632 0.0
.bss 182704 182704 0 0.0
.data 5632 5624 -8 -0.1
.text 1320360 1320992 632 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2321288 2321984 696 0.0
.bss 182592 182592 0 0.0
.data 5608 5600 -8 -0.1
.text 1283888 1284584 696 0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307292 2307988 696 0.0
.bss 179844 179844 0 0.0
.data 5424 5424 0 0.0
.text 1269864 1270560 696 0.1
p6 all-clusters-app default (read/write) 2482336 2482288 -48 -0.0
.bss 119704 119704 0 0.0
.data 2672 2672 0 0.0
.text 1440600 1440552 -48 -0.0
light-app default (read/write) 2388664 2388616 -48 -0.0
.bss 109352 109352 0 0.0
.data 2528 2520 -8 -0.3
.text 1346928 1346880 -48 -0.0
lock-app default (read/write) 2352120 2352072 -48 -0.0
.bss 109072 109072 0 0.0
.data 2488 2480 -8 -0.3
.text 1310384 1310336 -48 -0.0
qpg lighting-app qpg6105+debug (read only) 592980 593616 636 0.1
(read/write) 146940 146936 -4 -0.0
.bss 90536 90536 0 0.0
.data 1112 1108 -4 -0.4
.text 587660 588296 636 0.1
lock-app qpg6105+debug (read only) 558732 559368 636 0.1
(read/write) 146940 146936 -4 -0.0
.bss 90520 90520 0 0.0
.data 1064 1060 -4 -0.4
.text 553412 554048 636 0.1
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 874334 874814 480 0.1
bss 90352 90352 0 0.0
noinit 37160 37160 0 0.0
text 613082 613448 366 0.1

@emargolis
Updated Device to Get PASE Verifier from Memory.
9dc787c 
Also removed one version of the PASESession::WaitForPairing() API, which
gets PIN Code as an input. Left only one version, which gets Verifier as
an input.

Updated configuration manager GetSpake2pSalt() and GetSpake2pVerifier() APIs
to fetch Salt and Verifier values from the memory as base-64 encoded string.
@emargolis emargolis force-pushed the emargolis/feature/spake-param-get-from-memory branch from 0f9108e to 9dc787c Compare February 10, 2022 08:57
@github-actions
Copy link

github-actions bot commented Feb 10, 2022 •
edited
Loading

PR #14676: Size comparison from f0baba8 to 9dc787c

Increases (28 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, qpg, telink)
platform target config section f0baba8 9dc787c change % change
cyw30739 light cyw930739m2evb_01 (read/write) 606702 607086 384 0.1
.app_xip_area 508132 508516 384 0.1
lock cyw930739m2evb_01 (read/write) 563174 563790 616 0.1
.app_xip_area 466164 466788 624 0.1
ota-requestor cyw930739m2evb_01 (read/write) 584190 584566 376 0.1
.app_xip_area 477932 478316 384 0.1
efr32 lighting-app BRD4161A (read only) 906824 907504 680 0.1
.text 906816 907496 680 0.1
BRD4161A+rpc (read only) 894268 894948 680 0.1
.text 894260 894940 680 0.1
window-app BRD4161A (read only) 841936 842632 696 0.1
.text 841928 842624 696 0.1
esp32 all-clusters-app c3devkit (read only) 943304 943822 518 0.1
.flash.text 943304 943822 518 0.1
m5stack (read only) 990967 991127 160 0.0
.flash.text 985583 985743 160 0.0
k32w light k32w061+release (read/write) 683560 684200 640 0.1
.text 597588 598232 644 0.1
lock k32w061+release (read/write) 688440 689080 640 0.1
.text 602024 602668 644 0.1
linux chip-tool-ipv6only arm64 (read only) 7478108 7479148 1040 0.0
(read/write) 303409 303441 32 0.0
.data.rel.ro 199520 199568 48 0.0
.rodata 403012 403140 128 0.0
.text 6435220 6436132 912 0.0
thermostat-no-ble arm64 (read only) 2139804 2139996 192 0.0
(read/write) 142273 142305 32 0.0
.data.rel.ro 74912 74960 48 0.1
.text 1788736 1789424 688 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2396136 2396768 632 0.0
.text 1358736 1359368 632 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2357760 2358392 632 0.0
.text 1320360 1320992 632 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2321288 2321984 696 0.0
.text 1283888 1284584 696 0.1
shell CY8CPROTO_062_4343W+release (read/write) 2307292 2307988 696 0.0
.text 1269864 1270560 696 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1015395 1016027 632 0.1
rodata 119416 119528 112 0.1
text 693940 694472 532 0.1
nrf52840dk_nrf52840+rpc (read/write) 984215 984859 644 0.1
rodata 110780 110896 116 0.1
text 673552 674084 532 0.1
nrf52840dongle_nrf52840 (read/write) 1031099 1031743 644 0.1
rodata 118276 118392 116 0.1
text 698556 699088 532 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 921990 922642 652 0.1
rodata 112656 112772 116 0.1
text 608976 609508 532 0.1
lock-app nrf52840dk_nrf52840 (read/write) 945099 945743 644 0.1
rodata 108160 108276 116 0.1
text 636968 637500 532 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 852610 853250 640 0.1
rodata 101332 101444 112 0.1
text 552776 553308 532 0.1
pump-app nrf52840dk_nrf52840 (read/write) 944539 945171 632 0.1
rodata 107520 107632 112 0.1
text 637228 637760 532 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 939863 940519 656 0.1
rodata 106812 106924 112 0.1
text 633264 633796 532 0.1
shell nrf52840dk_nrf52840 (read/write) 805927 806319 392 0.0
rodata 78812 78948 136 0.2
text 537036 537296 260 0.0
qpg lighting-app qpg6105+debug (read only) 592980 593616 636 0.1
.text 587660 588296 636 0.1
lock-app qpg6105+debug (read only) 558732 559368 636 0.1
.text 553412 554048 636 0.1
telink lighting-app tlsr9518adk80d (read/write) 874334 874814 480 0.1
text 613082 613448 366 0.1
Decreases (19 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg)
platform target config section f0baba8 9dc787c change % change
cyw30739 light cyw930739m2evb_01 .data 648 644 -4 -0.6
lock cyw930739m2evb_01 .data 612 608 -4 -0.7
ota-requestor cyw930739m2evb_01 .data 556 552 -4 -0.7
efr32 lighting-app BRD4161A (read/write) 129000 128992 -8 -0.0
.data 2036 2032 -4 -0.2
BRD4161A+rpc (read/write) 145656 145652 -4 -0.0
.data 2136 2132 -4 -0.2
window-app BRD4161A .data 1904 1900 -4 -0.2
esp32 all-clusters-app c3devkit (read/write) 1400250 1399770 -480 -0.0
.dram0.data 14276 14268 -8 -0.1
.flash.rodata 199040 198576 -464 -0.2
m5stack (read/write) 465080 464608 -472 -0.1
.dram0.data 34072 34064 -8 -0.0
.flash.rodata 225712 225248 -464 -0.2
k32w light k32w061+release .data 1908 1904 -4 -0.2
lock k32w061+release .data 1952 1948 -4 -0.2
linux chip-tool-ipv6only arm64 .data 1224 1216 -8 -0.7
.got 47088 47080 -8 -0.0
thermostat-no-ble arm64 .data 1040 1032 -8 -0.8
.got 4152 4144 -8 -0.2
.rodata 132956 132460 -496 -0.4
mbed lighting-app CY8CPROTO_062_4343W+release .data 5632 5624 -8 -0.1
lock-app CY8CPROTO_062_4343W+release .data 5608 5600 -8 -0.1
p6 all-clusters-app default (read/write) 2482336 2482288 -48 -0.0
.text 1440600 1440552 -48 -0.0
light-app default (read/write) 2388664 2388616 -48 -0.0
.data 2528 2520 -8 -0.3
.text 1346928 1346880 -48 -0.0
lock-app default (read/write) 2352120 2352072 -48 -0.0
.data 2488 2480 -8 -0.3
.text 1310384 1310336 -48 -0.0
qpg lighting-app qpg6105+debug (read/write) 146940 146936 -4 -0.0
.data 1112 1108 -4 -0.4
lock-app qpg6105+debug (read/write) 146940 146936 -4 -0.0
.data 1064 1060 -4 -0.4
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section f0baba8 9dc787c change % change
cyw30739 light cyw930739m2evb_01 (read/write) 606702 607086 384 0.1
.app_xip_area 508132 508516 384 0.1
.bss 81268 81268 0 0.0
.data 648 644 -4 -0.6
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 563174 563790 616 0.1
.app_xip_area 466164 466788 624 0.1
.bss 79740 79740 0 0.0
.data 612 608 -4 -0.7
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 584190 584566 376 0.1
.app_xip_area 477932 478316 384 0.1
.bss 88660 88660 0 0.0
.data 556 552 -4 -0.7
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 906824 907504 680 0.1
(read/write) 129000 128992 -8 -0.0
.bss 126960 126960 0 0.0
.data 2036 2032 -4 -0.2
.text 906816 907496 680 0.1
BRD4161A+rpc (read only) 894268 894948 680 0.1
(read/write) 145656 145652 -4 -0.0
.bss 143520 143520 0 0.0
.data 2136 2132 -4 -0.2
.text 894260 894940 680 0.1
window-app BRD4161A (read only) 841936 842632 696 0.1
(read/write) 127064 127064 0 0.0
.bss 125160 125160 0 0.0
.data 1904 1900 -4 -0.2
.text 841928 842624 696 0.1
esp32 all-clusters-app c3devkit (read only) 943304 943822 518 0.1
(read/write) 1400250 1399770 -480 -0.0
.dram0.bss 68024 68024 0 0.0
.dram0.data 14276 14268 -8 -0.1
.flash.rodata 199040 198576 -464 -0.2
.flash.text 943304 943822 518 0.1
.iram0.text 62056 62056 0 0.0
m5stack (read only) 990967 991127 160 0.0
(read/write) 465080 464608 -472 -0.1
.dram0.bss 73168 73168 0 0.0
.dram0.data 34072 34064 -8 -0.0
.flash.rodata 225712 225248 -464 -0.2
.flash.text 985583 985743 160 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 683560 684200 640 0.1
.bss 78264 78264 0 0.0
.data 1908 1904 -4 -0.2
.text 597588 598232 644 0.1
lock k32w061+release (read/write) 688440 689080 640 0.1
.bss 78664 78664 0 0.0
.data 1952 1948 -4 -0.2
.text 602024 602668 644 0.1
linux chip-tool-ipv6only arm64 (read only) 7478108 7479148 1040 0.0
(read/write) 303409 303441 32 0.0
.bss 51777 51777 0 0.0
.data 1224 1216 -8 -0.7
.data.rel.ro 199520 199568 48 0.0
.dynamic 560 560 0 0.0
.got 47088 47080 -8 -0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 403012 403140 128 0.0
.text 6435220 6436132 912 0.0
thermostat-no-ble arm64 (read only) 2139804 2139996 192 0.0
(read/write) 142273 142305 32 0.0
.bss 59201 59201 0 0.0
.data 1040 1032 -8 -0.8
.data.rel.ro 74912 74960 48 0.1
.dynamic 560 560 0 0.0
.got 4152 4144 -8 -0.2
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 132956 132460 -496 -0.4
.text 1788736 1789424 688 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2396136 2396768 632 0.0
.bss 190092 190092 0 0.0
.data 5320 5320 0 0.0
.text 1358736 1359368 632 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2357760 2358392 632 0.0
.bss 182704 182704 0 0.0
.data 5632 5624 -8 -0.1
.text 1320360 1320992 632 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2321288 2321984 696 0.0
.bss 182592 182592 0 0.0
.data 5608 5600 -8 -0.1
.text 1283888 1284584 696 0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307292 2307988 696 0.0
.bss 179844 179844 0 0.0
.data 5424 5424 0 0.0
.text 1269864 1270560 696 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1015395 1016027 632 0.1
bss 123020 123020 0 0.0
rodata 119416 119528 112 0.1
text 693940 694472 532 0.1
nrf52840dk_nrf52840+rpc (read/write) 984215 984859 644 0.1
bss 120208 120208 0 0.0
rodata 110780 110896 116 0.1
text 673552 674084 532 0.1
nrf52840dongle_nrf52840 (read/write) 1031099 1031743 644 0.1
bss 124416 124416 0 0.0
rodata 118276 118392 116 0.1
text 698556 699088 532 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 921990 922642 652 0.1
bss 119584 119584 0 0.0
rodata 112656 112772 116 0.1
text 608976 609508 532 0.1
lock-app nrf52840dk_nrf52840 (read/write) 945099 945743 644 0.1
bss 121400 121400 0 0.0
rodata 108160 108276 116 0.1
text 636968 637500 532 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 852610 853250 640 0.1
bss 117992 117992 0 0.0
rodata 101332 101444 112 0.1
text 552776 553308 532 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 944539 945171 632 0.1
bss 121120 121120 0 0.0
rodata 107520 107632 112 0.1
text 637228 637760 532 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 939863 940519 656 0.1
bss 121124 121124 0 0.0
rodata 106812 106924 112 0.1
text 633264 633796 532 0.1
shell nrf52840dk_nrf52840 (read/write) 805927 806319 392 0.0
bss 112400 112400 0 0.0
rodata 78812 78948 136 0.2
text 537036 537296 260 0.0
p6 all-clusters-app default (read/write) 2482336 2482288 -48 -0.0
.bss 119704 119704 0 0.0
.data 2672 2672 0 0.0
.text 1440600 1440552 -48 -0.0
light-app default (read/write) 2388664 2388616 -48 -0.0
.bss 109352 109352 0 0.0
.data 2528 2520 -8 -0.3
.text 1346928 1346880 -48 -0.0
lock-app default (read/write) 2352120 2352072 -48 -0.0
.bss 109072 109072 0 0.0
.data 2488 2480 -8 -0.3
.text 1310384 1310336 -48 -0.0
qpg lighting-app qpg6105+debug (read only) 592980 593616 636 0.1
(read/write) 146940 146936 -4 -0.0
.bss 90536 90536 0 0.0
.data 1112 1108 -4 -0.4
.text 587660 588296 636 0.1
lock-app qpg6105+debug (read only) 558732 559368 636 0.1
(read/write) 146940 146936 -4 -0.0
.bss 90520 90520 0 0.0
.data 1064 1060 -4 -0.4
.text 553412 554048 636 0.1
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 874334 874814 480 0.1
bss 90352 90352 0 0.0
noinit 37160 37160 0 0.0
text 613082 613448 366 0.1

@emargolis emargolis merged commit 1e8ed9d into project-chip:master Feb 10, 2022
mspang added a commit to mspang/connectedhomeip that referenced this pull request Feb 12, 2022
@mspang
Fix include checking for src/include/platform/internal/*.cpp
3ac0b7f 
Since these .cpp files are included instead of being listed in sources,
they are not processed by the include checker. This has allowed the
introduction of a dependency cycle in

  1e8ed9d ("Updated Device to Get PASE Verifier from Memory. (project-chip#14676)")

which in turn result in the following build flake:

  FAILED: obj/src/platform/Darwin/Darwin.ConfigurationManagerImpl.cpp.o
  g++ -MMD -MF obj/src/platform/Darwin/Darwin.ConfigurationManagerImpl.cpp.o.d -target x86_64-apple-macos10.15 -O0 -g2 -fno-common -ffunction-sections -fdata-sections -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -Wall -Werror -Wextra -Wshadow -Wunreachable-code -Wvla -Wformat -Wformat-nonliteral -Wformat-security -Wno-deprecated-declarations -Wno-unknown-warning-option -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wno-cast-function-type -fno-strict-aliasing -target x86_64-apple-macos10.15 -arch arm64 -arch x86_64 -fobjc-arc -std=gnu++14 -fno-rtti -Wnon-virtual-dtor -DCHIP_HAVE_CONFIG_H=1 -I../../../../../../../../src/include -I../../../../../../../../src -Igen/include -I../../../../../../../../zzz_generated/app-common -I../../../../../../../../config/standalone -I../../../../../../../../third_party/nlassert/repo/include -I../../../../../../../../third_party/nlio/repo/include -I../../../../../../../../third_party/mbedtls/repo/include -c ../../../../../../../../src/platform/Darwin/ConfigurationManagerImpl.cpp -o obj/src/platform/Darwin/Darwin.ConfigurationManagerImpl.cpp.o
  In file included from ../../../../../../../../src/platform/Darwin/ConfigurationManagerImpl.cpp:31:
  In file included from ../../../../../../../../src/include/platform/internal/GenericConfigurationManagerImpl.cpp:38:
  In file included from ../../../../../../../../src/protocols/secure_channel/PASESession.h:34:
  In file included from ../../../../../../../../src/messaging/ExchangeContext.h:31:
  In file included from ../../../../../../../../src/messaging/ExchangeDelegate.h:27:
  In file included from ../../../../../../../../src/messaging/ApplicationExchangeDispatch.h:28:
  In file included from ../../../../../../../../src/messaging/ExchangeMessageDispatch.h:27:
  In file included from ../../../../../../../../src/transport/SessionManager.h:39:
  In file included from ../../../../../../../../src/transport/GroupSession.h:22:
  In file included from ../../../../../../../../src/transport/Session.h:19:
  In file included from ../../../../../../../../src/credentials/FabricTable.h:27:
  In file included from ../../../../../../../../src/credentials/CHIPCert.h:34:
  ../../../../../../../../src/lib/asn1/ASN1.h:30:10: fatal error: 'asn1/ASN1OID.h' file not found
  #include <asn1/ASN1OID.h>
           ^~~~~~~~~~~~~~~~
  1 error generated.

The requisite dependency for this include cannot be added, because it
results in a cycle:

  ERROR Dependency cycle:
    //src/platform:platform ->
    //src/protocols/secure_channel:secure_channel ->
    //src/messaging:messaging ->
    //src/platform:platform

Fix the diagnostic so that dependency errors in these files are caught:

  ERROR at //src/include/platform/internal/GenericConfigurationManagerImpl.ipp:38:11: Include not allowed.
  #include <protocols/secure_channel/PASESession.h>
	    ^-------------------------------------
  It is not in any dependency of
    //src/platform:platform
  The include file is in the target(s):
    //src/protocols/secure_channel:secure_channel
  which should somehow be reachable.
mspang added a commit to mspang/connectedhomeip that referenced this pull request Feb 12, 2022
@mspang
Revert "Updated Device to Get PASE Verifier from Memory. (project-chi…
3a9ba0a 
…p#14676)"

This reverts commit 1e8ed9d.
mspang added a commit to mspang/connectedhomeip that referenced this pull request Feb 12, 2022
@mspang
Fix include checking for src/include/platform/internal/*.cpp
353ade0 
Since these .cpp files are included instead of being listed in sources,
they are not processed by the include checker. This has allowed the
introduction of a dependency cycle in

  1e8ed9d ("Updated Device to Get PASE Verifier from Memory. (project-chip#14676)")

which in turn result in the following build flake:

  FAILED: obj/src/platform/Darwin/Darwin.ConfigurationManagerImpl.cpp.o
  g++ -MMD -MF obj/src/platform/Darwin/Darwin.ConfigurationManagerImpl.cpp.o.d -target x86_64-apple-macos10.15 -O0 -g2 -fno-common -ffunction-sections -fdata-sections -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -Wall -Werror -Wextra -Wshadow -Wunreachable-code -Wvla -Wformat -Wformat-nonliteral -Wformat-security -Wno-deprecated-declarations -Wno-unknown-warning-option -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wno-cast-function-type -fno-strict-aliasing -target x86_64-apple-macos10.15 -arch arm64 -arch x86_64 -fobjc-arc -std=gnu++14 -fno-rtti -Wnon-virtual-dtor -DCHIP_HAVE_CONFIG_H=1 -I../../../../../../../../src/include -I../../../../../../../../src -Igen/include -I../../../../../../../../zzz_generated/app-common -I../../../../../../../../config/standalone -I../../../../../../../../third_party/nlassert/repo/include -I../../../../../../../../third_party/nlio/repo/include -I../../../../../../../../third_party/mbedtls/repo/include -c ../../../../../../../../src/platform/Darwin/ConfigurationManagerImpl.cpp -o obj/src/platform/Darwin/Darwin.ConfigurationManagerImpl.cpp.o
  In file included from ../../../../../../../../src/platform/Darwin/ConfigurationManagerImpl.cpp:31:
  In file included from ../../../../../../../../src/include/platform/internal/GenericConfigurationManagerImpl.cpp:38:
  In file included from ../../../../../../../../src/protocols/secure_channel/PASESession.h:34:
  In file included from ../../../../../../../../src/messaging/ExchangeContext.h:31:
  In file included from ../../../../../../../../src/messaging/ExchangeDelegate.h:27:
  In file included from ../../../../../../../../src/messaging/ApplicationExchangeDispatch.h:28:
  In file included from ../../../../../../../../src/messaging/ExchangeMessageDispatch.h:27:
  In file included from ../../../../../../../../src/transport/SessionManager.h:39:
  In file included from ../../../../../../../../src/transport/GroupSession.h:22:
  In file included from ../../../../../../../../src/transport/Session.h:19:
  In file included from ../../../../../../../../src/credentials/FabricTable.h:27:
  In file included from ../../../../../../../../src/credentials/CHIPCert.h:34:
  ../../../../../../../../src/lib/asn1/ASN1.h:30:10: fatal error: 'asn1/ASN1OID.h' file not found
  #include <asn1/ASN1OID.h>
           ^~~~~~~~~~~~~~~~
  1 error generated.

The requisite dependency for this include cannot be added, because it
results in a cycle:

  ERROR Dependency cycle:
    //src/platform:platform ->
    //src/protocols/secure_channel:secure_channel ->
    //src/messaging:messaging ->
    //src/platform:platform

Fix the diagnostic so that dependency errors in these files are caught:

  ERROR at //src/include/platform/internal/GenericConfigurationManagerImpl.ipp:38:11: Include not allowed.
  #include <protocols/secure_channel/PASESession.h>
	    ^-------------------------------------
  It is not in any dependency of
    //src/platform:platform
  The include file is in the target(s):
    //src/protocols/secure_channel:secure_channel
  which should somehow be reachable.
@mspang mspang mentioned this pull request Feb 12, 2022
Merged
emargolis added a commit to emargolis/connectedhomeip-1 that referenced this pull request Feb 13, 2022
@emargolis
Fix Dependency Loop Error Introduced with project-chip#14676
35ffbea
emargolis added a commit to emargolis/connectedhomeip-1 that referenced this pull request Feb 16, 2022
@emargolis
Fix Dependency Loop Error Introduced with project-chip#14676
5c33603 
Moved some of the Spake2p defines to the CHIPCryptoPAL.h
emargolis added a commit that referenced this pull request Feb 17, 2022
@emargolis
Fix Dependency Loop Error Introduced with #14676 (#15127)
a80c9f8 
Moved some of the Spake2p defines to the CHIPCryptoPAL.h
@alexhqwang alexhqwang mentioned this pull request Feb 17, 2022
Merged
mspang added a commit to mspang/connectedhomeip that referenced this pull request Feb 18, 2022
@mspang
Fix include checking for src/include/platform/internal/*.cpp
d65b3d6 
Since these .cpp files are included instead of being listed in sources,
they are not processed by the include checker. This has allowed the
introduction of a dependency cycle in

  1e8ed9d ("Updated Device to Get PASE Verifier from Memory. (project-chip#14676)")

which in turn result in the following build flake:

  FAILED: obj/src/platform/Darwin/Darwin.ConfigurationManagerImpl.cpp.o
  g++ -MMD -MF obj/src/platform/Darwin/Darwin.ConfigurationManagerImpl.cpp.o.d -target x86_64-apple-macos10.15 -O0 -g2 -fno-common -ffunction-sections -fdata-sections -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -Wall -Werror -Wextra -Wshadow -Wunreachable-code -Wvla -Wformat -Wformat-nonliteral -Wformat-security -Wno-deprecated-declarations -Wno-unknown-warning-option -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wno-cast-function-type -fno-strict-aliasing -target x86_64-apple-macos10.15 -arch arm64 -arch x86_64 -fobjc-arc -std=gnu++14 -fno-rtti -Wnon-virtual-dtor -DCHIP_HAVE_CONFIG_H=1 -I../../../../../../../../src/include -I../../../../../../../../src -Igen/include -I../../../../../../../../zzz_generated/app-common -I../../../../../../../../config/standalone -I../../../../../../../../third_party/nlassert/repo/include -I../../../../../../../../third_party/nlio/repo/include -I../../../../../../../../third_party/mbedtls/repo/include -c ../../../../../../../../src/platform/Darwin/ConfigurationManagerImpl.cpp -o obj/src/platform/Darwin/Darwin.ConfigurationManagerImpl.cpp.o
  In file included from ../../../../../../../../src/platform/Darwin/ConfigurationManagerImpl.cpp:31:
  In file included from ../../../../../../../../src/include/platform/internal/GenericConfigurationManagerImpl.cpp:38:
  In file included from ../../../../../../../../src/protocols/secure_channel/PASESession.h:34:
  In file included from ../../../../../../../../src/messaging/ExchangeContext.h:31:
  In file included from ../../../../../../../../src/messaging/ExchangeDelegate.h:27:
  In file included from ../../../../../../../../src/messaging/ApplicationExchangeDispatch.h:28:
  In file included from ../../../../../../../../src/messaging/ExchangeMessageDispatch.h:27:
  In file included from ../../../../../../../../src/transport/SessionManager.h:39:
  In file included from ../../../../../../../../src/transport/GroupSession.h:22:
  In file included from ../../../../../../../../src/transport/Session.h:19:
  In file included from ../../../../../../../../src/credentials/FabricTable.h:27:
  In file included from ../../../../../../../../src/credentials/CHIPCert.h:34:
  ../../../../../../../../src/lib/asn1/ASN1.h:30:10: fatal error: 'asn1/ASN1OID.h' file not found
  #include <asn1/ASN1OID.h>
           ^~~~~~~~~~~~~~~~
  1 error generated.

The requisite dependency for this include cannot be added, because it
results in a cycle:

  ERROR Dependency cycle:
    //src/platform:platform ->
    //src/protocols/secure_channel:secure_channel ->
    //src/messaging:messaging ->
    //src/platform:platform

Fix the diagnostic so that dependency errors in these files are caught:

  ERROR at //src/include/platform/internal/GenericConfigurationManagerImpl.ipp:38:11: Include not allowed.
  #include <protocols/secure_channel/PASESession.h>
	    ^-------------------------------------
  It is not in any dependency of
    //src/platform:platform
  The include file is in the target(s):
    //src/protocols/secure_channel:secure_channel
  which should somehow be reachable.
mspang added a commit to mspang/connectedhomeip that referenced this pull request Feb 18, 2022
@mspang
Fix include checking for src/include/platform/internal/*.cpp
aad5e2c 
Since these .cpp files are included instead of being listed in sources,
they are not processed by the include checker. This has allowed the
introduction of a dependency cycle in

  1e8ed9d ("Updated Device to Get PASE Verifier from Memory. (project-chip#14676)")

which in turn result in the following build flake:

  FAILED: obj/src/platform/Darwin/Darwin.ConfigurationManagerImpl.cpp.o
  g++ -MMD -MF obj/src/platform/Darwin/Darwin.ConfigurationManagerImpl.cpp.o.d -target x86_64-apple-macos10.15 -O0 -g2 -fno-common -ffunction-sections -fdata-sections -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -Wall -Werror -Wextra -Wshadow -Wunreachable-code -Wvla -Wformat -Wformat-nonliteral -Wformat-security -Wno-deprecated-declarations -Wno-unknown-warning-option -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wno-cast-function-type -fno-strict-aliasing -target x86_64-apple-macos10.15 -arch arm64 -arch x86_64 -fobjc-arc -std=gnu++14 -fno-rtti -Wnon-virtual-dtor -DCHIP_HAVE_CONFIG_H=1 -I../../../../../../../../src/include -I../../../../../../../../src -Igen/include -I../../../../../../../../zzz_generated/app-common -I../../../../../../../../config/standalone -I../../../../../../../../third_party/nlassert/repo/include -I../../../../../../../../third_party/nlio/repo/include -I../../../../../../../../third_party/mbedtls/repo/include -c ../../../../../../../../src/platform/Darwin/ConfigurationManagerImpl.cpp -o obj/src/platform/Darwin/Darwin.ConfigurationManagerImpl.cpp.o
  In file included from ../../../../../../../../src/platform/Darwin/ConfigurationManagerImpl.cpp:31:
  In file included from ../../../../../../../../src/include/platform/internal/GenericConfigurationManagerImpl.cpp:38:
  In file included from ../../../../../../../../src/protocols/secure_channel/PASESession.h:34:
  In file included from ../../../../../../../../src/messaging/ExchangeContext.h:31:
  In file included from ../../../../../../../../src/messaging/ExchangeDelegate.h:27:
  In file included from ../../../../../../../../src/messaging/ApplicationExchangeDispatch.h:28:
  In file included from ../../../../../../../../src/messaging/ExchangeMessageDispatch.h:27:
  In file included from ../../../../../../../../src/transport/SessionManager.h:39:
  In file included from ../../../../../../../../src/transport/GroupSession.h:22:
  In file included from ../../../../../../../../src/transport/Session.h:19:
  In file included from ../../../../../../../../src/credentials/FabricTable.h:27:
  In file included from ../../../../../../../../src/credentials/CHIPCert.h:34:
  ../../../../../../../../src/lib/asn1/ASN1.h:30:10: fatal error: 'asn1/ASN1OID.h' file not found
  #include <asn1/ASN1OID.h>
           ^~~~~~~~~~~~~~~~
  1 error generated.

The requisite dependency for this include cannot be added, because it
results in a cycle:

  ERROR Dependency cycle:
    //src/platform:platform ->
    //src/protocols/secure_channel:secure_channel ->
    //src/messaging:messaging ->
    //src/platform:platform

Fix the diagnostic so that dependency errors in these files are caught:

  ERROR at //src/include/platform/internal/GenericConfigurationManagerImpl.ipp:38:11: Include not allowed.
  #include <protocols/secure_channel/PASESession.h>
	    ^-------------------------------------
  It is not in any dependency of
    //src/platform:platform
  The include file is in the target(s):
    //src/protocols/secure_channel:secure_channel
  which should somehow be reachable.
@dhrishi dhrishi mentioned this pull request Feb 26, 2022
Closed
mspang added a commit to mspang/connectedhomeip that referenced this pull request Mar 22, 2022
@mspang
Fix include checking for src/include/platform/internal/*.cpp
82e81d9 
Since these .cpp files are included instead of being listed in sources,
they are not processed by the include checker. This has allowed the
introduction of a dependency cycle in

  1e8ed9d ("Updated Device to Get PASE Verifier from Memory. (project-chip#14676)")

which in turn result in the following build flake:

  FAILED: obj/src/platform/Darwin/Darwin.ConfigurationManagerImpl.cpp.o
  g++ -MMD -MF obj/src/platform/Darwin/Darwin.ConfigurationManagerImpl.cpp.o.d -target x86_64-apple-macos10.15 -O0 -g2 -fno-common -ffunction-sections -fdata-sections -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -Wall -Werror -Wextra -Wshadow -Wunreachable-code -Wvla -Wformat -Wformat-nonliteral -Wformat-security -Wno-deprecated-declarations -Wno-unknown-warning-option -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wno-cast-function-type -fno-strict-aliasing -target x86_64-apple-macos10.15 -arch arm64 -arch x86_64 -fobjc-arc -std=gnu++14 -fno-rtti -Wnon-virtual-dtor -DCHIP_HAVE_CONFIG_H=1 -I../../../../../../../../src/include -I../../../../../../../../src -Igen/include -I../../../../../../../../zzz_generated/app-common -I../../../../../../../../config/standalone -I../../../../../../../../third_party/nlassert/repo/include -I../../../../../../../../third_party/nlio/repo/include -I../../../../../../../../third_party/mbedtls/repo/include -c ../../../../../../../../src/platform/Darwin/ConfigurationManagerImpl.cpp -o obj/src/platform/Darwin/Darwin.ConfigurationManagerImpl.cpp.o
  In file included from ../../../../../../../../src/platform/Darwin/ConfigurationManagerImpl.cpp:31:
  In file included from ../../../../../../../../src/include/platform/internal/GenericConfigurationManagerImpl.cpp:38:
  In file included from ../../../../../../../../src/protocols/secure_channel/PASESession.h:34:
  In file included from ../../../../../../../../src/messaging/ExchangeContext.h:31:
  In file included from ../../../../../../../../src/messaging/ExchangeDelegate.h:27:
  In file included from ../../../../../../../../src/messaging/ApplicationExchangeDispatch.h:28:
  In file included from ../../../../../../../../src/messaging/ExchangeMessageDispatch.h:27:
  In file included from ../../../../../../../../src/transport/SessionManager.h:39:
  In file included from ../../../../../../../../src/transport/GroupSession.h:22:
  In file included from ../../../../../../../../src/transport/Session.h:19:
  In file included from ../../../../../../../../src/credentials/FabricTable.h:27:
  In file included from ../../../../../../../../src/credentials/CHIPCert.h:34:
  ../../../../../../../../src/lib/asn1/ASN1.h:30:10: fatal error: 'asn1/ASN1OID.h' file not found
  #include <asn1/ASN1OID.h>
           ^~~~~~~~~~~~~~~~
  1 error generated.

The requisite dependency for this include cannot be added, because it
results in a cycle:

  ERROR Dependency cycle:
    //src/platform:platform ->
    //src/protocols/secure_channel:secure_channel ->
    //src/messaging:messaging ->
    //src/platform:platform

Fix the diagnostic so that dependency errors in these files are caught:

  ERROR at //src/include/platform/internal/GenericConfigurationManagerImpl.ipp:38:11: Include not allowed.
  #include <protocols/secure_channel/PASESession.h>
	    ^-------------------------------------
  It is not in any dependency of
    //src/platform:platform
  The include file is in the target(s):
    //src/protocols/secure_channel:secure_channel
  which should somehow be reachable.
andy31415 pushed a commit that referenced this pull request Mar 22, 2022
@mspang
Fix include checking for src/include/platform/internal/*.cpp (#15121)
feb81b6 
Since these .cpp files are included instead of being listed in sources,
they are not processed by the include checker. This has allowed the
introduction of a dependency cycle in

  1e8ed9d ("Updated Device to Get PASE Verifier from Memory. (#14676)")

which in turn result in the following build flake:

  FAILED: obj/src/platform/Darwin/Darwin.ConfigurationManagerImpl.cpp.o
  g++ -MMD -MF obj/src/platform/Darwin/Darwin.ConfigurationManagerImpl.cpp.o.d -target x86_64-apple-macos10.15 -O0 -g2 -fno-common -ffunction-sections -fdata-sections -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -Wall -Werror -Wextra -Wshadow -Wunreachable-code -Wvla -Wformat -Wformat-nonliteral -Wformat-security -Wno-deprecated-declarations -Wno-unknown-warning-option -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wno-cast-function-type -fno-strict-aliasing -target x86_64-apple-macos10.15 -arch arm64 -arch x86_64 -fobjc-arc -std=gnu++14 -fno-rtti -Wnon-virtual-dtor -DCHIP_HAVE_CONFIG_H=1 -I../../../../../../../../src/include -I../../../../../../../../src -Igen/include -I../../../../../../../../zzz_generated/app-common -I../../../../../../../../config/standalone -I../../../../../../../../third_party/nlassert/repo/include -I../../../../../../../../third_party/nlio/repo/include -I../../../../../../../../third_party/mbedtls/repo/include -c ../../../../../../../../src/platform/Darwin/ConfigurationManagerImpl.cpp -o obj/src/platform/Darwin/Darwin.ConfigurationManagerImpl.cpp.o
  In file included from ../../../../../../../../src/platform/Darwin/ConfigurationManagerImpl.cpp:31:
  In file included from ../../../../../../../../src/include/platform/internal/GenericConfigurationManagerImpl.cpp:38:
  In file included from ../../../../../../../../src/protocols/secure_channel/PASESession.h:34:
  In file included from ../../../../../../../../src/messaging/ExchangeContext.h:31:
  In file included from ../../../../../../../../src/messaging/ExchangeDelegate.h:27:
  In file included from ../../../../../../../../src/messaging/ApplicationExchangeDispatch.h:28:
  In file included from ../../../../../../../../src/messaging/ExchangeMessageDispatch.h:27:
  In file included from ../../../../../../../../src/transport/SessionManager.h:39:
  In file included from ../../../../../../../../src/transport/GroupSession.h:22:
  In file included from ../../../../../../../../src/transport/Session.h:19:
  In file included from ../../../../../../../../src/credentials/FabricTable.h:27:
  In file included from ../../../../../../../../src/credentials/CHIPCert.h:34:
  ../../../../../../../../src/lib/asn1/ASN1.h:30:10: fatal error: 'asn1/ASN1OID.h' file not found
  #include <asn1/ASN1OID.h>
           ^~~~~~~~~~~~~~~~
  1 error generated.

The requisite dependency for this include cannot be added, because it
results in a cycle:

  ERROR Dependency cycle:
    //src/platform:platform ->
    //src/protocols/secure_channel:secure_channel ->
    //src/messaging:messaging ->
    //src/platform:platform

Fix the diagnostic so that dependency errors in these files are caught:

  ERROR at //src/include/platform/internal/GenericConfigurationManagerImpl.ipp:38:11: Include not allowed.
  #include <protocols/secure_channel/PASESession.h>
	    ^-------------------------------------
  It is not in any dependency of
    //src/platform:platform
  The include file is in the target(s):
    //src/protocols/secure_channel:secure_channel
  which should somehow be reachable.
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@mspang @andrei-menzopol
Fix include checking for src/include/platform/internal/*.cpp (project…
9f15fda 
…-chip#15121)

Since these .cpp files are included instead of being listed in sources,
they are not processed by the include checker. This has allowed the
introduction of a dependency cycle in

  1e8ed9d ("Updated Device to Get PASE Verifier from Memory. (project-chip#14676)")

which in turn result in the following build flake:

  FAILED: obj/src/platform/Darwin/Darwin.ConfigurationManagerImpl.cpp.o
  g++ -MMD -MF obj/src/platform/Darwin/Darwin.ConfigurationManagerImpl.cpp.o.d -target x86_64-apple-macos10.15 -O0 -g2 -fno-common -ffunction-sections -fdata-sections -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -Wall -Werror -Wextra -Wshadow -Wunreachable-code -Wvla -Wformat -Wformat-nonliteral -Wformat-security -Wno-deprecated-declarations -Wno-unknown-warning-option -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wno-cast-function-type -fno-strict-aliasing -target x86_64-apple-macos10.15 -arch arm64 -arch x86_64 -fobjc-arc -std=gnu++14 -fno-rtti -Wnon-virtual-dtor -DCHIP_HAVE_CONFIG_H=1 -I../../../../../../../../src/include -I../../../../../../../../src -Igen/include -I../../../../../../../../zzz_generated/app-common -I../../../../../../../../config/standalone -I../../../../../../../../third_party/nlassert/repo/include -I../../../../../../../../third_party/nlio/repo/include -I../../../../../../../../third_party/mbedtls/repo/include -c ../../../../../../../../src/platform/Darwin/ConfigurationManagerImpl.cpp -o obj/src/platform/Darwin/Darwin.ConfigurationManagerImpl.cpp.o
  In file included from ../../../../../../../../src/platform/Darwin/ConfigurationManagerImpl.cpp:31:
  In file included from ../../../../../../../../src/include/platform/internal/GenericConfigurationManagerImpl.cpp:38:
  In file included from ../../../../../../../../src/protocols/secure_channel/PASESession.h:34:
  In file included from ../../../../../../../../src/messaging/ExchangeContext.h:31:
  In file included from ../../../../../../../../src/messaging/ExchangeDelegate.h:27:
  In file included from ../../../../../../../../src/messaging/ApplicationExchangeDispatch.h:28:
  In file included from ../../../../../../../../src/messaging/ExchangeMessageDispatch.h:27:
  In file included from ../../../../../../../../src/transport/SessionManager.h:39:
  In file included from ../../../../../../../../src/transport/GroupSession.h:22:
  In file included from ../../../../../../../../src/transport/Session.h:19:
  In file included from ../../../../../../../../src/credentials/FabricTable.h:27:
  In file included from ../../../../../../../../src/credentials/CHIPCert.h:34:
  ../../../../../../../../src/lib/asn1/ASN1.h:30:10: fatal error: 'asn1/ASN1OID.h' file not found
  #include <asn1/ASN1OID.h>
           ^~~~~~~~~~~~~~~~
  1 error generated.

The requisite dependency for this include cannot be added, because it
results in a cycle:

  ERROR Dependency cycle:
    //src/platform:platform ->
    //src/protocols/secure_channel:secure_channel ->
    //src/messaging:messaging ->
    //src/platform:platform

Fix the diagnostic so that dependency errors in these files are caught:

  ERROR at //src/include/platform/internal/GenericConfigurationManagerImpl.ipp:38:11: Include not allowed.
  #include <protocols/secure_channel/PASESession.h>
	    ^-------------------------------------
  It is not in any dependency of
    //src/platform:platform
  The include file is in the target(s):
    //src/protocols/secure_channel:secure_channel
  which should somehow be reachable.
jamesluo11 pushed a commit to jamesluo11/connectedhomeip that referenced this pull request Apr 26, 2022
@emargolis @fuxingguo16
Fix Dependency Loop Error Introduced with project-chip#14676 (project…
f858901 
…-chip#15127)

Moved some of the Spake2p defines to the CHIPCryptoPAL.h
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@msandstedt msandstedt msandstedt approved these changes

@woody-apple woody-apple woody-apple approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@lazarkov lazarkov Awaiting requested review from lazarkov

Assignees
No one assigned
Labels
app config controller esp32 platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid computing PBKDF on the commissionee
5 participants
@emargolis @woody-apple @tcarmelveilleux @msandstedt @bzbarsky-apple