[ble] Remove CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PRO…

…VISIONED (#21582) * [zephyr] Remove usage of IsFullyProvisioned() in BLE manager If CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED is set, which turns out to be true on Zephyr, NXP and, conditionally, ESP32 platforms, the BLE manager will not start BLE advertising if IsFullyProvisioned() method of the ConnectivityManager class returns true. The problem is that the method seems obsolete and the proper logic is already in place in Server.cpp, so we should align the platforms and remove the legacy code. Signed-off-by: Damian Krolik <[email protected]> * Remove CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED Remove CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED and the associated code from platforms that never set it. Signed-off-by: Damian Krolik <[email protected]> * Remove CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED from K32 Signed-off-by: Damian Krolik <[email protected]> * Restyled by clang-format * Remove CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED from ESP32 Co-authored-by: Restyled.io <[email protected]>
project-chip · Sep 11, 2023 · 2602770 · 2602770
1 parent 0fbbfcc
commit 2602770
Show file tree

Hide file tree

Showing 20 changed files with 0 additions and 276 deletions.
diff --git a/config/esp32/components/chip/Kconfig b/config/esp32/components/chip/Kconfig
@@ -502,14 +502,6 @@ menu "CHIP Device Layer"
 
  When set, WoBLE advertisements will stop while a WoBLE connection is active.
 
- config CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED
- bool "Disable Advertising when Provisioned"
- default n
- depends on ENABLE_CHIPOBLE
- help
- Automatically disable CHIP-over-BLE (WoBLE) advertising when the device transitions
- to a fully provisioned state.
-
  config DEINIT_BLE_ON_COMMISSIONING_COMPLETE
  bool "Disable and DeInit BLE on commissioning complete"
  default y

diff --git a/config/zephyr/Kconfig b/config/zephyr/Kconfig
@@ -104,12 +104,6 @@ config CHIP_BUILD_TESTS
  help
  This option enables building CHIP unit tests.
 
-config CHIP_DISABLE_CHIPOBLE_ADVERTISING_WHEN_PROVISIONED
- bool "Disable CHIPoBLE advertising when device is fully provisioned"
- default y
- help
- Disable CHIPoBLE advertising when the device achieves a fully provisioned state.
-
 config CHIP_ENABLE_PAIRING_AUTOSTART
  bool "Enable pairing autostart"
  default n

diff --git a/src/include/platform/CHIPDeviceConfig.h b/src/include/platform/CHIPDeviceConfig.h
@@ -457,16 +457,6 @@
 #define CHIP_DEVICE_CONFIG_CHIPOBLE_SINGLE_CONNECTION 1
 #endif
 
-/**
- * CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED
- *
- * Automatically disable CHIPoBLE advertising when the device transitions to a fully
- * provisioned state.
- */
-#ifndef CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED
-#define CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED 0
-#endif
-
 /**
  * CHIP_DEVICE_CONFIG_CHIPOBLE_ENABLE_ADVERTISING_AUTOSTART
  *

diff --git a/src/platform/Ameba/BLEManagerImpl.cpp b/src/platform/Ameba/BLEManagerImpl.cpp
@@ -485,15 +485,6 @@ void BLEManagerImpl::_OnPlatformEvent(const ChipDeviceEvent * event)
 
  case DeviceEventType::kServiceProvisioningChange:
  case DeviceEventType::kWiFiConnectivityChange:
-// If CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED is enabled, when there is a change to the device's provisioning state and device
-// is now fully provisioned, the CHIPoBLE advertising will be disabled.
-#if CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED
- if (ConfigurationMgr().IsFullyProvisioned())
- {
- mFlags.Clear(Flags::kAdvertisingEnabled);
- ChipLogProgress(DeviceLayer, "CHIPoBLE advertising disabled because device is fully provisioned");
- }
-#endif // CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED
  ChipLogProgress(DeviceLayer, "Updating advertising data");
  mFlags.Clear(Flags::kAdvertisingConfigured);
  mFlags.Set(Flags::kRestartAdvertising);
@@ -731,16 +722,6 @@ void BLEManagerImpl::DriveBLEState(void)
  // Check if BLE stack is initialized
  VerifyOrExit(mFlags.Has(Flags::kAMEBABLEStackInitialized), /* */);
 
-// If CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED is enabled and the device is fully provisioned, the CHIPoBLE
-// advertising will be disabled.
-#if CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED
- if (ConfigurationMgr().IsFullyProvisioned())
- {
- mFlags.Clear(Flags::kAdvertisingEnabled);
- ChipLogProgress(DeviceLayer, "CHIPoBLE advertising disabled because device is fully provisioned");
- }
-#endif // CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED
-
  // Start advertising if needed...
  if (mServiceMode == ConnectivityManager::kCHIPoBLEServiceMode_Enabled && mFlags.Has(Flags::kAdvertisingEnabled))
  {

diff --git a/src/platform/CYW30739/BLEManagerImpl.cpp b/src/platform/CYW30739/BLEManagerImpl.cpp
@@ -226,17 +226,6 @@ void BLEManagerImpl::_OnPlatformEvent(const ChipDeviceEvent * event)
  break;
 
  case DeviceEventType::kServiceProvisioningChange:
- // If CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED is enabled, and there is a change to the
- // device's provisioning state, then automatically disable CHIPoBLE advertising if the device
- // is now fully provisioned.
-#if CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED
- if (ConfigurationMgr().IsFullyProvisioned())
- {
- ClearFlag(mFlags, kFlag_AdvertisingEnabled);
- ChipLogProgress(DeviceLayer, "CHIPoBLE advertising disabled because device is fully provisioned");
- }
-#endif // CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED
-
  // Force the advertising state to be refreshed to reflect new provisioning state.
  mFlags.Set(Flags::kFlag_AdvertisingRefreshNeeded, true);
 
@@ -347,16 +336,6 @@ void BLEManagerImpl::DriveBLEState(void)
  if (!mFlags.Has(Flags::kFlag_AsyncInitCompleted))
  {
  mFlags.Set(Flags::kFlag_AsyncInitCompleted, true);
-
- // If CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED is enabled,
- // disable CHIPoBLE advertising if the device is fully provisioned.
-#if CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED
- if (ConfigurationMgr().IsFullyProvisioned())
- {
- ClearFlag(mFlags, kFlag_AdvertisingEnabled);
- ChipLogProgress(DeviceLayer, "CHIPoBLE advertising disabled because device is fully provisioned");
- }
-#endif // CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED
  }
 
  // If the application has enabled CHIPoBLE and BLE advertising...

diff --git a/src/platform/ESP32/CHIPDevicePlatformConfig.h b/src/platform/ESP32/CHIPDevicePlatformConfig.h
@@ -77,7 +77,6 @@
 #define CHIP_DEVICE_CONFIG_BLE_SLOW_ADVERTISING_INTERVAL_MIN CONFIG_BLE_SLOW_ADVERTISING_INTERVAL_MIN
 #define CHIP_DEVICE_CONFIG_BLE_SLOW_ADVERTISING_INTERVAL_MAX CONFIG_BLE_SLOW_ADVERTISING_INTERVAL_MAX
 #define CHIP_DEVICE_CONFIG_CHIPOBLE_SINGLE_CONNECTION CONFIG_CHIPOBLE_SINGLE_CONNECTION
-#define CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED
 #define CHIP_DEVICE_CONFIG_ENABLE_CHIP_TIME_SERVICE_TIME_SYNC CONFIG_ENABLE_CHIP_TIME_SERVICE_TIME_SYNC
 #define CHIP_DEVICE_CONFIG_CHIP_TIME_SERVICE_ENDPOINT_ID CONFIG_CHIP_TIME_SERVICE_ENDPOINT_ID
 #define CHIP_DEVICE_CONFIG_DEFAULT_TIME_SYNC_INTERVAL CONFIG_DEFAULT_TIME_SYNC_INTERVAL

diff --git a/src/platform/ESP32/bluedroid/BLEManagerImpl.cpp b/src/platform/ESP32/bluedroid/BLEManagerImpl.cpp
@@ -271,17 +271,6 @@ void BLEManagerImpl::_OnPlatformEvent(const ChipDeviceEvent * event)
 
  case DeviceEventType::kServiceProvisioningChange:
  case DeviceEventType::kWiFiConnectivityChange:
- // If CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED is enabled, and there is a change to the
- // device's provisioning state, then automatically disable CHIPoBLE advertising if the device
- // is now fully provisioned.
-#if CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED
- if (ConfigurationMgr().IsFullyProvisioned())
- {
- mFlags.Clear(Flags::kAdvertisingEnabled);
- ChipLogProgress(DeviceLayer, "CHIPoBLE advertising disabled because device is fully provisioned");
- }
-#endif // CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED
-
  // Force the advertising configuration to be refreshed to reflect new provisioning state.
  ChipLogProgress(DeviceLayer, "Updating advertising data");
  mFlags.Clear(Flags::kAdvertisingConfigured);
@@ -416,16 +405,6 @@ void BLEManagerImpl::DriveBLEState(void)
  if (!mFlags.Has(Flags::kAsyncInitCompleted))
  {
  mFlags.Set(Flags::kAsyncInitCompleted);
-
- // If CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED is enabled,
- // disable CHIPoBLE advertising if the device is fully provisioned.
-#if CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED
- if (ConfigurationMgr().IsFullyProvisioned())
- {
- mFlags.Clear(Flags::kAdvertisingEnabled);
- ChipLogProgress(DeviceLayer, "CHIPoBLE advertising disabled because device is fully provisioned");
- }
-#endif // CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED
  }
 
  // If there's already a control operation in progress, wait until it completes.

diff --git a/src/platform/ESP32/nimble/BLEManagerImpl.cpp b/src/platform/ESP32/nimble/BLEManagerImpl.cpp
@@ -284,17 +284,6 @@ void BLEManagerImpl::_OnPlatformEvent(const ChipDeviceEvent * event)
 
  case DeviceEventType::kServiceProvisioningChange:
  case DeviceEventType::kWiFiConnectivityChange:
- // If CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED is enabled, and there is a change to the
- // device's provisioning state, then automatically disable CHIPoBLE advertising if the device
- // is now fully provisioned.
-#if CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED
- if (ConfigurationMgr().IsFullyProvisioned())
- {
- mFlags.Clear(Flags::kAdvertisingEnabled);
- ChipLogProgress(DeviceLayer, "CHIPoBLE advertising disabled because device is fully provisioned");
- }
-#endif // CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED
-
  // Force the advertising configuration to be refreshed to reflect new provisioning state.
  ChipLogProgress(DeviceLayer, "Updating advertising data");
  mFlags.Clear(Flags::kAdvertisingConfigured);
@@ -440,16 +429,6 @@ void BLEManagerImpl::DriveBLEState(void)
  if (!mFlags.Has(Flags::kAsyncInitCompleted))
  {
  mFlags.Set(Flags::kAsyncInitCompleted);
-
- // If CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED is enabled,
- // disable CHIPoBLE advertising if the device is fully provisioned.
-#if CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED
- if (ConfigurationMgr().IsFullyProvisioned())
- {
- mFlags.Clear(Flags::kAdvertisingEnabled);
- ChipLogProgress(DeviceLayer, "CHIPoBLE advertising disabled because device is fully provisioned");
- }
-#endif // CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED
  }
 
  // Initializes the ESP BLE layer if needed.

diff --git a/src/platform/Linux/BLEManagerImpl.cpp b/src/platform/Linux/BLEManagerImpl.cpp
@@ -233,17 +233,6 @@ void BLEManagerImpl::_OnPlatformEvent(const ChipDeviceEvent * event)
  HandleConnectionError(event->CHIPoBLEConnectionError.ConId, event->CHIPoBLEConnectionError.Reason);
  break;
  case DeviceEventType::kServiceProvisioningChange:
- // If CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED is enabled, and there is a change to the
- // device's provisioning state, then automatically disable CHIPoBLE advertising if the device
- // is now fully provisioned.
-#if CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED
- if (ConfigurationMgr().IsFullyProvisioned())
- {
- mFlags.Clear(Flags::kAdvertisingEnabled);
- ChipLogProgress(DeviceLayer, "CHIPoBLE advertising disabled because device is fully provisioned");
- }
-#endif // CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED
-
  // Force the advertising configuration to be refreshed to reflect new provisioning state.
  mFlags.Clear(Flags::kAdvertisingConfigured);
 
@@ -563,16 +552,6 @@ void BLEManagerImpl::DriveBLEState()
  if (!mFlags.Has(Flags::kAsyncInitCompleted))
  {
  mFlags.Set(Flags::kAsyncInitCompleted);
-
- // If CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED is enabled,
- // disable CHIPoBLE advertising if the device is fully provisioned.
-#if CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED
- if (ConfigurationMgr().IsFullyProvisioned())
- {
- mFlags.Clear(Flags::kAdvertisingEnabled);
- ChipLogProgress(DeviceLayer, "CHIPoBLE advertising disabled because device is fully provisioned");
- }
-#endif // CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED
  ExitNow();
  }
 

diff --git a/src/platform/P6/BLEManagerImpl.cpp b/src/platform/P6/BLEManagerImpl.cpp
@@ -266,17 +266,6 @@ void BLEManagerImpl::_OnPlatformEvent(const ChipDeviceEvent * event)
  break;
 
  case DeviceEventType::kServiceProvisioningChange:
- // If CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED is enabled, and there is a change to the
- // device's provisioning state, then automatically disable CHIPoBLE advertising if the device
- // is now fully provisioned.
-#if CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED
- if (ConfigurationMgr().IsFullyProvisioned())
- {
- ClearFlag(mFlags, kFlag_AdvertisingEnabled);
- ChipLogProgress(DeviceLayer, "CHIPoBLE advertising disabled because device is fully provisioned");
- }
-#endif // CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED
-
  // Force the advertising state to be refreshed to reflect new provisioning state.
  mFlags.Set(Flags::kFlag_AdvertisingRefreshNeeded, true);
 
@@ -401,16 +390,6 @@ void BLEManagerImpl::DriveBLEState(void)
  if (!mFlags.Has(Flags::kFlag_AsyncInitCompleted))
  {
  mFlags.Set(Flags::kFlag_AsyncInitCompleted, true);
-
- // If CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED is enabled,
- // disable CHIPoBLE advertising if the device is fully provisioned.
-#if CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED
- if (ConfigurationMgr().IsFullyProvisioned())
- {
- ClearFlag(mFlags, kFlag_AdvertisingEnabled);
- ChipLogProgress(DeviceLayer, "CHIPoBLE advertising disabled because device is fully provisioned");
- }
-#endif // CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED
  }
 
  // If the application has enabled CHIPoBLE and BLE advertising...

diff --git a/src/platform/Zephyr/BLEManagerImpl.cpp b/src/platform/Zephyr/BLEManagerImpl.cpp
@@ -175,16 +175,6 @@ void BLEManagerImpl::DriveBLEState()
  if (!mFlags.Has(Flags::kAsyncInitCompleted))
  {
  mFlags.Set(Flags::kAsyncInitCompleted);
-
- // If CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED is enabled,
- // disable CHIPoBLE advertising if the device is fully provisioned.
-#if CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED
- if (ConfigurationMgr().IsFullyProvisioned())
- {
- mFlags.Clear(Flags::kAdvertisingEnabled);
- ChipLogProgress(DeviceLayer, "CHIPoBLE advertising disabled because device is fully provisioned");
- }
-#endif // CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED
  }
 
  // If the application has enabled CHIPoBLE and BLE advertising...
@@ -606,25 +596,6 @@ void BLEManagerImpl::_OnPlatformEvent(const ChipDeviceEvent * event)
  err = HandleTXCharComplete(event);
  break;
 
- case DeviceEventType::kServiceProvisioningChange:
- // If CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED is enabled, and there is a change to the
- // device's provisioning state, then automatically disable CHIPoBLE advertising if the device
- // is now fully provisioned.
-#if CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED
- if (ConfigurationMgr().IsFullyProvisioned())
- {
- mFlags.Clear(Flags::kAdvertisingEnabled);
- ChipLogProgress(DeviceLayer, "CHIPoBLE advertising disabled because device is fully provisioned");
- }
-#endif // CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED
-
- // Force the advertising state to be refreshed to reflect new provisioning state.
- mFlags.Set(Flags::kAdvertisingRefreshNeeded);
-
- DriveBLEState();
-
- break;
-
  default:
  break;
  }

diff --git a/src/platform/Zephyr/CHIPDevicePlatformConfig.h b/src/platform/Zephyr/CHIPDevicePlatformConfig.h
@@ -95,8 +95,6 @@
 #define CHIP_DEVICE_CONFIG_ENABLE_THREAD_TELEMETRY_FULL 0
 #define CHIP_DEVICE_CONFIG_LOG_PROVISIONING_HASH 0
 
-#define CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED CONFIG_CHIP_DISABLE_CHIPOBLE_ADVERTISING_WHEN_PROVISIONED
-
 #define CHIP_DEVICE_CONFIG_CHIPOBLE_ENABLE_ADVERTISING_AUTOSTART 0
 
 #ifndef CONFIG_CHIP_ENABLE_PAIRING_AUTOSTART

diff --git a/src/platform/bouffalolab/BL602/BLEManagerImpl.cpp b/src/platform/bouffalolab/BL602/BLEManagerImpl.cpp
@@ -206,16 +206,6 @@ void BLEManagerImpl::DriveBLEState()
  if (!mFlags.Has(Flags::kAsyncInitCompleted))
  {
  mFlags.Set(Flags::kAsyncInitCompleted);
-
- // If CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED is enabled,
- // disable CHIPoBLE advertising if the device is fully provisioned.
-#if CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED
- if (ConfigurationMgr().IsFullyProvisioned())
- {
- mFlags.Clear(Flags::kAdvertisingEnabled);
- ChipLogProgress(DeviceLayer, "CHIPoBLE advertising disabled because device is fully provisioned");
- }
-#endif // CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED
  }
 
  // If the application has enabled CHIPoBLE and BLE advertising...
@@ -582,17 +572,6 @@ void BLEManagerImpl::_OnPlatformEvent(const ChipDeviceEvent * event)
  break;
 
  case DeviceEventType::kServiceProvisioningChange:
- // If CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED is enabled, and there is a change to the
- // device's provisioning state, then automatically disable CHIPoBLE advertising if the device
- // is now fully provisioned.
-#if CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED
- if (ConfigurationMgr().IsFullyProvisioned())
- {
- mFlags.Clear(Flags::kAdvertisingEnabled);
- ChipLogProgress(DeviceLayer, "CHIPoBLE advertising disabled because device is fully provisioned");
- }
-#endif // CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED
-
  // Force the advertising state to be refreshed to reflect new provisioning state.
  mFlags.Set(Flags::kAdvertisingRefreshNeeded);
 

diff --git a/src/platform/mbed/BLEManagerImpl.cpp b/src/platform/mbed/BLEManagerImpl.cpp
@@ -666,16 +666,6 @@ void BLEManagerImpl::DriveBLEState()
  if (!mFlags.Has(kFlag_AsyncInitCompleted))
  {
  mFlags.Set(kFlag_AsyncInitCompleted);
-
- // If CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED is enabled,
- // disable CHIPoBLE advertising if the device is fully provisioned.
-#if CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED
- if (ConfigurationMgr().IsFullyProvisioned())
- {
- mFlags.Clear(kFlag_AdvertisingEnabled);
- ChipLogProgress(DeviceLayer, "CHIPoBLE advertising disabled because device is fully provisioned");
- }
-#endif // CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED
  }
 
  // If the application has enabled CHIPoBLE and BLE advertising...

diff --git a/src/platform/nrfconnect/CHIPDevicePlatformConfig.h b/src/platform/nrfconnect/CHIPDevicePlatformConfig.h
@@ -191,8 +191,6 @@
 #define CHIP_DEVICE_CONFIG_ENABLE_THREAD_TELEMETRY_FULL 0
 #define CHIP_DEVICE_CONFIG_LOG_PROVISIONING_HASH 0
 
-#define CHIP_DEVICE_CONFIG_CHIPOBLE_DISABLE_ADVERTISING_WHEN_PROVISIONED CONFIG_CHIP_DISABLE_CHIPOBLE_ADVERTISING_WHEN_PROVISIONED
-
 #define CHIP_DEVICE_CONFIG_CHIPOBLE_ENABLE_ADVERTISING_AUTOSTART 0
 
 #ifndef CONFIG_CHIP_ENABLE_PAIRING_AUTOSTART