Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Features: 增加hover显示时换行 #69

Merged
merged 4 commits into from
Aug 4, 2024

Conversation

IOLOII
Copy link
Contributor

@IOLOII IOLOII commented May 9, 2024

No description provided.

@IOLOII
Copy link
Contributor Author

IOLOII commented May 9, 2024

当少量拼接单词时hover的效果

image

下方多词解析时模板字符串待后续完善

image

@nobodxbodon
Copy link
Member

请问此pr还有后续commit补充吗?另外请清理注释掉的代码段并格式化代码。

Copy link
Contributor Author

@IOLOII IOLOII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
这里的“格式化”,是因为需要使用这样的格式才能换行的效果。使用的是模版字符串 👉``👈

@IOLOII
Copy link
Contributor Author

IOLOII commented May 26, 2024

请问此pr还有后续commit补充吗?另外请清理注释掉的代码段并格式化代码。

最近有点忙,注释掉的代码中,TODO是对后续优化的预留代码,与一些提示和注意的事项

等忙过去,我再看下

已按要求删除多余代码
@nobodxbodon
Copy link
Member

好,完成后麻烦说一声,会尽快看。谢谢。

@nobodxbodon
Copy link
Member

挺奇妙的,两个词的短语可以分行(看起来第一个词的字体更大?),但超过两词就会把第一个词和其他分开两行。

@IOLOII
Copy link
Contributor Author

IOLOII commented Aug 4, 2024

挺奇妙的,两个词的短语可以分行(看起来第一个词的字体更大?),但超过两词就会把第一个词和其他分开两行。

@nobodxbodon 刚看见你的留言,正好忙完,然后看了下之前的问题,已经调整更新了

Copy link
Contributor Author

@IOLOII IOLOII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@nobodxbodon
Copy link
Member

看起来效果不错,代码也挺好。合并中。
圆满完成,十分感谢!

@nobodxbodon nobodxbodon merged commit 5254a71 into program-in-chinese:master Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants