Fixing callbacks in preload() #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ah oops, now I see why it said arguments in there. thank you for the patch! |
lmccart
pushed a commit
that referenced
this pull request
Oct 10, 2015
Fixing callbacks in preload()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lmccart thank you for refactoring the
_getDecrementPreloadfunction to use.apply()instead of passing this, much more elegant! In order to work though each call has to use.apply()and all arguments. Using.call()and just parameters in the function declaration, cuts outdecrementPreload()if a success callback is passed in, which was the same original problem with success callbacks inpreload(). Using.apply(this, arguments)fixes this problem.I also added a test.json file for the example, because the weather rest service that is used in various examples now requires an API key to use.
Thanks!