Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add uTint vector to phong shader and use it to calculate gl_FragColor #4537

Merged
merged 1 commit into from
May 11, 2020
Merged

[WIP] Add uTint vector to phong shader and use it to calculate gl_FragColor #4537

merged 1 commit into from
May 11, 2020

Conversation

matvs
Copy link
Contributor

@matvs matvs commented May 11, 2020 •
edited
Loading

Resolves #4515

Changes:
uTint support was added to phong shader.

Before:
#4515 - before

After:
#4515 - after

  • npm run lint passes

@matvs matvs changed the title Add uTint vector to phong shader and use it to calculate gl_FragColor [WIP] Add uTint vector to phong shader and use it to calculate gl_FragColor May 11, 2020
@stalgiag
Copy link
Contributor

This looks great! Thank you for the fix @matvs

@all-contributors please add @matvs for code and bug fix

@stalgiag stalgiag merged commit 3496d92 into processing:master May 11, 2020
@allcontributors allcontributors bot mentioned this pull request May 11, 2020
Merged
@allcontributors
Copy link
Contributor

@stalgiag

I've put up a pull request to add @matvs! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tint() is not working in WEBGL mode (version 1.0.0)
2 participants
@matvs @stalgiag