Skip to content
This repository has been archived by the owner on May 20, 2023. It is now read-only.

Add ability to ignore issues with an assignee #172

Merged
merged 2 commits into from
Dec 17, 2018

Conversation

christianbundy
Copy link
Contributor

@christianbundy christianbundy commented Nov 5, 2018

This gives maintainers the ability to assign themselves (or someone else) to keep an issue being marked as stale. My hope is that this will let individual maintainers take responsibility for issues which would otherwise be marked as stale. Heavily influenced by #88. Thanks for your work on this project!


View rendered README.md

Copy link

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd love to have this at github/linguist!

@christianbundy I think you'll need to add tests in test/schema.test.js (and maybe test/stale.test.js).

@christianbundy
Copy link
Contributor Author

Thanks for the quick review @pchaigno! I've just added some tests, please let me know if there's any other test coverage you think would be appropriate. Happy to hear Linguist is using Stale, I've always had great experiences on that repo. ❤️

@pchaigno
Copy link

pchaigno commented Nov 6, 2018

I've always had great experiences on that repo

Great to hear!

@christianbundy
Copy link
Contributor Author

Anything I can do to help this along? I'd really love to use this to keep some issues from becoming stale.

@christianbundy
Copy link
Contributor Author

Sorry to bother you, but I'd really love to get feedback on this before stale[bot] marks everything as stale again. Please let me know if you need any information or changes from me. Thanks! ✨

cc: @pchaigno @hiimbex @bkeepers

Copy link
Member

@JasonEtco JasonEtco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @christianbundy - and thank you for your patience 🙏

@JasonEtco JasonEtco merged commit 5843b68 into probot:master Dec 17, 2018
@christianbundy
Copy link
Contributor Author

Thanks a lot! Looking forward to using this.

@pchaigno
Copy link

pchaigno commented Dec 18, 2018

I'm noticing this a bit late, but shouldn't it be exemptAssigned rather than exemptAssignees?

pchaigno added a commit to pchaigno/linguist that referenced this pull request Dec 18, 2018
pchaigno added a commit to github-linguist/linguist that referenced this pull request Dec 18, 2018
@christianbundy
Copy link
Contributor Author

@pchaigno

Feel free to change it if you'd like, I followed the pattern of exemptMilestones and exemptProjects when I chose exemptAssignees, but I don't have any strong feelings either way. 👍

@pchaigno
Copy link

@JasonEtco When will this take effect on GitHub? If it's not in effect yet, I'll open a pull request.

@christianbundy
Copy link
Contributor Author

@pchaigno It's already working, check out my test!

@pchaigno
Copy link

Nice! Let's keep it that way then.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants