Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix workflow files #711

Merged
merged 2 commits into from
Jan 16, 2023
Merged

fix workflow files #711

merged 2 commits into from
Jan 16, 2023

Conversation

ismael-mendoza
Copy link
Collaborator

@ismael-mendoza ismael-mendoza commented Jan 16, 2023

Closes #710

@ismael-mendoza ismael-mendoza self-assigned this Jan 16, 2023
@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Merging #711 (006aa4e) into master (ba5b864) will not change coverage.
The diff coverage is n/a.

❗ Current head 006aa4e differs from pull request most recent head 206f142. Consider uploading reports for the commit 206f142 to get more accurate results

@@           Coverage Diff           @@
##           master     #711   +/-   ##
=======================================
  Coverage   84.72%   84.72%           
=======================================
  Files          27       27           
  Lines        3817     3817           
=======================================
  Hits         3234     3234           
  Misses        583      583           
Flag Coverage Δ
unittests 84.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ismael-mendoza ismael-mendoza merged commit 2713112 into master Jan 16, 2023
@ismael-mendoza ismael-mendoza deleted the u/im/fix-doc-workflow branch January 16, 2023 22:40
- name: Checkout LFS objects
run: git lfs checkout
- name: Install poetry
run: pipx install poetry
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching to pipx here seems to have broken the night case studies job. Error message:

Error: Unable to locate executable file: poetry. Please verify either the file path exists or the file can be found within a directory specified by the PATH environment variable. Also check the file mode to verify the file is executable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the error that is raised after I installed pipx (via apt) on the server. I could be that the version of pipx installed is installing poetry in the wrong path. But it may be simpler just to avoid using pipx.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah good point, I forgot that one is ran on the server. I will fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pytest warnings
2 participants