Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor case studies to separate out SDSS and Galsim Figures #703

Merged
merged 23 commits into from
Dec 8, 2022

Conversation

ismael-mendoza
Copy link
Collaborator

@ismael-mendoza ismael-mendoza commented Dec 6, 2022

Since current journal article will only use galsim simulations for evaluation. SDSS figures will be for future work and are in a separate case study.

  • new BlissFigure class that has a more limited scope and thus easier to use
  • separate out sdss_galaxies into two different case studies folders.
  • new bliss.plotting module for functions that will be used to create plots in more than one case study

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ismael-mendoza ismael-mendoza marked this pull request as draft December 6, 2022 20:36
@ismael-mendoza ismael-mendoza marked this pull request as ready for review December 7, 2022 23:37
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #703 (7177515) into master (ccc71e2) will decrease coverage by 0.48%.
The diff coverage is 41.37%.

❗ Current head 7177515 differs from pull request most recent head d5104db. Consider uploading reports for the commit d5104db to get more accurate results

@@            Coverage Diff             @@
##           master     #703      +/-   ##
==========================================
- Coverage   87.55%   87.06%   -0.49%     
==========================================
  Files          26       26              
  Lines        3711     3689      -22     
==========================================
- Hits         3249     3212      -37     
- Misses        462      477      +15     
Flag Coverage Δ
unittests 87.06% <41.37%> (-0.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bliss/reporting.py 93.95% <13.33%> (-5.63%) ⬇️
bliss/models/lensing_binary_encoder.py 76.37% <20.00%> (ø)
bliss/generate.py 100.00% <100.00%> (ø)
bliss/models/binary.py 99.22% <100.00%> (ø)
bliss/models/galaxy_encoder.py 95.34% <100.00%> (ø)
bliss/models/galaxy_net.py 92.30% <100.00%> (ø)
bliss/datasets/galsim_galaxies.py 95.85% <0.00%> (-1.56%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ismael-mendoza ismael-mendoza merged commit 56263b4 into master Dec 8, 2022
@ismael-mendoza ismael-mendoza deleted the u/im/refactor-common-case-studies-functions branch December 8, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant