Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poetry update (Nov 2022) #700

Merged
merged 18 commits into from
Nov 29, 2022
Merged

Poetry update (Nov 2022) #700

merged 18 commits into from
Nov 29, 2022

Conversation

ismael-mendoza
Copy link
Collaborator

@ismael-mendoza ismael-mendoza commented Nov 27, 2022

Summary

  • Remove some deprecated dependencies in pyproject.toml
  • Update poetry because I coudn't get it to work after removing said dependencies
  • update warnings captured in pyproject.toml
  • fix tests to avoid warnings
  • fixed linting

ToDo:

  • rerun pytest
  • rerunpytest --gpu
  • rerun case_studies/sdss_galaxies/make
  • fix Deprecation warning:
LightningDeprecationWarning: Setting `Trainer(gpus=1)` is deprecated in v1.7 and will be removed in v2.0. Please use `Trainer(accelerator='gpu', devices=1)` instead.

@ismael-mendoza ismael-mendoza self-assigned this Nov 27, 2022
@ismael-mendoza ismael-mendoza changed the title Im/cleanup dependencies Poetry update (2022 edition) Nov 27, 2022
@ismael-mendoza ismael-mendoza changed the title Poetry update (2022 edition) Poetry update (Nov 2022) Nov 27, 2022
@ismael-mendoza ismael-mendoza marked this pull request as draft November 27, 2022 16:33
@codecov
Copy link

codecov bot commented Nov 27, 2022

Codecov Report

Merging #700 (5e0db02) into master (516fe36) will decrease coverage by 0.07%.
The diff coverage is 75.47%.

@@            Coverage Diff             @@
##           master     #700      +/-   ##
==========================================
- Coverage   87.62%   87.55%   -0.08%     
==========================================
  Files          26       26              
  Lines        3694     3711      +17     
==========================================
+ Hits         3237     3249      +12     
- Misses        457      462       +5     
Flag Coverage Δ
unittests 87.55% <75.47%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bliss/models/galsim_encoder.py 21.59% <0.00%> (ø)
bliss/models/prior.py 91.21% <ø> (ø)
bliss/models/vae/prior.py 0.00% <0.00%> (ø)
bliss/train.py 57.14% <0.00%> (ø)
bliss/models/galaxy_encoder.py 95.34% <20.00%> (-1.35%) ⬇️
bliss/models/lensing_binary_encoder.py 76.37% <50.00%> (ø)
bliss/models/detection_encoder.py 95.95% <90.00%> (+0.04%) ⬆️
bliss/models/galaxy_net.py 92.30% <94.11%> (-0.31%) ⬇️
bliss/models/binary.py 99.22% <100.00%> (ø)
bliss/models/encoder_layers.py 100.00% <100.00%> (ø)
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ismael-mendoza ismael-mendoza marked this pull request as ready for review November 29, 2022 13:36
@ismael-mendoza ismael-mendoza merged commit 7761777 into master Nov 29, 2022
@ismael-mendoza ismael-mendoza deleted the im/cleanup-dependencies branch November 29, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant