Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove getters #20

Merged
merged 1 commit into from
Nov 1, 2022
Merged

refactor: remove getters #20

merged 1 commit into from
Nov 1, 2022

Conversation

privatenumber
Copy link
Owner

Getters were made the code elegant, but for the end-user, it wasn't easy to view:

    flags: {
      noCache: [Getter],
      tsconfig: [Getter],
      version: [Getter],
      help: [Getter]
    },

@github-actions
Copy link

github-actions bot commented Nov 1, 2022

📊 Package size report   0.2%↑

File Before (Size / Gzip) After (Size / Gzip)
dist/index.js 2.7 kB / 1.4 kB 0.9%↑2.7 kB / 0.2%↑1.4 kB
dist/index.mjs 2.6 kB / 1.4 kB 1%↑2.7 kB / -0.44%↓1.3 kB
Total (Includes all files) 22.0 kB / 9.1 kB 0.2%↑22.0 kB / -0.03%↓9.1 kB
Tarball size 7.6 kB 3%↑7.9 kB
Unchanged files
File Size (Size / Gzip)
dist/index.d.ts 3.3 kB / 1.1 kB
LICENSE 1.1 kB / 658 B
package.json 1.6 kB / 684 B
README.md 10.7 kB / 3.9 kB

🤖 This report was automatically generated by pkg-size-action

@privatenumber privatenumber merged commit 584bc5d into develop Nov 1, 2022
@privatenumber privatenumber deleted the remove-getter branch November 1, 2022 12:46
@privatenumber
Copy link
Owner Author

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant