Updated to @prismicio/client and docs to make theme command launch with content #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pvpg
commented
Jan 21, 2021
•
pvpg
commented
- Added documents for the theme command
- Changed the README and package.json description/info
- Updated prismic-javascript to @prismicio/client
- Updated toolbar script
pvpg
changed the title
pvpg
changed the title
samlfair
reviewed
Feb 11, 2021
README.md
Outdated
| @@ -1,42 +1,39 @@ | |||
| # Prismic Next.js Blog Site Example | |||
| > [Next.js](https://nextjs.org/) example blog project with content managed in [Prismic](https://prismic.io) | |||
| # Prismic & NextJS Example Blog | |||
There was a problem hiding this comment.
It's "Next.js", not "NextJS".
levimykel
reviewed
Feb 22, 2021
README.md
Outdated
|
|
||
| This software is licensed under the Apache 2 license, quoted below. | ||
|
|
||
| Copyright 2019 Prismic (https:https://prismic.io). | ||
| Copyright 2021 [Prismic](http:https://prismic.io). |
There was a problem hiding this comment.
Use https for the Prismic site
components/PrismicScript.js
Outdated
| @@ -3,7 +3,7 @@ import { apiEndpoint } from 'prismic-configuration' | |||
| const PrismicScript = () => { | |||
| const [, repoName] = apiEndpoint.match(/https?:\/\/([^.]+)?\.(cdn\.)?.+/); | |||
| return ( | |||
| <script async defer src={`"https://static.cdn.prismic.io/prismic.min.js?repo=${repoName}&new=true"`} /> | |||
| <script async defer src={`"https://static.cdn.prismic.io/prismic.js?new=true&repo=${repoName}"`}></script> | |||
There was a problem hiding this comment.
Use a self closing tag if there are no children in JSX: />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.