New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bunch of fixes #15

Merged

srenault merged 4 commits into prismicio-community:master from srenault:sre/fixes

Jun 10, 2020

Contributor

srenault commented Jun 8, 2020 •

edited

Loading

While trying out this project, I met some issues that should be resolved there:

Prismic toolbar was not included properly when specifying an endpoint with cdn.
Prismic toolbar was loaded twice.
When no content was defined in Prismic, the app was crashing.
Preview issue because of custom error page.
README issue with prismic theme command.


Remove custom error page

d8d837d

Contributor

hypervillain commented Jun 8, 2020

Nice to have: bind this Git repo to Vercel now so we can preview the changes 👍

srenault added 2 commits

June 9, 2020 16:33


Fix prismic.js include

9b70a50


Don’t explode when no content from prismic

25aa3cc

srenault force-pushed the sre/fixes branch from 306a5e2 to 25aa3cc Compare

June 9, 2020 14:38

srenault changed the title ~~Sre/fixes~~ Bunch of fixes


Fix README

4ca0cf7

srenault merged commit a44692c into prismicio-community:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment