Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for Prismic Client 6.0.0-beta.3 #5

Closed

Conversation

kingbiscit
Copy link

refactor!: support for Prismic Client 6.0.0-beta.3

BREAKING CHANGE: refactor to use client.dangerouslyGetAll() instead of client.getAll()

Types of changes

  • Chore (a non-breaking change which is related to package maintenance)
  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Prismic Client 6.0.0-beta.3 breaks this plugin by renaming client.getAll() to client.dangerouslyGetAll().

This change updates the call and test to use client.dangerouslyGetAll() and sets @prismicio/client to use ^6.0.0-beta.3.

This resolves this issue:

Checklist:

  • My change requires an update to the documentation.
  • All TSDoc comments are up-to-date and new ones have been added where necessary.
  • All new and existing tests are passing.

refactor!: support for Prismic Client 6.0.0-beta.3

BREAKING CHANGE: refactor to use client.dangerouslyGetAll() instead of client.getAll()
lihbr added a commit that referenced this pull request Nov 12, 2021
@lihbr
Copy link
Member

lihbr commented Nov 12, 2021

God I'm sorry 🙏 Went ahead at the same time as you and did the fix, now available in 0.1.3

Thank you so much for your willing to contribute though!

P.S. Just a FYI but I don't consider that as a breaking change as it just impacts the internals of the plugin, not the user-exposed API ☺️

@lihbr lihbr closed this Nov 12, 2021
@kingbiscit
Copy link
Author

No problem at all. I am just learning how best to contribute so hopefully I can add a few more things.

I have been working with Prismic for over 5 years but always using PHP, this plugin and 11ty is amazing!

@lihbr
Copy link
Member

lihbr commented Nov 12, 2021

You're more than welcome to do so! What you did with the issue and the PR was perfect 💯

And glad to hear that! Feel free to open issues to suggest things or such if you have ideas! It's still on my TODO to make the plugin support Prismic previews, hopefully there's a way to do so with 11ty serverless~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken with Prismic Changes
2 participants