Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm continue-on-error #988

Merged
merged 6 commits into from
Jun 26, 2024
Merged

rm continue-on-error #988

merged 6 commits into from
Jun 26, 2024

Conversation

lukasoppermann
Copy link
Contributor

Summary

Trying to make failed contrast fail build. This can now be done since our checks pass.

List of notable changes:

What should reviewers focus on?

Steps to test:

@lukasoppermann lukasoppermann requested review from a team as code owners June 25, 2024 20:03
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 25, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 39452bb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lukasoppermann lukasoppermann added the skip changeset Apply to PRs that should not result in a version bump. label Jun 25, 2024
@github-actions github-actions bot temporarily deployed to Preview (Storybook) June 25, 2024 20:05 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) June 25, 2024 20:06 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) June 25, 2024 20:10 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) June 25, 2024 20:14 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) June 25, 2024 20:16 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) June 25, 2024 20:23 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) June 25, 2024 20:29 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) June 25, 2024 20:44 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) June 26, 2024 05:43 Inactive
@primer primer deleted a comment from github-actions bot Jun 26, 2024
@primer primer deleted a comment from github-actions bot Jun 26, 2024
@lukasoppermann lukasoppermann merged commit 77b40a2 into main Jun 26, 2024
24 checks passed
@lukasoppermann lukasoppermann deleted the fail-build-on-contrast-fail branch June 26, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan Awaiting requested review from jonrohan jonrohan is a code owner automatically assigned from primer/css-reviewers

Assignees
No one assigned
Labels
skip changeset Apply to PRs that should not result in a version bump.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@lukasoppermann