Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds examples for button loading state #626

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Adds examples for button loading state #626

merged 1 commit into from
Oct 12, 2023

Conversation

mperrotti
Copy link
Contributor

@mperrotti mperrotti commented Oct 12, 2023 •
edited
Loading

Before

Screenshot 2023-10-12 at 10 37 11 AM

After

Screenshot 2023-10-12 at 10 36 24 AM

@mperrotti mperrotti requested a review from a team as a code owner October 12, 2023 14:36
langermank
langermank approved these changes Oct 12, 2023
View reviewed changes
content/ui-patterns/loading.mdx
@@ -369,25 +369,27 @@ However, the button that initiates the a loading process may not be semantically
{/*<!-- _TODO: Consider moving most of the button loading state details to the [Button interface guidelines](/components/button)_ -->*/}
</>

<Box display="flex" flexDirection={['column', 'column', 'column', 'column', 'row']} sx={{alignItems: 'start', gap: 3}}>
<img
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we determined we want to just leave the button label text the same as to not change the width of the button in the loading state. But maybe we want to offer it as an option? Either way I'm fine merging this PR and following up later after a11y review

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can update with more details after we talk about it in a11y office hours

@mperrotti mperrotti merged commit 982f697 into main Oct 12, 2023
4 checks passed
@mperrotti mperrotti deleted the mp/add-btn-loading-asset branch October 12, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langermank langermank langermank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mperrotti @langermank