Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #6684 DataTable column resize on touchscreens #6726

Merged

Conversation

KirilCycle
Copy link
Contributor

Defect Fixes

Fix #6684

Handle touch events

Copy link

vercel bot commented Jun 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 6:57pm
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 6:57pm

@KirilCycle KirilCycle marked this pull request as ready for review June 4, 2024 16:20
components/lib/datatable/DataTable.js Outdated Show resolved Hide resolved
components/lib/datatable/DataTable.js Outdated Show resolved Hide resolved
@KirilCycle KirilCycle requested a review from melloware June 4, 2024 16:58
components/lib/datatable/DataTable.js Outdated Show resolved Hide resolved
@KirilCycle KirilCycle requested a review from melloware June 4, 2024 18:57
@Josje92
Copy link

Josje92 commented Jun 14, 2024

@KirilCycle is there are reason you didn't go with pointer-events instead of adding the touch-events?
As far as my info goes, implementing pointerevents would reduce a couple of lines of code and behave the same way.

Then again, I haven't been contributing to this project yet, so I might not oversee the risks. Just wanted to (maybe) be of help.

@Josje92
Copy link

Josje92 commented Jul 1, 2024

@melloware This fix would help me and my project greatly, any chance you'll be able to look into it for @KirilCycle (/ and me)? 😄
Please

@melloware melloware merged commit 6b78911 into primefaces:master Jul 1, 2024
5 checks passed
@melloware
Copy link
Member

merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataTable: Resize columns on touch device
3 participants