Stop blowing away the BufWritePre augroup in ftplugins #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Didn't see this PR... I can confirm that a similar change was required for me to have vim-prettier auto format consistently and not break its own autocmds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
BufWritePre autocmdsare reset each time a file type plugin is run, which means if you open a file of one type, it will auto format correctly, but if you then open a file of a different type, the original file will no longer auto format.See further explanation here: #185 (comment)
This PR removes the
augroupfrom each of the ftplugin files and adds some missing file extensions to theaugroupinplugin/prettier.vim.Test Plan
[...]