refactored logging config

preshmalinetpereira · Oct 1, 2021 · 1afff38 · 1afff38
1 parent 1f82d35
commit 1afff38
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 10 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,6 +1,6 @@
-## 2.1.0 (2021/09/30)
+## 2.1.0 (2021/10/01)
 
-- Updated logging and added `quiet_mode`
+- Updated logging and set default log level to INFO
 - Added `load_cache` static method to `Response` to load cached responses using cache key
 
 ## 2.0.0 (2021/09/11)

diff --git a/README.md b/README.md
@@ -104,6 +104,7 @@ Introducing an element of randomness called `jitter` allows us to reduce the com
 - `decorr` - decorrelated jitter is similar to `full` jitter but increases the maximum jitter based on the last random value, selecting the length of sleep by the minimum value between `max_sleep` and a random sample between the `base_backoff` and the last sleep value multiplied by 3.
 
 ## Caching
+
 ### Memory Safety
 
 Memory safety allows us to reduce the amount of RAM used when requesting data, and can be enabled by setting `mem_safe=True` on a search method. This feature should be used if a large amount of data is being requested or if the machine in use has a limited amount of RAM.
@@ -159,7 +160,6 @@ A user-defined function can be provided using the `filter_fn` parameter for eith
 - `checkpoint` (int, optional): Size of interval in batches to print a checkpoint with stats, defaults to 10
 - `file_checkpoint` (int, optional): Size of interval in batches to cache responses when using mem_safe, defaults to 20
 - `praw` (praw.Reddit, optional): Used to enrich the Pushshift items retrieved with metadata directly from Reddit
-- `quiet_mode` (bool, optional): If true, only show set log level to WARN, defaults to INFO when False
 
 ### `Response`
 
@@ -358,7 +358,6 @@ resp = Response.load_cache(cache_key, cache_dir)
 
 ```
 
-
 # Benchmarks
 
 [Benchmark Notebook](https://github.com/mattpodolak/pmaw/blob/master/examples/benchmark.ipynb)

diff --git a/pmaw/PushshiftAPI.py b/pmaw/PushshiftAPI.py
@@ -18,7 +18,6 @@ def __init__(self, *args, **kwargs):
  checkpoint (int, optional) - Size of interval in batches to print a checkpoint with stats, defaults to 10
  file_checkpoint (int, optional) - Size of interval in batches to cache responses when using mem_safe, defaults to 20
  praw (praw.Reddit, optional) - Used to enrich the Pushshift items retrieved with metadata directly from Reddit
- quiet_mode (bool, optional) - If true, only show set log level to WARN, defaults to INFO when False
  """
  super().__init__(*args, **kwargs)
 

diff --git a/pmaw/PushshiftAPIBase.py b/pmaw/PushshiftAPIBase.py
@@ -10,15 +10,15 @@
 from pmaw.RateLimit import RateLimit
 from pmaw.Request import Request
 
+logging.basicConfig(level = logging.INFO, stream=sys.stdout)
 log = logging.getLogger(__name__)
 
-
 class PushshiftAPIBase(object):
  _base_url = 'https://{domain}.pushshift.io/{{endpoint}}'
 
  def __init__(self, num_workers=10, max_sleep=60, rate_limit=60, base_backoff=0.5,
  batch_size=None, shards_down_behavior='warn', limit_type='average', jitter=None,
- checkpoint=10, file_checkpoint=20, praw=None, quiet_mode=False):
+ checkpoint=10, file_checkpoint=20, praw=None):
  self.num_workers = num_workers
  self.domain = 'api'
  self.shards_down_behavior = shards_down_behavior
@@ -28,9 +28,6 @@ def __init__(self, num_workers=10, max_sleep=60, rate_limit=60, base_backoff=0.5
  self.file_checkpoint = file_checkpoint
  self.praw = praw
 
- log_level = logging.WARN if quiet_mode else logging.INFO
- logging.basicConfig(level = log_level, stream=sys.stdout)
-
  if batch_size:
  self.batch_size = batch_size
  else: