Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/client info param #1399

Merged
merged 4 commits into from
Sep 13, 2023
Merged

Feature/client info param #1399

merged 4 commits into from
Sep 13, 2023

Conversation

tillkruss
Copy link
Member

@tillkruss tillkruss commented Sep 13, 2023 •
edited
Loading

Quick fix for #1370 and #1347.

According to the CLIENT SETINFO docs:

Client libraries are expected to pipeline this command after authentication on all connections and ignore failures since they could be connected to an older version that doesn't support them.

We don't do that.

@tillkruss tillkruss mentioned this pull request Sep 13, 2023
Open
@tillkruss tillkruss self-assigned this Sep 13, 2023
@tillkruss tillkruss mentioned this pull request Sep 13, 2023
Open
@tillkruss tillkruss marked this pull request as ready for review September 13, 2023 16:30
@coveralls
Copy link

Coverage Status

coverage: 78.167%. remained the same when pulling 82dd37b on feature/client-info-param into 16bdd83 on v2.x.

@tillkruss tillkruss merged commit cbf394b into v2.x Sep 13, 2023
49 checks passed
@tillkruss tillkruss deleted the feature/client-info-param branch September 13, 2023 16:35
@tillkruss tillkruss mentioned this pull request Sep 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladvildanov vladvildanov Awaiting requested review from vladvildanov

Assignees

@tillkruss tillkruss

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tillkruss @coveralls