Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch prefill tokens uses max input tokens as default #320

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

noyoshi
Copy link
Collaborator

@noyoshi noyoshi commented Mar 11, 2024

max_batch_prefill_tokens is now optional, and it is defaulting to the value from max_input_length.

Now, users can define custom max_input_length without having to also specify max_batch_prefill_tokens

// Set default values dervided from other args

// If the value of max_batch_prefill_tokens is not specified, default to max_input_length
if args.max_batch_prefill_tokens.is_none() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we follow the same convention used by max_batch_total_tokens, which is also optional?

@magdyksaleh
Copy link
Collaborator

@noyoshi how we looking here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants