Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(signals-react): throw error when auto-tracking with React 19 #577

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

JoviDeCroock
Copy link
Member

Resolves #576

This should point people in the right direction 😅

Copy link

changeset-bot bot commented Jun 25, 2024

🦋 Changeset detected

Latest commit: 4c4c507

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@preact/signals-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JoviDeCroock JoviDeCroock changed the title Throw error when auto-tracking with React 19 chore(signals-react): throw error when auto-tracking with React 19 Jun 25, 2024
Copy link

netlify bot commented Jun 25, 2024

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit 4c4c507
🔍 Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/667baea8c8a14500083277fc
😎 Deploy Preview https://deploy-preview-577--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Jun 25, 2024

Size Change: 0 B

Total Size: 80.5 kB

ℹ️ View Unchanged
Filename Size
docs/dist/assets/client.********.js 46.3 kB
docs/dist/assets/index.********.js 838 B
docs/dist/assets/jsxRuntime.module.********.js 284 B
docs/dist/assets/preact.module.********.js 4.03 kB
docs/dist/assets/signals-core.module.********.js 1.4 kB
docs/dist/assets/signals.module.********.js 2.02 kB
docs/dist/assets/style.********.js 21 B
docs/dist/assets/style.********.css 1.21 kB
docs/dist/basic-********.js 244 B
docs/dist/demos-********.js 3.41 kB
docs/dist/nesting-********.js 1.13 kB
docs/dist/react-********.js 242 B
packages/core/dist/signals-core.js 1.45 kB
packages/core/dist/signals-core.mjs 1.47 kB
packages/preact/dist/signals.js 1.27 kB
packages/preact/dist/signals.mjs 1.22 kB
packages/react-transform/dist/signals-*********.js 4.74 kB
packages/react-transform/dist/signals-transform.mjs 4 kB
packages/react-transform/dist/signals-transform.umd.js 4.86 kB
packages/react/dist/signals.js 188 B
packages/react/dist/signals.mjs 150 B

compressed-size-action

Copy link
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the peer dependency warning not enough? I sorta figure that should be enough, but I guess this can't hurt

@JoviDeCroock JoviDeCroock merged commit 5a02bfa into main Jun 26, 2024
6 checks passed
@JoviDeCroock JoviDeCroock deleted the error-for-react-19 branch June 26, 2024 06:04
@github-actions github-actions bot mentioned this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

installAutoSignalTracking fails with React 19
4 participants