Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : swww fails when the hyprctl cursor do not give correct value, This PR will handle it using 0,0 as fallback #1607

Closed

Conversation

kRHYME7
Copy link
Collaborator

@kRHYME7 kRHYME7 commented Jun 17, 2024

Pull Request

Desc:

  • recently learned that hyprctl cursorpos cannot detect the position during theme change
  • During theme switching we tend to change cursors instantly,around 2-3 times
  • This sometimes causes hiccup to the system
  • Also causes hyprctl cursorpos to output Couldn't read (5)
  • This PR handles that situation and defaults the cursorpos to "0,0"

Fixes:

  • Failing wallpaper change on themeswitch

@kRHYME7 kRHYME7 changed the title fix : swww fails when the hyprctl cursor do not give a right value, This PR will handle it using 0,0 as fallback fix : swww fails when the hyprctl cursor do not give correct value, This PR will handle it using 0,0 as fallback Jun 17, 2024
@rubiin
Copy link
Contributor

rubiin commented Jul 1, 2024

@kRHYME7 what do you say I take your PRs , since you cannot merge yours

@kRHYME7
Copy link
Collaborator Author

kRHYME7 commented Jul 1, 2024

yes please, Thanks! As long as it's not breaking and doesn't need permission from Tittu

@rubiin
Copy link
Contributor

rubiin commented Jul 2, 2024

cool will do then

@kRHYME7 kRHYME7 closed this Jul 2, 2024
@kRHYME7 kRHYME7 deleted the fix_swww_hiccup_cursorpos_fail branch July 2, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants