Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add OS age and Uptime to fastfetch #1493

Closed
wants to merge 21 commits into from

Conversation

sanjyay
Copy link

@sanjyay sanjyay commented May 13, 2024

Pull Request

Description

Please read these instructions and remove unnecessary text.

  • Try to include a summary of the changes and which issue is fixed.
  • Also include relevant motivation and context (if applicable).
  • List any dependencies that are required for this change. (e.g., packages or other PRs)
  • Provide a link if there is an issue related to this pull request. e.g., Fixes # (issue)
  • Please add Reviewers, Assignees, Labels, Projects, and Milestones to the PR. (if applicable)

Type of change

Please put an x in the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

Checklist

Please put an x in the boxes that apply:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added a changelog entry.
  • [] I have added necessary comments/documentation to my code.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

Screenshots

image

Additional context

Neofetch used to display Uptime which was missing in fastfetch and also displaying OS age is an interesting feature that lets the user known how long they have been using the particular distro

Copy link
Contributor

@abenezerw abenezerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works! Os Age is a pretty cool info, haha just realised been using this for 196 days haha.
image

{
"type": "colors",
"paddingLeft": 2,
"symbol": "circle"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these lines seems to be deleted?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The end of the file should have

        {
            "type": "colors",
            "paddingLeft": 2,
            "symbol": "circle"
        },
        "break"

so as not to cause breaking change UI wise

Configs/.config/fastfetch/config.jsonc Outdated Show resolved Hide resolved
Configs/.config/fastfetch/config.jsonc Outdated Show resolved Hide resolved
@rubiin
Copy link
Contributor

rubiin commented Jul 22, 2024

LGTM @kRHYME7

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Jul 22, 2024

how long they have been using the particular distro

Best fit for a distro hopper. Lol.
But yeah, It's cool!

Can you send me a screenshot of the latest commits? @rubiin @sanjyay

Also, please resolve the comments too.

sanjyay and others added 17 commits July 22, 2024 18:20
Enables Discord and derivatives Theme for disabled wallbash/mode Theme. Likely Buttons that are only have a border, for example "deactivate account" and "remove authentication-app" will have an invisible text or like "Edit User Profile", "Change Password", "View Backup Codes", "Enable SMS Authentication" and "Register a Security Key" in "Graphite Mono" Theme are some of the invisible buttons. All of those buttons have a blue background and white text and are unchanged as it seems.
Config error in file /home/<user>/.config/hypr/hyprland.conf at line 105: config option <master:new_is_master> does not exist
@sanjyay sanjyay closed this Jul 22, 2024
@sanjyay sanjyay reopened this Jul 22, 2024
@sanjyay sanjyay closed this Jul 22, 2024
@sanjyay sanjyay deleted the fastfetch_upgrade branch July 22, 2024 14:10
@sanjyay sanjyay restored the fastfetch_upgrade branch July 22, 2024 14:12
@sanjyay sanjyay reopened this Jul 22, 2024
@Enigma1309
Copy link
Contributor

image
I smell something wrong

@sanjyay
Copy link
Author

sanjyay commented Jul 22, 2024

i am new to git . I messed up using git pull.

image I smell something wrong

i am new to git . I messed up with git pull so basically now my pull request as all the commits that have been performed in the project. I tried to solve it but like you can see i wasn't able to do anything. Can you help or will it be better if i just create a new pull request?

@sanjyay sanjyay closed this by deleting the head repository Jul 22, 2024
@kRHYME7
Copy link
Collaborator

kRHYME7 commented Jul 22, 2024

Happens to anyone. Just create a new one.

@sanjyay
Copy link
Author

sanjyay commented Jul 22, 2024

Happens to anyone. Just create a new one.

thank you. I have created another PR #1697

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants