New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove key arrow handling in `VolumeOverlay` to avoid conflicting with ruleset key bindings (i.e. osu!catch) #28823

Merged

peppy merged 2 commits into ppy:master from frenzibyte:remove-volume-key-arrow-handling

Jul 11, 2024

Member

frenzibyte commented Jul 11, 2024 •

edited

Loading

Closes Volume meter keybindings take precedence over ruleset keybindings #19362
Alternative to / closes Disable key navigation in volume overlay during gameplay #28815

As per suggestion in previous PR (see #28815 (comment)).

frenzibyte added 2 commits

July 11, 2024 14:29


Remove key arrow handling in VolumeOverlay

3190f8b


Enable NRT in VolumeOverlay

bd44c17

frenzibyte added the area:overlay-volume label

pull-request-size bot added the size/M label

peppy approved these changes

View reviewed changes

peppy merged commit 911fa31 into ppy:master

9 of 17 checks passed

frenzibyte deleted the remove-volume-key-arrow-handling branch

July 11, 2024 16:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment