Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change doubletap doubles nerf in Speed Evaluator to address for galloping #28611

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Change doubletap doubles nerf in Speed Evaluator to address for galloping #28611

wants to merge 2 commits into from

Conversation

Givikap120
Copy link
Contributor

Closes #28598
Also added distance factor, because you can't doubletap spaced circles
So this map (mentioned in issue) +HR won't be as nerfed
https://osu.ppy.sh/beatmapsets/1359291#osu/2969884

@Givikap120
Copy link
Contributor Author

Before:
image
After:
image

@tsunyoku tsunyoku requested a review from a team June 26, 2024 09:11
@bdach
Copy link
Collaborator

bdach commented Jun 26, 2024

!diffcalc

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 26, 2024 •
edited
Loading

Target: #28611
Spreadsheet: https://docs.google.com/spreadsheets/d/1XRiGIO3zIC-uPnK5HeU4147fZLgQYuLKHDWE27VvI_U/edit

@Givikap120
Copy link
Contributor Author

Givikap120 commented Jun 26, 2024 •
edited
Loading

Additional comment: abuse is STILL possible if mapper knows what they're doing.
You can add doubles that you can't doubletap or gallop, but you can get 100s on it with doubletapping / galloping
Then map the rest of the map to farm accuracy on
Full fix for this is much harder, so for now I will propose to not rank such maps if mapper blatantly tries to exploit this issue

@Givikap120
Copy link
Contributor Author

Target: #28611 Spreadsheet: https://docs.google.com/spreadsheets/d/1XRiGIO3zIC-uPnK5HeU4147fZLgQYuLKHDWE27VvI_U/edit

okay, it nerfs fast bursts in general

@Givikap120
fixed burst nerf
dccd10e 
and now nerf works for last object in the map too
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jun 26, 2024
@Givikap120
Copy link
Contributor Author

update the sheet pls

@smoogipoo
Copy link
Contributor

!diffcalc

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 26, 2024 •
edited
Loading

Target: #28611
Spreadsheet: https://docs.google.com/spreadsheets/d/18iJG17it4o0R852ayfBCAgxKPZG-2QbMCvCvEo4hxJk/edit

@Givikap120
Copy link
Contributor Author

Okay, I don't see any issues now, I think pp committee can review it

tsunyoku
tsunyoku reviewed Jul 15, 2024
View reviewed changes
osu.Game.Rulesets.Osu/Difficulty/Evaluators/SpeedEvaluator.cs
Comment on lines +53 to +56
// Nerf even more if you don't need to gallop anymore
double halfPoint = Math.Pow(0.5, power);
if (windowRatio < halfPoint)
windowRatio *= windowRatio / halfPoint;
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand what's going on here

@tsunyoku
Copy link
Sponsor Member

Isn't this going to nerf all maps that have doubles?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsunyoku tsunyoku tsunyoku left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area:difficulty ruleset/osu! size/M
Projects
Difficulty calculation changes
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Certain song with "double tapping" have broken SR calculation when changing OD.
4 participants
@Givikap120 @bdach @smoogipoo @tsunyoku