Fix external links not working on Android

[Joehuu]

• Fixes osu! does not update on Android. #22777

Will also make a PR framework-side but is not necessary for fixing osu!-side.

[bdach]

Would like to get this into the upcoming hotfix release if possible, so expediting application of the review would be appreciated.

[Susko3]

This could use AndroidManifestMerger in combination with AndroidManifestOverlay to reduce code duplication.

Unfortunately, there isn't a way to have this overlay framework-side and have it implicitly included when referencing the nuget/local package.

diff --git a/osu.Android.props b/osu.Android.props
index abd8406cf7..cb41c60f24 100644
--- a/osu.Android.props
+++ b/osu.Android.props
@@ -8,9 +8,11 @@
     <!-- NullabilityInfoContextSupport is disabled by default for Android -->
     <NullabilityInfoContextSupport>true</NullabilityInfoContextSupport>
     <EmbedAssembliesIntoApk>true</EmbedAssembliesIntoApk>
+    <AndroidManifestMerger>manifestmerger.jar</AndroidManifestMerger>
   </PropertyGroup>
   <ItemGroup>
     <PackageReference Include="ppy.osu.Framework.Android" Version="2023.228.0" />
+    <AndroidManifestOverlay Include="$(MSBuildThisFileDirectory)osu.Android\Properties\AndroidManifestOverlay.xml" />
   </ItemGroup>
   <PropertyGroup>
     <!-- Fody does not handle Android build well, and warns when unchanged.
diff --git a/osu.Android/Properties/AndroidManifestOverlay.xml b/osu.Android/Properties/AndroidManifestOverlay.xml
new file mode 100644
index 0000000000..815f935383
--- /dev/null
+++ b/osu.Android/Properties/AndroidManifestOverlay.xml
@@ -0,0 +1,15 @@
+<?xml version="1.0" encoding="utf-8"?>
+<manifest xmlns:android="https://schemas.android.com/apk/res/android">
+    <queries>
+        <intent>
+            <action android:name="android.intent.action.VIEW" />
+            <category android:name="android.intent.category.BROWSABLE" />
+            <data android:scheme="https" />
+        </intent>
+        <intent>
+            <action android:name="android.intent.action.VIEW" />
+            <category android:name="android.intent.category.BROWSABLE" />
+            <data android:scheme="mailto" />
+        </intent>
+    </queries>

[Joehuu]

I'll wait for another opinion. I might not be around for the hotfix release so feel free to apply the changes.

[bdach]

The manifest merger thing seems pretty nice and looks to work, so I've applied (with minor stylistic adjustments), thanks 👍