Add "Incognito" mod for osu! ruleset #22271
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
changed the title
bdach
requested changes
Jan 18, 2023
| public override LocalisableString Description => "Obscure some gameplay elements."; | ||
| public override double ScoreMultiplier => 1; | ||
| public override string Acronym => "IC"; | ||
| public override IconUsage? Icon => FontAwesome.Solid.UserSecret; |
There was a problem hiding this comment.
Suggested change
| public override IconUsage? Icon => FontAwesome.Solid.UserSecret; |
We're not doing icons on new mods.
There was a problem hiding this comment.
Sorry for that, didn't knew about that.
| public override double ScoreMultiplier => 1; | ||
| public override string Acronym => "IC"; | ||
| public override IconUsage? Icon => FontAwesome.Solid.UserSecret; | ||
| public override ModType Type => ModType.Conversion; |
There was a problem hiding this comment.
Why is this in Conversion again? Completely does not fit the category. Should either be DifficultyIncrease or Fun.
There was a problem hiding this comment.
You are right. I will put it at DifficultyIncrease section since it aims to always obscure visuals.
|
With the addition of #23520 I wonder which direction should this take? Since the author of the pull request mentioned out that these mods have similar yet conflicting ideas. I still do not have any that comes to mind, they all seem conflicting someway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #20514 (Accident while making branch upto-date).
This mod introduces two new settings:
ModVisualAdjusts#20514 (comment)You can see some of the reasoning behind this mod on the mentioned "Disable follow points" discussion.