Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume Settings Design #3413

Closed
Gabixel opened this issue Sep 11, 2018 · 6 comments
Closed

Volume Settings Design #3413

Gabixel opened this issue Sep 11, 2018 · 6 comments
Labels

Comments

@Gabixel
Copy link
Contributor

Gabixel commented Sep 11, 2018

So, I decided to make another concept. This time is for Volume Settings style

default volumes

Concept

Being able to choose the position (or style) for the Volume Settings

Why?

I think some users prefer choosing the position for the volume (maybe can be "annoying" just on the left side of the screen)

Ideas (Photoshop)

Here are some ideas:

A Right-side Design (with the "reflected" bar, cool detail)

right design concept

A Top Design (with the mute button to the bottom) (but can be reversed: with the mute one on top, and the volumes to the bottom)

top design concept

OR,

instead of choosing the position, maybe you can choose the style of it:

maybe proposing the old style with the new one (like a nostalgia thing) (with a light design for volume words, and the mute button in the middle)

old-style design concept

@peppy
Copy link
Member

peppy commented Sep 11, 2018

In fine with this being added as a setting.

@GSculerlor
Copy link
Contributor

Will take this issue, is there any design change to support it? Or is it okay by just align the volume meter based on the position?

@peppy
Copy link
Member

peppy commented Nov 14, 2019

Just do what looks right and we'll take it from there.

@peppy peppy added the priority:3 Nice to have, at some point label Feb 17, 2020
@peppy peppy removed this from the Backlog milestone Feb 17, 2020
@peppy
Copy link
Member

peppy commented Dec 4, 2020

@arflyte is the volume control something you've already included in your redesign? i think we want it to be part of the toolbar (but keep in mind it still needs to display as its own floating element when the toolbar is not present).

See #11077 for reasoning.

@arflyte
Copy link

arflyte commented Dec 4, 2020

No changes to the volume control design so far. I'll try to add it to the toolbar.

@yyny
Copy link

yyny commented Apr 28, 2021

Just putting this here since I don't think this is worth it's own issue, the mute button overlaps other buttons using the bottom left of the screen (like the back button), this is annoying since clicking or pressing ESC doesn't hide the volume menu, meaning you have to wait for the volume menu to disappear before you can press buttons in that part of the screen.

@ppy ppy locked and limited conversation to collaborators Jan 22, 2022
@peppy peppy converted this issue into discussion #16560 Jan 22, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
Projects
None yet
Development

No branches or pull requests

6 participants