Always do filter

ppremk · Feb 10, 2022 · f565df1 · f565df1
1 parent d1849e2
commit f565df1
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 31 deletions.
diff --git a/dist/index.js b/dist/index.js
@@ -12719,20 +12719,16 @@ async function getPrFilesWithBlobSize(pullRequestNumber) {
  pull_number: pullRequestNumber,
  });
  const exclusionPatterns = core.getMultilineInput('exclusionPatterns');
- const files = exclusionPatterns.length > 0
- ? data.filter(({ filename, status }) => {
- if (status === 'copied' ||
- status === 'renamed' ||
- status === 'removed') {
- return false;
- }
- const isExcluded = micromatch.isMatch(filename, exclusionPatterns);
- if (isExcluded) {
- core.info(`${filename} has been excluded from LFS warning`);
- }
- return !isExcluded;
- })
- : data;
+ const files = data.filter(({ filename, status }) => {
+ if (status === 'copied' || status === 'renamed' || status === 'removed') {
+ return false;
+ }
+ const isExcluded = micromatch.isMatch(filename, exclusionPatterns);
+ if (isExcluded) {
+ core.info(`${filename} has been excluded from LFS warning`);
+ }
+ return !isExcluded;
+ });
  const prFilesWithBlobSize = await Promise.all(files.map(async (file) => {
  const { filename, sha, patch, status } = file;
  const { data: blob } = await octokit.rest.git.getBlob({

diff --git a/src/index.ts b/src/index.ts
@@ -170,24 +170,17 @@ async function getPrFilesWithBlobSize(pullRequestNumber: number) {
 
  const exclusionPatterns = core.getMultilineInput('exclusionPatterns');
 
- const files =
- exclusionPatterns.length > 0
- ? data.filter(({filename, status}) => {
- if (
- status === 'copied' ||
- status === 'renamed' ||
- status === 'removed'
- ) {
- return false;
- }
+ const files = data.filter(({filename, status}) => {
+ if (status === 'copied' || status === 'renamed' || status === 'removed') {
+ return false;
+ }
 
- const isExcluded = micromatch.isMatch(filename, exclusionPatterns);
- if (isExcluded) {
- core.info(`${filename} has been excluded from LFS warning`);
- }
- return !isExcluded;
- })
- : data;
+ const isExcluded = micromatch.isMatch(filename, exclusionPatterns);
+ if (isExcluded) {
+ core.info(`${filename} has been excluded from LFS warning`);
+ }
+ return !isExcluded;
+ });
 
  const prFilesWithBlobSize = await Promise.all(
  files.map(async file => {