Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered that the problem with current proposed v1.1 is ..
xr.Dataset.identical()
xr.Dataset.to_netcdf()
however, the units does/does-not strip a midnight time-of-day when the data array is lazy/real (i.e. sometimes get "hours since 1970-01-01" instead of the "hours since 1970-01-01 00:00:00" in the encoding)Dataset.encoding
s are also non-identical, butDataset.identical()
does not insist on this