Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#6736) - fix {binary: true} in db.get() with open_revs and HTTP adapter. #6737

Merged
merged 1 commit into from
Nov 16, 2017
Merged

(#6736) - fix {binary: true} in db.get() with open_revs and HTTP adapter. #6737

merged 1 commit into from
Nov 16, 2017

Conversation

jerem
Copy link
Contributor

@jerem jerem commented Sep 6, 2017

No description provided.

@jerem jerem mentioned this pull request Sep 6, 2017
Closed
@daleharvey daleharvey closed this Oct 30, 2017
@daleharvey daleharvey reopened this Oct 30, 2017
@daleharvey
Copy link
Member

Closing and reopening to see if I can kick travis off

daleharvey
daleharvey previously approved these changes Oct 30, 2017
View reviewed changes
Copy link
Member

@daleharvey daleharvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good to me, lets see the tests and land when green :)

@daleharvey daleharvey dismissed their stale review October 30, 2017 13:23

Tests failing

@daleharvey
Copy link
Member

Ooops sorry, tests failures are genuine here

@jerem jerem force-pushed the 6736 branch 2 times, most recently from 1dcbfd5 to d6b2261 Compare November 14, 2017 04:12
@jerem jerem closed this Nov 14, 2017
@jerem jerem reopened this Nov 14, 2017
@jerem
Copy link
Contributor Author

jerem commented Nov 14, 2017

Closed/reopened the PR to trigger CI.

@jerem
Copy link
Contributor Author

jerem commented Nov 15, 2017

Looks like tests are failing because of timeouts (just like master). Re-triggering CI once again.

@jerem jerem closed this Nov 15, 2017
@jerem jerem reopened this Nov 15, 2017
@jerem
Copy link
Contributor Author

jerem commented Nov 15, 2017

🎉🎉🎉

@jerem
Copy link
Contributor Author

jerem commented Nov 15, 2017

@daleharvey tests are now passing. Ca you proceed with the review and merge? Thanks.

daleharvey
daleharvey approved these changes Nov 16, 2017
View reviewed changes
Copy link
Member

@daleharvey daleharvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a great change, nice test addition and code looks good, many thanks :)

@daleharvey daleharvey merged commit f00b62e into pouchdb:master Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daleharvey daleharvey daleharvey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerem @daleharvey