upgrade leveldown and fix iterator problems #6639
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6551
I was a bit unsure on where to check for the error. We have different options here.
At first I wanted to put an error handler on
changeStream
here, which could check for that particular error. But unclear to me how a different error should be handled.changeStream
is also completely internal to theapi._changes
function so a bit clunky to handle the errors.So I tried to go deeper instead and try to stop this error as early as possible and as close to
iterator.next(cb)
as possible and basically don't even emit it on the stream to begin with.Let me know if you aren't happy with this solution and/or if it should be tweaked.
Cheers