Update 2014-04-14-pagination-strategies-with-pouchdb.md #6634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was having trouble getting the "smart method" to work. I was confused about why you would create a startkey that contains the entire row, instead of just the id for the doc. I finally figure it out. If include_docs = false, then having a startkey like this:
{ id: 'Client Demographics',
key: 'Client Demographics',
value: { rev: '569-5a192c494eca04611bc046a50a5283de' } }
seems to work (seems like a bug/side-effect, but it works). However, when you use include_docs=true it also has a doc property, and passing this object doesn't work as a valid startkey.
The solution, which works in both include_docs=true and include_docs=false, and which seems to make much more sense to me, is to only use the id of the doc for the startkey. That's what my pull request does.
daleharvey
approved these changes
Jul 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having trouble getting the "smart method" to work. I was confused about why you would create a startkey that contains the entire row, instead of just the id for the doc. I finally figured it out. If include_docs = false, then having a startkey like this:
{ id: 'Client Demographics',
key: 'Client Demographics',
value: { rev: '569-5a192c494eca04611bc046a50a5283de' } }
seems to work (seems like a bug/side-effect, but it works). However, when you use include_docs=true it also has a doc property, and passing this object doesn't work as a valid startkey.
The solution, which works in both include_docs=true and include_docs=false, and which seems to make much more sense to me, is to only use the id of the doc for the startkey. That's what my pull request does.