Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#6607) - Use plain imports for uuid #6609

Merged
merged 1 commit into from
Jul 14, 2017
Merged

(#6607) - Use plain imports for uuid #6609

merged 1 commit into from
Jul 14, 2017

Conversation

daleharvey
Copy link
Member

With the fancy name we miss dont match https://github.com/pouchdb/pouchdb/blob/master/bin/build-module.js#L45 and treat the import as a local one, with this the only warning now is

 'default' is imported from external module 'uuid' but never used

Which was there previously and should only mean extra code bundled, although would still like to get rid of it

Copy link
Member

@willholley willholley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 - appears to fix the packaging errors related to uuid when the release script is run.

@daleharvey
Copy link
Member Author

Sweet cheers

@daleharvey daleharvey merged commit 28fba08 into master Jul 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants