(#3871) - support "rev" option in getAttachment() #3872
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
added a commit
to pouchdb/express-pouchdb
that referenced
this pull request
May 24, 2015
nolanlawson
force-pushed
the
3871
branch
2 times, most recently
from
bc2cef2
to
cdd95be
Compare
nolanlawson
added a commit
to nolanlawson/pouchdb-express-router
that referenced
this pull request
May 25, 2015
|
Forgot that the "get an attachment at a particular rev" test should only be enabled when we're not doing auto-compaction. |
nolanlawson
force-pushed
the
3871
branch
2 times, most recently
from
f14b141
to
b73bdc3
Compare
daleharvey
pushed a commit
to pouchdb/pouchdb-express-router
that referenced
this pull request
May 27, 2015
|
Looks great, cheers - 6eddeb3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally this commit was part of #3870, but I broke
it into a separate PR to make it easier to digest.
I did rebase this on top of #3871, however, to avoid
bitrotting myself.