Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added doc_ids filtering in _changes api #3056

Closed
wants to merge 1 commit into from
Closed

Added doc_ids filtering in _changes api #3056

wants to merge 1 commit into from

Conversation

ktarasz
Copy link

@ktarasz ktarasz commented Nov 27, 2014

Resolve #2569

@nolanlawson
Copy link
Member

This will need a test, and also probably an implementation in websql/idb/leveldb. I can work on that this weekend if you don't have time.

@daleharvey
Copy link
Member

@ktarasz Yup as Nolan said, we definitely need tests that verify this functionality works in a consistent way across adapters

Copying a test like https://github.com/pouchdb/pouchdb/blob/master/tests/integration/test.changes.js#L1116 and removing the filter / adding the doc_id's param should be fairly doable, ask us if you run in to any issues

nolanlawson added a commit that referenced this pull request Nov 29, 2014
@nolanlawson
(#3056) - correctly implement doc_ids filter
9ee23df
nolanlawson added a commit that referenced this pull request Nov 29, 2014
@nolanlawson
(#3056) - implement doc_ids filter
e6a3898
nolanlawson added a commit that referenced this pull request Nov 29, 2014
@nolanlawson
(#3056) - implement doc_ids filter
f2629c1
@nolanlawson nolanlawson mentioned this pull request Nov 29, 2014
Closed
@nolanlawson
Copy link
Member

Closing in favor of #3073. Thanks for the contribution, though; it pointed us in the right direction. :)

nolanlawson added a commit that referenced this pull request Nov 30, 2014
@nolanlawson
(#3056) - implement doc_ids filter
ca1f1e8
nolanlawson added a commit that referenced this pull request Nov 30, 2014
@nolanlawson
(#3056) - implement doc_ids filter
534f2f1
nolanlawson added a commit that referenced this pull request Nov 30, 2014
@nolanlawson
(#3056) - implement doc_ids filter
05aac3e
nolanlawson added a commit to pouchdb/express-pouchdb that referenced this pull request Nov 30, 2014
@nolanlawson
(pouchdb/pouchdb#3056) - _changes with POST
e7ac540
nolanlawson added a commit to pouchdb/express-pouchdb that referenced this pull request Nov 30, 2014
@nolanlawson
(pouchdb/pouchdb#3056) - _changes with POST
fecee52 
`_changes` needs to accept POST as well as GET
because of doc_ids.
nolanlawson added a commit to nolanlawson/pouchdb-express-router that referenced this pull request Nov 30, 2014
@nolanlawson
(pouchdb/pouchdb#3056) - _changes with POST
78de1d0 
`_changes` needs to accept POST as well as GET
because of doc_ids.
daleharvey pushed a commit to pouchdb/pouchdb-express-router that referenced this pull request Dec 2, 2014
@nolanlawson @daleharvey
(pouchdb/pouchdb#3056) - _changes with POST
1f81603 
`_changes` needs to accept POST as well as GET
because of doc_ids.
nolanlawson added a commit that referenced this pull request Dec 3, 2014
@nolanlawson
(#3056) - implement doc_ids filter
e71b3c6
nolanlawson added a commit that referenced this pull request Dec 3, 2014
@nolanlawson @daleharvey
(#3056) - implement doc_ids filter
f1329a0
rhiokim added a commit to rhiokim/pouchdb that referenced this pull request Dec 4, 2014
@rhiokim
Merge branch 'pouchdb/master' into feature/3.2.0
b06ceee 
* pouchdb/master: (57 commits)
  (pouchdb#2795) - Updating FAQ to clarify behavior of Firefox, Chrome, and Opera.
  (pouchdb#3056) - implement doc_ids filter
  (pouchdb#3103) - update mapreduce to 2.3.0
  (pouchdb#3059) - Can't refresh appcache
  (pouchdb#3096) - clarify conflict resolution in docs
  (pouchdb#3092) - correctly handle attachments when _deleted
  (pouchdb#3100) - Fix bug in query documentation
  (pouchdb#3087) - simpler putLocal/removeLocal for idb
  (pouchdb#3074) - implement attachments=true for changes()
  (pouchdb#2975) - Fix couchdb-master setup script
  (pouchdb#3084) - API-level debug mode
  (pouchdb#3081) - correction to blog post
  (pouchdb#3083) - add crypto-pouch to external.md
  (pouchdb#3080) - Test pouchdb-express-router
  (pouchdb#3078) - remove _bulk_seq
  (pouchdb#3026) - fix race condition in leveldb
  (pouchdb#3062) - refactor idb/websql to share more code
  (pouchdb#3062) - fix leveldb bulkDocs ordering
  (pouchdb#3004) - Test for replication with funny ids
  (pouchdb#3044) - remove cutesy console message
  ...
rhiokim added a commit to rhiokim/pouchdb that referenced this pull request Dec 8, 2014
@rhiokim
Merge branch 'pouchdb/master'
0069509 
* pouchdb/master: (68 commits)
  (pouchdb#2355) - Add info alert with full working example
  (pouchdb#3131) - add travis badge
  (pouchdb#3126) - npm run dev works without dist/
  (pouchdb#3124) - Compress Images
  (pouchdb#3111) - change db.compact()'s return value back
  (pouchdb#3120) - small edits to guide
  (pouchdb#3122) - img partial and retro applicaton
  (pouchdb#3118) - Typo correction
  (pouchdb#3116) - typo correction
  (pouchdb#3061) - 3.2.0 version bump
  (pouchdb#3061) - 3.2.0 blog post
  (pouchdb#2795) - Updating FAQ to clarify behavior of Firefox, Chrome, and Opera.
  (pouchdb#3056) - implement doc_ids filter
  (pouchdb#3103) - update mapreduce to 2.3.0
  (pouchdb#3059) - Can't refresh appcache
  (pouchdb#3096) - clarify conflict resolution in docs
  (pouchdb#3092) - correctly handle attachments when _deleted
  (pouchdb#3100) - Fix bug in query documentation
  (pouchdb#3087) - simpler putLocal/removeLocal for idb
  (pouchdb#3074) - implement attachments=true for changes()
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

_changes api should pass doc_ids
3 participants
@ktarasz @nolanlawson @daleharvey