I can confirm that the Closing db does not cause a crash if changes cancelled test no longer crashes, which is great progress.

Unfortunately the "local" version of the test still doesn't pass (unlike the "http" version of the test, which is fine), as the new "iterator has ended" error that's thrown isn't being caught.

There's an additional advantage to updating to [email protected] since it uses preubild-install instead of prebuild --install which reduced the dependency tree substantially.

@hubgit Is there anything I can do to help with this? It seems we broke something by fixing something else.

@ralphtheninja this is the test that's still failing - I didn't manage to get to the bottom of how to catch the thrown error appropriately.

@hubgit What is the command to run all the appropriate tests? Do I need some extra setup with couchdb etc?

npm test will run all the tests, GREP=test.changes.js npm test will run only that file, you do need couchdb running on localhost:5984, if that is too much of a hassle

npm install -g pouchdb-server
pouchdb-server

is an easier version

@daleharvey Thanks! I'm in the middle of the bush right now and a huge party, but will hop on this when I'm back home :)

Here's what I've been able to surmise so far - this applies only to the test for the local adapter:

The "Closing db does not cause a crash if changes cancelled" test calls db.changes, then asynchronously calls db.close. Closing the database causes db.changes' stream reading to get the new "iterator has ended" error, which is reported by Mocha as an "Uncaught Error". Although the test completes successfully, when done is called the test has already been closed due to the uncaught error, so Mocha throws a "Cannot set property 'state' of undefined" exception, which is reported as an "Unhandled promise rejection".

There must be somewhere in PouchDB's changes/stream reading code to catch the "iterator has ended" error and handle it, but I haven't been able to work out where.

@hubgit Aye, I've gathered as much myself, but have problems understanding the project structure, since all code is built out before on each npm test. Any pointers greatly appreciated.

I basically want to find out what's going on in db.close() to start with. I'm assuming this is a pouchdb specific method which in turn closes an internal leveldown instance.

The changestream here doesn't have a listener for an error event. That's where you could catch the iterator had ended error, I think.

@ralphtheninja yup the pouchdb close is just a wrapper around levels https://github.com/pouchdb/pouchdb/blob/master/packages/node_modules/pouchdb-adapter-leveldb-core/src/index.js#L1158