-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use jest instead of mocha + chai #681
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharygolba
force-pushed
the
refactor-use-jest
branch
from
February 17, 2017 16:24
4f468aa
to
d329538
Compare
Codecov Report
@@ Coverage Diff @@
## master #681 +/- ##
==========================================
- Coverage 92.4% 90.28% -2.12%
==========================================
Files 180 194 +14
Lines 2014 2090 +76
Branches 0 430 +430
==========================================
+ Hits 1861 1887 +26
- Misses 153 181 +28
- Partials 0 22 +22
Continue to review full report at Codecov.
|
* docs: add code of conduct and contributing documentation fix: duplicate source materials entry in contributing.md docs: add preliminary content to code of conduct dx: add .nvmrc file (#672) docs: add build and test steps to contributing.md docs: add issue template docs: fix linter error for issue template docs: add docs for making documentation contributions docs: add link to rfcs repository in contributing.md docs: update readme and remove roadmap in favor of lux-rfcs repo style: whitespace change in contributing.md docs: left align column 2 of the commit style table in contributing.md docs: missing punctuation in code of conduct dx: add .nvmrc file (#672) docs: change irc to gitter in code of conduct * docs: use [email protected] instead of [email protected] * docs: copy changes in code of conduct docs: copy changes in code of conduct * docs: typo in contribting.md * docs: copy changes in contributing.md * docs: add instructions for reporting security vulnerabilities * docs: add a link to flow documentation in contributing.md * docs: typo in contributing.md * docs: add webstorm flow docs to contributing.md * docs: remove unecessary "that" in contributing.md * docs: widen the scope of the second bullet in the code of conduct * docs: add pull request template * docs: add "ways to contribute" section to contributing.md
zacharygolba
force-pushed
the
refactor-use-jest
branch
from
March 21, 2017 21:14
dc1be68
to
739c056
Compare
zacharygolba
force-pushed
the
refactor-use-jest
branch
from
March 25, 2017 16:09
a1fe5c6
to
44d788a
Compare
zacharygolba
force-pushed
the
refactor-use-jest
branch
from
May 20, 2017 21:33
be9642b
to
2304144
Compare
zacharygolba
force-pushed
the
refactor-use-jest
branch
from
May 20, 2017 21:51
24094ea
to
0279f3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces chai and mocha with jest. This is the first step towards a public testing api as well as environment agnostic lux applications (node, lambda, testing, etc.).
I am merging this PR in order to move forward with the remaining work in small chunks. I'll add a link to the tracking issue once it's up.
To maintain stability, postlight/lux#master will become the place where beta releases are cut and postlight/lux#stable will be where releases are cut.