Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use jest instead of mocha + chai #681

Merged
merged 144 commits into from
May 20, 2017
Merged

Conversation

zacharygolba
Copy link
Contributor

@zacharygolba zacharygolba commented Feb 16, 2017

This PR replaces chai and mocha with jest. This is the first step towards a public testing api as well as environment agnostic lux applications (node, lambda, testing, etc.).

I am merging this PR in order to move forward with the remaining work in small chunks. I'll add a link to the tracking issue once it's up.

To maintain stability, postlight/lux#master will become the place where beta releases are cut and postlight/lux#stable will be where releases are cut.

@codecov-io
Copy link

codecov-io commented Feb 17, 2017

Codecov Report

Merging #681 into master will decrease coverage by 2.11%.
The diff coverage is 90.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #681      +/-   ##
==========================================
- Coverage    92.4%   90.28%   -2.12%     
==========================================
  Files         180      194      +14     
  Lines        2014     2090      +76     
  Branches        0      430     +430     
==========================================
+ Hits         1861     1887      +26     
- Misses        153      181      +28     
- Partials        0       22      +22
Impacted Files Coverage Δ
src/packages/fs/watcher/index.js 100% <ø> (ø) ⬆️
src/packages/database/model/utils/persistence.js 100% <ø> (ø) ⬆️
src/packages/compiler/utils/is-external.js 100% <ø> (ø) ⬆️
src/packages/loader/resolver/index.js 0% <ø> (ø) ⬆️
...rc/packages/loader/resolver/utils/closest-child.js 100% <ø> (ø) ⬆️
src/packages/database/utils/create-migrations.js 100% <ø> (+40%) ⬆️
src/packages/fs/utils/parse-path.js 100% <ø> (+100%) ⬆️
...ages/database/query/runner/utils/get-find-param.js 85.71% <ø> (ø) ⬆️
src/packages/controller/utils/params-to-query.js 100% <ø> (ø) ⬆️
src/packages/jsonapi/utils/has-media-type.js 100% <ø> (ø) ⬆️
... and 248 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1691f9a...d40bd60. Read the comment docs.

* docs: add code of conduct and contributing documentation

fix: duplicate source materials entry in contributing.md

docs: add preliminary content to code of conduct

dx: add .nvmrc file (#672)

docs: add build and test steps to contributing.md

docs: add issue template

docs: fix linter error for issue template

docs: add docs for making documentation contributions

docs: add link to rfcs repository in contributing.md

docs: update readme and remove roadmap in favor of lux-rfcs repo

style: whitespace change in contributing.md

docs: left align column 2 of the commit style table in contributing.md

docs: missing punctuation in code of conduct

dx: add .nvmrc file (#672)

docs: change irc to gitter in code of conduct

* docs: use [email protected] instead of [email protected]

* docs: copy changes in code of conduct

docs: copy changes in code of conduct

* docs: typo in contribting.md

* docs: copy changes in contributing.md

* docs: add instructions for reporting security vulnerabilities

* docs: add a link to flow documentation in contributing.md

* docs: typo in contributing.md

* docs: add webstorm flow docs to contributing.md

* docs: remove unecessary "that" in contributing.md

* docs: widen the scope of the second bullet in the code of conduct

* docs: add pull request template

* docs: add "ways to contribute" section to contributing.md
@zacharygolba zacharygolba merged commit d4be531 into master May 20, 2017
@zacharygolba zacharygolba deleted the refactor-use-jest branch June 18, 2017 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants