Updated line split logic, normalize all linebreaks to \r\n #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@willpower232 i see many issues posted saying they are facing the issue "530 From/Sender name is not valid". We also were stuck there, maybe this will fix them too.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
Some emails were being rejected with error 530 From/Sender name is not valid but it was working with different smtp servers (google, mailgun etc) and when we looked further, we could see that the @headers variable was not getting "from" field at all even through its there in the email payload. Further investigating we figured out that the message payload has inconsistent \r\n and \n and Postal was not able to parse it correctly. We could fix it by normalizing it to convert all \n and \r\n to just use \r\n on every linebreak. Please check this pull request which fixed this issue.
Thanks