Fix various memory leaks #2479
Merged
Fix various memory leaks #2479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4dcc6ae
to
d8a1a8b
Compare
|
@Praetonus before this gets merged can you update the commit to have a commit message that describes what is being fixed. "Various memory leaks" will end up being a nightmare when doing history spelunking without more information. |
|
@SeanTAllen I'll update. |
- Leak in `genexe` and`codegen_gen_test` with the ASTs built to reach `Main.create` and `Env._create`. - Leak in the `ffi_decls_t` and `tbaa_metadatas_t` hashmap wheres no elements were being freed. - Leak in `genfun_forward` with the buffer used to convert arguments. - Leak in `eq_param_type` with the method lookup data structure. - Leak in `unsafe_number_conversion` when doing an early return in the function. - Leak in `expr_lambda` with various type inference ASTs. - Leak in `ifdef_cond_normalise` with the build configuration data structure.
d8a1a8b
to
842e4da
Compare
jemc
approved these changes
Jan 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.