core/config: add support for stripping the port for matching routes #5085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenjenkins
approved these changes
Apr 25, 2024
| "from-url: %s\nrequest-url: %s", tc.pattern, tc.input) | ||
| } | ||
| } | ||
|
|
||
| func TestWildcardToRegex(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| re, err := regexp.Compile(WildcardToRegex("*.internal.*.example.com")) | ||
| re, err := regexp.Compile(WildcardToRegex("*.internal.*.example.com", true)) |
There was a problem hiding this comment.
Would it be worth adding a unit test exercise the WildcardToRegex(..., false) code path too?
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Change the way route matching works so that if a route is defined without an explicit port that route will match a request on any port.
The current behavior is that a route defined without an explicit port will only match a request with no port, or port
:443.For example, with the current behavior a route like:
Would match incoming requests for
https://www.example.comorhttps://www.example.com:443, but nothttps://www.example.com:8443.With the new behavior all 3 routes would match.
This new behavior can be disabled via a runtime flag (
match_any_incoming_port), but the default is enabled since we believe its unlikely to break existing configurations.TCP routes should behave as they do currently. The port is always required for them and must match explicitly.
Related issues
Checklist
improvement/bug/ etc)