fetch binary built for oldest macOS version #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like Homebrew builds binaries for the three latest versions of macOS (for both amd64 and arm64). Currently it looks like the fetch-envoy script may end up downloading any one of the three available binaries for a specific architecture. Let's update this script so that it will choose the binary built for the oldest available macOS version, as that should provide the widest compatibility. We can do this by first fetching the multi-platform manifest, filtering by OS and architecture, and then finding the minimum OS version. (Note that the OS version is a text string like "macOS 12.6". Comparing these strings may not be totally correct in general, but I think it should give a correct result while the major version still has two digits.)
wasaga
approved these changes
Oct 23, 2023
| ( | ||
| cd "$_tmp_dir" | ||
| _digest=$(oras manifest fetch "ghcr.io/homebrew/core/envoy:${_version}" | | ||
| jq -r ".manifests | |
There was a problem hiding this comment.
Is jq available in the default tools for action runner ?
There was a problem hiding this comment.
I think so. It's listed here: https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2204-Readme.md#tools.
calebdoxsey
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like Homebrew builds binaries for the three latest versions of macOS (for both amd64 and arm64). Currently it looks like the fetch-envoy script may end up downloading any one of the three available binaries for a specific architecture.
Let's update this script so that it will choose the binary built for the oldest available macOS version, as that should provide the widest compatibility. We can do this by first fetching the multi-platform manifest, filtering by OS and architecture, and then finding the minimum OS version.
(Note that the OS version is a text string like "macOS 12.6". Comparing these strings may not be totally correct in general, but I think it should give a correct result while the major version still has two digits.)