Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add k8s proxy protocol #801

Merged
merged 8 commits into from
Jul 7, 2023
Merged

Conversation

ZPain8464
Copy link
Contributor

Resolves #797

This PR adds the K8s annotation to /docs/reference/use-proxy-protocol and to /docs/deploy/k8s/ingress. @wasaga Not sure about the location for this entry on the Ingress page; please let me know if it should go somewhere else.

@ZPain8464 ZPain8464 added the docs label Jul 6, 2023
@ZPain8464 ZPain8464 requested a review from a team as a code owner July 6, 2023 15:04
@ZPain8464 ZPain8464 requested review from cmo-pomerium and removed request for a team July 6, 2023 15:04
@netlify
Copy link

netlify bot commented Jul 6, 2023

Deploy Preview for pomerium-docs ready!

Name Link
🔨 Latest commit 867e482
🔍 Latest deploy log https://app.netlify.com/sites/pomerium-docs/deploys/64a81c5ea6d8e6000829381f
😎 Deploy Preview https://deploy-preview-801--pomerium-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@wasaga wasaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is global CRD parameter, not an ingress annotation

useProxyProtocol: true

please merge main and reference the relevant section in the reference.md

@ZPain8464 ZPain8464 requested a review from wasaga July 7, 2023 14:09

Pomerium posts updates to the CRD <a href="#status">`/status`</a>:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add prettier step for reference.md in the docs action in the origin pomerium/ingress-controller directory.

@ZPain8464 ZPain8464 merged commit 888af69 into main Jul 7, 2023
7 checks passed
@ZPain8464 ZPain8464 deleted the zpain/add-k8s-proxy-protocol branch July 7, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document Use Proxy Protocol configuration for Kubernetes
2 participants