Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: adds apple idp guide #641

Merged
merged 6 commits into from
May 30, 2023
Merged

Docs: adds apple idp guide #641

merged 6 commits into from
May 30, 2023

Conversation

ZPain8464
Copy link
Contributor

@ZPain8464 ZPain8464 commented May 24, 2023

The Apple IdP is not configurable in the Console yet, so this guide only covers configuration for Core. I can create a follow-up PR if adding to Console is a priority in the near future.

@ZPain8464 ZPain8464 requested a review from a team as a code owner May 24, 2023 17:32
@ZPain8464 ZPain8464 requested review from cmo-pomerium and removed request for a team May 24, 2023 17:32
@netlify
Copy link

netlify bot commented May 24, 2023

Deploy Preview for pomerium-docs ready!

Name Link
🔨 Latest commit 22a8dd5
🔍 Latest deploy log https://app.netlify.com/sites/pomerium-docs/deploys/6475f839b1bfe3000820629f
😎 Deploy Preview https://deploy-preview-641--pomerium-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ZPain8464
Copy link
Contributor Author

Fixes #612

Copy link
Collaborator

@desimone desimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Only suggestion is we carry a similar callout that the providers may change like we do with the other guides

CAUTION
While we do our best to keep our documentation up to date, ......

@ZPain8464 ZPain8464 merged commit 1c2afce into main May 30, 2023
5 checks passed
@ZPain8464 ZPain8464 deleted the zpain/apple-idp-guide branch May 30, 2023 13:43
backport-actions-token bot pushed a commit that referenced this pull request May 30, 2023
* adds appleid file

* basic appleid outline

* added apple setup steps

* updates apple id guide

* runs yarn format

* adds third-party caution notice to guide
ZPain8464 added a commit that referenced this pull request May 30, 2023
Docs: adds apple idp guide (#641)

* adds appleid file

* basic appleid outline

* added apple setup steps

* updates apple id guide

* runs yarn format

* adds third-party caution notice to guide

Co-authored-by: zachary painter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants