Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: adds guides index file #457

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Docs: adds guides index file #457

merged 1 commit into from
Mar 6, 2023

Conversation

ZPain8464
Copy link
Contributor

After the re-org for v20, the 'guides.md' file was removed. This caused the "Guides" navbar button to link to category/guides. This affects links that redirect to docs/guides; even if the redirect file redirects 404ing links to category/guides, it redirects instead to the Pomerium homepage.

If approved I'll create an issue and include it with this PR in the 404 epic for March, as it should redirect docs/guides links to the correct page.

@ZPain8464 ZPain8464 added backport 0-20-0 Backports this PR to branch 0-20-0 backport 0-21-0 labels Mar 6, 2023
@ZPain8464 ZPain8464 requested a review from desimone March 6, 2023 21:16
@ZPain8464 ZPain8464 requested a review from a team as a code owner March 6, 2023 21:16
@ZPain8464 ZPain8464 requested review from cmo-pomerium and removed request for a team March 6, 2023 21:16
@netlify
Copy link

netlify bot commented Mar 6, 2023

Deploy Preview for pomerium-docs ready!

Name Link
🔨 Latest commit 2ee8c9d
🔍 Latest deploy log https://app.netlify.com/sites/pomerium-docs/deploys/6406582f92cd6c00087cf846
😎 Deploy Preview https://deploy-preview-457--pomerium-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ZPain8464 ZPain8464 merged commit 6ca95ab into main Mar 6, 2023
@ZPain8464 ZPain8464 deleted the zpain/guides-updates branch March 6, 2023 21:21
@backport-actions-token
Copy link

The backport to 0-20-0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-0-20-0 0-20-0
# Navigate to the new working tree
cd .worktrees/backport-0-20-0
# Create a new branch
git switch --create backport-457-to-0-20-0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 6ca95ab5158ab8c7367d84ec1611b034f9caec7a
# Push it to GitHub
git push --set-upstream origin backport-457-to-0-20-0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-0-20-0

Then, create a pull request where the base branch is 0-20-0 and the compare/head branch is backport-457-to-0-20-0.

backport-actions-token bot pushed a commit that referenced this pull request Mar 6, 2023
@ZPain8464
Copy link
Contributor Author

Fix here #461

ZPain8464 added a commit that referenced this pull request Mar 6, 2023
Docs: adds guides index file (#457)

adds guides index file

Co-authored-by: zachary painter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 0-20-0 Backports this PR to branch 0-20-0 backport 0-21-0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants